From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5175BC433FE for ; Fri, 10 Sep 2021 00:18:48 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E288610A3 for ; Fri, 10 Sep 2021 00:18:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E288610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mOUFj-0001Vj-32; Fri, 10 Sep 2021 00:18:47 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOUFi-0001Vd-2S for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Sep 2021 00:18:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ou1UO12ZaTOfPVF8+b25K6U22EtHvd3+SgZVl9/Mflw=; b=G5rMGBuVRQ8trclAcbzPZ8KYp8 MYkAl7munkzQ6jLwiWaBLZr1Qb5DCut6zgHc5oyCcgqZg/n2ppsn4mR8XvfoB4dZxC9p0mPHkb2mM yu2gPUuGn6NUAzgHJ4z7cREQgLQs8QmsDSs6TNiW0RqFodSwwYenjYd/MoAN6OI9d6+0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ou1UO12ZaTOfPVF8+b25K6U22EtHvd3+SgZVl9/Mflw=; b=WDzPCoBecDpxWILRxe5Fi28aH8 RyozDvy8RYPfGmYQnlqkuvYN1RJfmmU8/kPV5k7+m8UFPTtzca3XAIey7HK/0/poPpbky79a0RQFt dOKIxnWHJ5EnJGt2uFYOvmQ5wulGiHzyhw0wykYcPIVqdMzM4LtkgWSbKeUXmTts4XzI=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mOUFh-0004VU-HO for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Sep 2021 00:18:46 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8BFA46023D; Fri, 10 Sep 2021 00:18:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233119; bh=8HublyiwEV4fCI0eq4NiQnN+jf5XNaik78Qk8UPkgPg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tw0wfEp8Y7JZl4deljtwIxl8P4bdELPWBRhMK4FFZPVnHt+j4zlsYhF2puoigMWpR b4lSa6iF8lv0rMDAj3WAxzw9esH2rxJJvqRtP5SuRC5ZD/yHrkZ127rIEqb6xBZegt vVL/dJj41lcxx2X5O0vhvubkPgSc69dAf+tkM87lmSgV9mauoAyDlJLOq5BpX29847 TJuJBlenqRxvXLvzrWLtcweUke8eoW8uq0o2XvSHVgICQ5SfNnJuTw93xPuuSD5iik TpHa8rXG2G4JttH7h6p4YUC2R5sG4+WYqq4sgqZG1urHmZ+oPv3oqENgsgVtcXav7U il01/sZNg7MIg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Thu, 9 Sep 2021 20:17:05 -0400 Message-Id: <20210910001820.174272-13-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910001820.174272-1-sashal@kernel.org> References: <20210910001820.174272-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-Headers-End: 1mOUFh-0004VU-HO Subject: [f2fs-dev] [PATCH AUTOSEL 5.13 13/88] f2fs: Revert "f2fs: Fix indefinite loop in f2fs_gc() v1" X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net From: Jia Yang [ Upstream commit 10d0786b39b3b91c4fbf8c2926e97ab456a4eea1 ] This reverts commit 957fa47823dfe449c5a15a944e4e7a299a6601db. The patch "f2fs: Fix indefinite loop in f2fs_gc()" v1 and v4 are all merged. Patch v4 is test info for patch v1. Patch v1 doesn't work and may cause that sbi->cur_victim_sec can't be resetted to NULL_SEGNO, which makes SSR unable to get segment of sbi->cur_victim_sec. So it should be reverted. The mails record: [1] https://lore.kernel.org/linux-f2fs-devel/7288dcd4-b168-7656-d1af-7e2cafa4f720@huawei.com/T/ [2] https://lore.kernel.org/linux-f2fs-devel/20190809153653.GD93481@jaegeuk-macbookpro.roam.corp.google.com/T/ Signed-off-by: Jia Yang Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/gc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index ab63951c08cb..a6857f094522 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1746,7 +1746,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, round++; } - if (gc_type == FG_GC && seg_freed) + if (gc_type == FG_GC) sbi->cur_victim_sec = NULL_SEGNO; if (sync) -- 2.30.2 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537E4C433F5 for ; Fri, 10 Sep 2021 00:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 359B9610C9 for ; Fri, 10 Sep 2021 00:48:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242985AbhIJAtZ (ORCPT ); Thu, 9 Sep 2021 20:49:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:46042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233340AbhIJATt (ORCPT ); Thu, 9 Sep 2021 20:19:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8BFA46023D; Fri, 10 Sep 2021 00:18:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233119; bh=8HublyiwEV4fCI0eq4NiQnN+jf5XNaik78Qk8UPkgPg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tw0wfEp8Y7JZl4deljtwIxl8P4bdELPWBRhMK4FFZPVnHt+j4zlsYhF2puoigMWpR b4lSa6iF8lv0rMDAj3WAxzw9esH2rxJJvqRtP5SuRC5ZD/yHrkZ127rIEqb6xBZegt vVL/dJj41lcxx2X5O0vhvubkPgSc69dAf+tkM87lmSgV9mauoAyDlJLOq5BpX29847 TJuJBlenqRxvXLvzrWLtcweUke8eoW8uq0o2XvSHVgICQ5SfNnJuTw93xPuuSD5iik TpHa8rXG2G4JttH7h6p4YUC2R5sG4+WYqq4sgqZG1urHmZ+oPv3oqENgsgVtcXav7U il01/sZNg7MIg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia Yang , Chao Yu , Jaegeuk Kim , Sasha Levin , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.13 13/88] f2fs: Revert "f2fs: Fix indefinite loop in f2fs_gc() v1" Date: Thu, 9 Sep 2021 20:17:05 -0400 Message-Id: <20210910001820.174272-13-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910001820.174272-1-sashal@kernel.org> References: <20210910001820.174272-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia Yang [ Upstream commit 10d0786b39b3b91c4fbf8c2926e97ab456a4eea1 ] This reverts commit 957fa47823dfe449c5a15a944e4e7a299a6601db. The patch "f2fs: Fix indefinite loop in f2fs_gc()" v1 and v4 are all merged. Patch v4 is test info for patch v1. Patch v1 doesn't work and may cause that sbi->cur_victim_sec can't be resetted to NULL_SEGNO, which makes SSR unable to get segment of sbi->cur_victim_sec. So it should be reverted. The mails record: [1] https://lore.kernel.org/linux-f2fs-devel/7288dcd4-b168-7656-d1af-7e2cafa4f720@huawei.com/T/ [2] https://lore.kernel.org/linux-f2fs-devel/20190809153653.GD93481@jaegeuk-macbookpro.roam.corp.google.com/T/ Signed-off-by: Jia Yang Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/gc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index ab63951c08cb..a6857f094522 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1746,7 +1746,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, round++; } - if (gc_type == FG_GC && seg_freed) + if (gc_type == FG_GC) sbi->cur_victim_sec = NULL_SEGNO; if (sync) -- 2.30.2