From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F96EC41535 for ; Fri, 10 Sep 2021 00:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0931F61108 for ; Fri, 10 Sep 2021 00:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231229AbhIJAmN (ORCPT ); Thu, 9 Sep 2021 20:42:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:46756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233706AbhIJAUk (ORCPT ); Thu, 9 Sep 2021 20:20:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B373E610E9; Fri, 10 Sep 2021 00:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233170; bh=KLd+OUWee6OE1PGCgCqHKf9kavtJESIJfNBfnauKDN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l73uTNJoZWCd9Pb/cwkkmCZJ3FkpK0i5qRGFXXGsQiYI6WGnzGfNnndmiaO/07Peh TB6E5dkwmnDNyfNzF9izkhVnuG02I+VXL58Quc1NrNmAA4hCbpf1b7K+d+A8LTn2BC rDSrRROI3CPYctHuF+xss0Pyx1234EkrUff9PyDdUCMLEHjcd8TyPrh/2IblLmpAAR foK2lNN1IZ0zXt7IycyoZd6Dh4VQyEDXW8dK9SGN9n2YL2zVD98m2pCCDYP+0I6H6v rX+c+WwShL/KfoqMhRbGfvsfTwumjRLcC9LFFMrGumAuG1FVJP9Bw0oSFySHyz3JKd f+CQNECIKRd2A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Evgeny Novikov , Jiri Kosina , Sasha Levin , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.13 49/88] HID: thrustmaster: Fix memory leak in thrustmaster_interrupts() Date: Thu, 9 Sep 2021 20:17:41 -0400 Message-Id: <20210910001820.174272-49-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910001820.174272-1-sashal@kernel.org> References: <20210910001820.174272-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Evgeny Novikov [ Upstream commit c3800eed22d21c66912b4461a403b4448ed88d95 ] thrustmaster_interrupts() does not free memory for send_buf when usb_interrupt_msg() fails. This is fixed by the given patch. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-thrustmaster.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c index 3d49f22a9368..7c00c48cc20b 100644 --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -173,6 +173,7 @@ static void thrustmaster_interrupts(struct hid_device *hdev) if (ret) { hid_err(hdev, "setup data couldn't be sent\n"); + kfree(send_buf); return; } } -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E4FC433F5 for ; Fri, 10 Sep 2021 00:29:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0AFA61059 for ; Fri, 10 Sep 2021 00:29:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A0AFA61059 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s1ye146z7ze4fg4BOebjeyUuNEEmk1YVrBii9ONrEi0=; b=IdnxbxmssCJRbv Z28QpW9mJ5aivqTyRB5eGnUNvFW+F4S95RbA2RwnAPZJFeUWtXUZx4jIpJYy1UsV+9j9ybye0ue7a XGRIB/Hpvv0WzhhakTREFcTTYVqeO9NILolj/TzGyV9v5YNNJTLofDbxDlN+uFfBQfP14qVcWyNlH jV4kSXa/rSFfc/bzVM9Tlv86KBE9uwRJdrWLIknjDGRNVOhaZ5cDceCVxS3ujKSttgDYXTzRlf1k9 EeB2atmf8SUzXa+RACdmle5kD15LOWs23qsez6fyAR+7vqIPF8JvhPHswINylI3mmzHMepI8KoE31 6o8BJ9edzfb+ZPYXmq/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOUOD-00BIdA-RE; Fri, 10 Sep 2021 00:27:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOUGQ-00BEho-Sg for linux-arm-kernel@lists.infradead.org; Fri, 10 Sep 2021 00:19:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B373E610E9; Fri, 10 Sep 2021 00:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233170; bh=KLd+OUWee6OE1PGCgCqHKf9kavtJESIJfNBfnauKDN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l73uTNJoZWCd9Pb/cwkkmCZJ3FkpK0i5qRGFXXGsQiYI6WGnzGfNnndmiaO/07Peh TB6E5dkwmnDNyfNzF9izkhVnuG02I+VXL58Quc1NrNmAA4hCbpf1b7K+d+A8LTn2BC rDSrRROI3CPYctHuF+xss0Pyx1234EkrUff9PyDdUCMLEHjcd8TyPrh/2IblLmpAAR foK2lNN1IZ0zXt7IycyoZd6Dh4VQyEDXW8dK9SGN9n2YL2zVD98m2pCCDYP+0I6H6v rX+c+WwShL/KfoqMhRbGfvsfTwumjRLcC9LFFMrGumAuG1FVJP9Bw0oSFySHyz3JKd f+CQNECIKRd2A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Evgeny Novikov , Jiri Kosina , Sasha Levin , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.13 49/88] HID: thrustmaster: Fix memory leak in thrustmaster_interrupts() Date: Thu, 9 Sep 2021 20:17:41 -0400 Message-Id: <20210910001820.174272-49-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910001820.174272-1-sashal@kernel.org> References: <20210910001820.174272-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210909_171931_009209_45F1B15D X-CRM114-Status: UNSURE ( 9.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Evgeny Novikov [ Upstream commit c3800eed22d21c66912b4461a403b4448ed88d95 ] thrustmaster_interrupts() does not free memory for send_buf when usb_interrupt_msg() fails. This is fixed by the given patch. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-thrustmaster.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c index 3d49f22a9368..7c00c48cc20b 100644 --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -173,6 +173,7 @@ static void thrustmaster_interrupts(struct hid_device *hdev) if (ret) { hid_err(hdev, "setup data couldn't be sent\n"); + kfree(send_buf); return; } } -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel