From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 321A9C433EF for ; Fri, 10 Sep 2021 17:57:18 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87D12611CB for ; Fri, 10 Sep 2021 17:57:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 87D12611CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4H5k975qBxz305X for ; Sat, 11 Sep 2021 03:57:15 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4H5k8V6859z2yNG for ; Sat, 11 Sep 2021 03:56:41 +1000 (AEST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 18AHsVaI011440; Fri, 10 Sep 2021 12:54:32 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 18AHsQqX011420; Fri, 10 Sep 2021 12:54:26 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 10 Sep 2021 12:54:25 -0500 From: Segher Boessenkool To: Nicholas Piggin Subject: Re: [PATCH v1] powerpc: flexible GPR range save/restore macros Message-ID: <20210910175425.GZ1583@gate.crashing.org> References: <20210910143511.375177-1-npiggin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210910143511.375177-1-npiggin@gmail.com> User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi! On Sat, Sep 11, 2021 at 12:35:11AM +1000, Nicholas Piggin wrote: > +.macro OP_REGS op, width, start, end, base, offset > + .Lreg=\start > + .rept (\end - \start + 1) > + \op .Lreg,\offset+\width*.Lreg(\base) > + .Lreg=.Lreg+1 > + .endr > +.endm "offset" here is the offset of reg "0", not the offset of reg "start". This isn't new, but documenting it would not hurt :-) ".Lreg" does not really give you much protection, you could use any name that won't collide, it will be a local symbol anyway. You could use a name with a "$" in it, even as first letter, for example. As written it still conflicts with any other symbol ".Lreg". Pretty unlikely of course :-) Looks fine in any case. Reviewed-by: Segher Boessenkool Segher