From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Pali Rohár" <pali@kernel.org>,
"Oliver O'Halloran" <oohall@gmail.com>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
linux-pci@vger.kernel.org
Subject: [PATCH v2 1/7] PCI/sysfs: Add pci_dev_resource_attr_is_visible() helper
Date: Fri, 10 Sep 2021 20:26:17 +0000 [thread overview]
Message-ID: <20210910202623.2293708-2-kw@linux.com> (raw)
In-Reply-To: <20210910202623.2293708-1-kw@linux.com>
This helper controls how a static sysfs attribute is exposed, where
depending on whether a particular resource is available (the BAR address
space requested has non-zero size) or whether the write-combine feature
is supported, the sysfs attribute will be made either visible or hidden.
After the conversion to use static sysfs objects when exposing each PCI
BAR address space this helper is to be called from the .is_bin_visible()
callback for each of the PCI resources attributes groups.
A single BAR will have a dedicated attribute group with two attributes
in it - one normal resource and one that can potentially support the
write-combine feature.
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
drivers/pci/pci-sysfs.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 7fb5cd17cc98..4272d1aba205 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -1237,6 +1237,30 @@ static int pci_create_resource_files(struct pci_dev *pdev)
}
return 0;
}
+
+static umode_t pci_dev_resource_attr_is_visible(struct kobject *kobj,
+ struct bin_attribute *a,
+ int bar, bool write_combine)
+{
+ struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));
+ resource_size_t resource_size = pci_resource_len(pdev, bar);
+ bool prefetch;
+
+ if (!resource_size)
+ return 0;
+
+ prefetch = (pci_resource_flags(pdev, bar) &
+ (IORESOURCE_MEM | IORESOURCE_PREFETCH)) ==
+ (IORESOURCE_MEM | IORESOURCE_PREFETCH);
+
+ if (write_combine && !(prefetch && arch_can_pci_mmap_wc()))
+ return 0;
+
+ a->size = resource_size;
+
+ return a->attr.mode;
+};
+
#else /* !(defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)) */
int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }
void __weak pci_remove_resource_files(struct pci_dev *dev) { return; }
--
2.33.0
next prev parent reply other threads:[~2021-09-10 20:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 20:26 [PATCH v2 0/7] PCI: Convert dynamic PCI resources sysfs objects into static Krzysztof Wilczyński
2021-09-10 20:26 ` Krzysztof Wilczyński [this message]
2021-09-10 20:26 ` [PATCH v2 2/7] PCI/sysfs: Add pci_dev_resource_attr() macro Krzysztof Wilczyński
2021-09-10 20:26 ` [PATCH v2 3/7] PCI/sysfs: Only allow IORESOURCE_IO in pci_resource_io() Krzysztof Wilczyński
2021-09-10 20:26 ` [PATCH v2 4/7] PCI/sysfs: Only allow supported resource type in pci_mmap_resource() Krzysztof Wilczyński
2021-09-10 20:26 ` [PATCH v2 5/7] PCI/sysfs: Convert PCI resource files to static attributes Krzysztof Wilczyński
2021-09-10 20:26 ` [PATCH v2 6/7] PCI/sysfs: Rename pci_read_resource_io() and pci_write_resource_io() Krzysztof Wilczyński
2021-09-10 20:26 ` [PATCH v2 7/7] PCI/sysfs: Update code to match the preferred style Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910202623.2293708-2-kw@linux.com \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=khalasa@piap.pl \
--cc=linux-pci@vger.kernel.org \
--cc=oohall@gmail.com \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.