From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
martin@kaiser.cx, fmdefrancesco@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Straube <straube.linux@gmail.com>
Subject: [PATCH 01/18] staging: r8188eu: remove empty ODM_ReleaseTimer()
Date: Sat, 11 Sep 2021 15:26:18 +0200 [thread overview]
Message-ID: <20210911132635.30369-2-straube.linux@gmail.com> (raw)
In-Reply-To: <20210911132635.30369-1-straube.linux@gmail.com>
Function ODM_ReleaseTimer() is empty and its only caller is
ODM_ReleaseAllTimers(). Remove both functions.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
drivers/staging/r8188eu/hal/odm.c | 7 -------
drivers/staging/r8188eu/hal/odm_interface.c | 4 ----
drivers/staging/r8188eu/include/odm.h | 2 --
drivers/staging/r8188eu/include/odm_interface.h | 2 --
4 files changed, 15 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
index f0fd88d98e95..011ebcdac797 100644
--- a/drivers/staging/r8188eu/hal/odm.c
+++ b/drivers/staging/r8188eu/hal/odm.c
@@ -1414,13 +1414,6 @@ void ODM_CancelAllTimers(struct odm_dm_struct *pDM_Odm)
ODM_CancelTimer(pDM_Odm, &pDM_Odm->DM_SWAT_Table.SwAntennaSwitchTimer);
}
-void ODM_ReleaseAllTimers(struct odm_dm_struct *pDM_Odm)
-{
- ODM_ReleaseTimer(pDM_Odm, &pDM_Odm->DM_SWAT_Table.SwAntennaSwitchTimer);
-
- ODM_ReleaseTimer(pDM_Odm, &pDM_Odm->FastAntTrainingTimer);
-}
-
/* 3============================================================ */
/* 3 Tx Power Tracking */
/* 3============================================================ */
diff --git a/drivers/staging/r8188eu/hal/odm_interface.c b/drivers/staging/r8188eu/hal/odm_interface.c
index 5a01495d74bc..c33ef4736ff6 100644
--- a/drivers/staging/r8188eu/hal/odm_interface.c
+++ b/drivers/staging/r8188eu/hal/odm_interface.c
@@ -165,10 +165,6 @@ void ODM_CancelTimer(struct odm_dm_struct *pDM_Odm, struct timer_list *pTimer)
_cancel_timer_ex(pTimer);
}
-void ODM_ReleaseTimer(struct odm_dm_struct *pDM_Odm, struct timer_list *pTimer)
-{
-}
-
/* ODM FW relative API. */
u32 ODM_FillH2CCmd(u8 *pH2CBuffer, u32 H2CBufferLen, u32 CmdNum,
u32 *pElementID, u32 *pCmdLen,
diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
index 7c8f082930dd..a100fdf87379 100644
--- a/drivers/staging/r8188eu/include/odm.h
+++ b/drivers/staging/r8188eu/include/odm.h
@@ -1139,8 +1139,6 @@ void ODM_InitAllTimers(struct odm_dm_struct *pDM_Odm);
void ODM_CancelAllTimers(struct odm_dm_struct *pDM_Odm);
-void ODM_ReleaseAllTimers(struct odm_dm_struct *pDM_Odm);
-
void ODM_AntselStatistics_88C(struct odm_dm_struct *pDM_Odm, u8 MacId,
u32 PWDBAll, bool isCCKrate);
diff --git a/drivers/staging/r8188eu/include/odm_interface.h b/drivers/staging/r8188eu/include/odm_interface.h
index 6b589413d56c..9109d72915cd 100644
--- a/drivers/staging/r8188eu/include/odm_interface.h
+++ b/drivers/staging/r8188eu/include/odm_interface.h
@@ -137,8 +137,6 @@ void ODM_InitializeTimer(struct odm_dm_struct *pDM_Odm,
void ODM_CancelTimer(struct odm_dm_struct *pDM_Odm, struct timer_list *pTimer);
-void ODM_ReleaseTimer(struct odm_dm_struct *pDM_Odm, struct timer_list *pTimer);
-
/* ODM FW relative API. */
u32 ODM_FillH2CCmd(u8 *pH2CBuffer, u32 H2CBufferLen, u32 CmdNum,
u32 *pElementID, u32 *pCmdLen, u8 **pCmbBuffer,
--
2.33.0
next prev parent reply other threads:[~2021-09-11 13:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 13:26 [PATCH 00/18] staging: r8188eu: remove unused functions from odm_interface.c Michael Straube
2021-09-11 13:26 ` Michael Straube [this message]
2021-09-11 13:26 ` [PATCH 02/18] staging: r8188eu: remove unused ODM_AcquireSpinLock() Michael Straube
2021-09-11 13:26 ` [PATCH 03/18] staging: r8188eu: remove unused ODM_ReleaseSpinLock() Michael Straube
2021-09-11 13:26 ` [PATCH 04/18] staging: r8188eu: remove unused ODM_FillH2CCmd() Michael Straube
2021-09-11 13:26 ` [PATCH 05/18] staging: r8188eu: remove unused ODM_sleep_us() Michael Straube
2021-09-11 13:26 ` [PATCH 06/18] staging: r8188eu: remove unused ODM_InitializeWorkItem() Michael Straube
2021-09-11 13:26 ` [PATCH 07/18] staging: r8188eu: remove unused ODM_StartWorkItem() Michael Straube
2021-09-11 13:26 ` [PATCH 08/18] staging: r8188eu: remove unused ODM_StopWorkItem() Michael Straube
2021-09-11 13:26 ` [PATCH 09/18] staging: r8188eu: remove unused ODM_FreeWorkItem() Michael Straube
2021-09-11 13:26 ` [PATCH 10/18] staging: r8188eu: remove unused ODM_ScheduleWorkItem() Michael Straube
2021-09-11 13:26 ` [PATCH 11/18] staging: r8188eu: remove unused ODM_IsWorkItemScheduled() Michael Straube
2021-09-11 13:26 ` [PATCH 12/18] staging: r8188eu: remove unused ODM_SetTimer() Michael Straube
2021-09-11 13:26 ` [PATCH 13/18] staging: r8188eu: remove unused ODM_Read2Byte() Michael Straube
2021-09-11 13:26 ` [PATCH 14/18] staging: r8188eu: remove unused ODM_FreeMemory() Michael Straube
2021-09-11 13:26 ` [PATCH 15/18] staging: r8188eu: remove unused ODM_AllocateMemory() Michael Straube
2021-09-11 13:26 ` [PATCH 16/18] staging: r8188eu: remove unused prototype ODM_InitializeTimer() Michael Straube
2021-09-11 13:26 ` [PATCH 17/18] staging: r8188eu: remove unused ODM_CancelAllTimers() Michael Straube
2021-09-11 13:26 ` [PATCH 18/18] staging: r8188eu: remove unused ODM_InitAllTimers() Michael Straube
2021-09-11 14:20 ` [PATCH 00/18] staging: r8188eu: remove unused functions from odm_interface.c Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210911132635.30369-2-straube.linux@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.