From: "Richard W.M. Jones" <rjones@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: vsementsov@virtuozzo.com, Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] nbd/server: Suppress Broken pipe errors on abrupt disconnection
Date: Mon, 13 Sep 2021 16:16:31 +0100 [thread overview]
Message-ID: <20210913151631.GG26415@redhat.com> (raw)
In-Reply-To: <YT9pILPJc5azU9nH@redhat.com>
On Mon, Sep 13, 2021 at 05:07:12PM +0200, Kevin Wolf wrote:
> > > if (ret < 0) {
> > > - error_prepend(&local_err, "Failed to send reply: ");
> > > + if (errno != EPIPE) {
> > > + error_prepend(&local_err, "Failed to send reply: ");
> > > + } else {
> > > + local_err = NULL;
> >
> > This line should be error_free(local_err) to avoid a memleak.
>
> Actually, you want both error_free(local_err) and local_err = NULL.
Give me a few mins to test an post a new version that at least
fixes this bug ...
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/
prev parent reply other threads:[~2021-09-13 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 10:45 [PATCH] nbd/server: Suppress Broken pipe errors on abrupt disconnection Richard W.M. Jones
2021-07-22 10:45 ` Richard W.M. Jones
2021-07-23 15:49 ` Eric Blake
2021-09-13 15:07 ` Kevin Wolf
2021-09-13 15:16 ` Richard W.M. Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913151631.GG26415@redhat.com \
--to=rjones@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.