All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Anton Eidelman <anton.eidelman@gmail.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, kbusch@kernel.org,
	sagi@grimberg.me, axboe@fb.com,
	Anton Eidelman <anton@lightbitslabs.com>
Subject: Re: [PATCH v2 0/3] nvme/mpath: fix missed namespaces in ana state update
Date: Mon, 13 Sep 2021 17:32:07 +0200	[thread overview]
Message-ID: <20210913153207.GA4555@lst.de> (raw)
In-Reply-To: <20210913153023.70879-1-anton@lightbitslabs.com>

On Mon, Sep 13, 2021 at 09:30:20AM -0600, Anton Eidelman wrote:
> Fixed two issues in nvme_update_ana_state() that caused ana_work
> to miss existing namespaces and consequently a failure to update
> the namespace ANA state based on the ANA log page.
> 
> 1) A plain bug: we skipped an nsid in desc->nsids in a certain
>    combination of nsids present and nsids reports in the ANA log,
>    and failed to match this nsid to an existing namespace.
> 2) Unhandled situation when scan_work appended new namespaces to
>    ctrl->namespaces and did not sort the list yet.
>    In such transient state ana_work would fail to match nsids
>    to those new namespaces.
> 
> Both issues potentially caused some namespaces to get stuck
> in an incorrect ANA state, e.g. to never become live.

What are the changes to v1?  That should always go into the cover letter.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2021-09-13 15:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 18:54 [PATCH RESEND 0/3] nvme/mpath: fix missed namespaces in ana state update Anton Eidelman
2021-09-12 18:54 ` [PATCH 1/3] nvme/multipath: fix failure to update ns ana state Anton Eidelman
2021-09-12 18:54 ` [PATCH 2/3] nvme/multipath: cosmetic: keep ns nsid locally Anton Eidelman
2021-09-12 18:54 ` [PATCH 3/3] nvme/multipath: fix stale ana state for namespaces just added by scan work Anton Eidelman
2021-09-13 15:30   ` [PATCH v2 0/3] nvme/mpath: fix missed namespaces in ana state update Anton Eidelman
2021-09-13 15:30     ` [PATCH v2 1/3] nvme/multipath: fix failure to update ns ana state Anton Eidelman
2021-09-13 16:01       ` Christoph Hellwig
2021-09-13 19:29       ` Sagi Grimberg
2021-09-14  8:27       ` Christoph Hellwig
2021-09-13 15:30     ` [PATCH v2 2/3] nvme/multipath: cosmetic: keep ns nsid locally Anton Eidelman
2021-09-13 16:02       ` Christoph Hellwig
2021-09-13 20:19         ` Anton Eidelman
2021-09-13 20:57           ` Keith Busch
2021-09-14  5:44             ` Christoph Hellwig
2021-09-13 15:30     ` [PATCH v2 3/3] nvme/multipath: fix stale ana state for namespaces just added by scan work Anton Eidelman
2021-09-13 16:03       ` Christoph Hellwig
2021-09-13 16:08         ` Keith Busch
2021-09-14  6:24           ` Sagi Grimberg
2021-09-14  6:30             ` Christoph Hellwig
2021-09-14  6:40               ` Christoph Hellwig
2021-09-14  7:09               ` Sagi Grimberg
2021-09-14  7:32                 ` Christoph Hellwig
2021-09-14 16:45                   ` Anton Eidelman
2021-09-15  9:32                     ` Sagi Grimberg
2021-09-14 14:24               ` Keith Busch
2021-09-13 16:07       ` Keith Busch
2021-09-13 16:11         ` Christoph Hellwig
2021-09-13 16:24           ` Keith Busch
2021-09-13 16:46           ` Anton Eidelman
2021-09-13 15:32     ` Christoph Hellwig [this message]
2021-09-13 15:42     ` [PATCH v2 0/3] nvme/mpath: fix missed namespaces in ana state update FIXED Anton Eidelman
2021-09-13 21:46       ` [PATCH v3 0/3] nvme/mpath: fix missed namespaces in ana state update Anton Eidelman
2021-09-13 21:46         ` [PATCH v3 1/3] nvme/multipath: fix failure to update ns ana state Anton Eidelman
2021-09-13 21:46         ` [PATCH v3 2/3] nvme/multipath: cosmetic: keep ns nsid locally Anton Eidelman
2021-09-13 21:46         ` [PATCH v3 3/3] nvme/multipath: fix stale ana state for namespaces just added by scan work Anton Eidelman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913153207.GA4555@lst.de \
    --to=hch@lst.de \
    --cc=anton.eidelman@gmail.com \
    --cc=anton@lightbitslabs.com \
    --cc=axboe@fb.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.