From: Eugene Syromiatnikov <esyr@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dmitry V. Levin" <ldv@strace.io>,
linux-api@vger.kernel.org
Subject: Re: [PATCH v2] io-wq: expose IO_WQ_ACCT_* enumeration items to UAPI
Date: Mon, 13 Sep 2021 17:52:43 +0200 [thread overview]
Message-ID: <20210913155243.GA23359@asgard.redhat.com> (raw)
In-Reply-To: <872209f5-d11c-1b80-6146-5646206e22cb@kernel.dk>
On Mon, Sep 13, 2021 at 07:28:11AM -0600, Jens Axboe wrote:
> This is really the same thing as before, just the names have changed.
> What I suggested was keeping the enum in io_uring, then just adding
>
> enum {
> IO_WQ_BOUND,
> IO_WQ_UNBOUND,
> };
>
> to uapi header. The ACCT stuff is io-wq specific too, that kind of naming
> shouldn't be propagated to userspace.
My apologies, I've overlooked the fact that the proposed names
are different. Updated and resent[1].
[1] https://lore.kernel.org/lkml/20210913154415.GA12890@asgard.redhat.com/
> A BUILD_BUG_ON() could be added for them being different, but honestly
> I don't think that's worth it.
prev parent reply other threads:[~2021-09-13 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 10:41 [PATCH v2] io-wq: expose IO_WQ_ACCT_* enumeration items to UAPI Eugene Syromiatnikov
2021-09-13 13:28 ` Jens Axboe
2021-09-13 15:52 ` Eugene Syromiatnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913155243.GA23359@asgard.redhat.com \
--to=esyr@redhat.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=ldv@strace.io \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.