All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joshua de Block <deblockj0482@gmail.com>
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
	aldas60@gmail.com, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vt6656: Fix warning message generated by checkpatch.pl
Date: Thu, 16 Sep 2021 17:05:52 +0300	[thread overview]
Message-ID: <20210916140551.GK2088@kadam> (raw)
In-Reply-To: <YUJCI9w8sJLFihRD@joshua-VirtualBox>

On Wed, Sep 15, 2021 at 01:57:39PM -0500, Joshua de Block wrote:
> Description: Address the following checkpatch warning:
>    * WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> 
> Signed-off-by: Joshua de Block <deblockj0482@gmail.com>
> ---
>  drivers/staging/vt6656/rxtx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index a31947f2620d..b129397ef41f 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -58,7 +58,6 @@ static struct vnt_usb_send_context
>  	struct vnt_usb_send_context *context = NULL;
>  	int ii;
>  
> -	dev_dbg(&priv->usb->dev, "%s\n", __func__);
>  

Delete the next blank line as well.  Otherwise it introduces a new
checkpatch warning.

>  	for (ii = 0; ii < priv->num_tx_context; ii++) {
>  		if (!priv->tx_context[ii])

regards,
dan carpenter


  reply	other threads:[~2021-09-16 14:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 18:57 [PATCH] staging: vt6656: Fix warning message generated by checkpatch.pl Joshua de Block
2021-09-16 14:05 ` Dan Carpenter [this message]
2021-09-20 14:31   ` [PATCH v2] " Joshua de Block
2021-09-20 14:50     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210916140551.GK2088@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=aldas60@gmail.com \
    --cc=deblockj0482@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.