From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AFA7C433F5 for ; Fri, 17 Sep 2021 02:35:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A03161216 for ; Fri, 17 Sep 2021 02:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243517AbhIQCg6 (ORCPT ); Thu, 16 Sep 2021 22:36:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:33862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243242AbhIQCgP (ORCPT ); Thu, 16 Sep 2021 22:36:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3759061248; Fri, 17 Sep 2021 02:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631846094; bh=/hb9GIZb9Fv8i8fpV9Vo6wFplZV9WG8Ic/1WvmTvOxA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rdk7Lqro1G0z/Bblx0B15S66YIC533xSQX0b0RFzly7mKGN6u9Ecxxwq9biNGzRHM 6sjecbpJ8Pit/rv1U3Gf5xSpfVCBbRtRRiGQCfWjMkJt9lZgE6Q/Rkpor8NmaISmq8 px8dK+7X6220H9Wym4KweFPZ/x3uR+Xcg6ktvGTHQvN16Bd//O5tah8m32X2YGeWHi uEA/oY9Ns5YKPBamRBf9FL1FwWvXsBHa5uvirk9Nf8aLaFveP5ThRHSbi3rOE+GXAh dWGRDnu//LsRaFTtjwrWMQxKVuIFf3HcaH1DhdWp2haJgspGar4i7HnXhiuK4XZdER ZatBmZt1SSnpA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Thierry Reding , Sasha Levin , fabrice.gasnier@foss.st.com, lee.jones@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 3/5] pwm: stm32-lp: Don't modify HW state in .remove() callback Date: Thu, 16 Sep 2021 22:34:47 -0400 Message-Id: <20210917023449.816713-3-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210917023449.816713-1-sashal@kernel.org> References: <20210917023449.816713-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org From: Uwe Kleine-König [ Upstream commit d44084c93427bb0a9261432db1a8ca76a42d805e ] A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/pwm/pwm-stm32-lp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c index 67fca62524dc..05bb1f95a773 100644 --- a/drivers/pwm/pwm-stm32-lp.c +++ b/drivers/pwm/pwm-stm32-lp.c @@ -225,8 +225,6 @@ static int stm32_pwm_lp_remove(struct platform_device *pdev) { struct stm32_pwm_lp *priv = platform_get_drvdata(pdev); - pwm_disable(&priv->chip.pwms[0]); - return pwmchip_remove(&priv->chip); } -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AAEC433F5 for ; Fri, 17 Sep 2021 02:37:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF9676113E for ; Fri, 17 Sep 2021 02:37:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EF9676113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3S0rxJ8+mefO3F/+mMGIJP8jyzzI2/gM8QuMJNhgQZ8=; b=AHIcdg64xrXbkf ULjzz6WESasAcDdO8Td4EuhLAeaSCUR7p1c3Fnip65iasQNeoE3zCIPG+n7uz9zrYD6gnTQlIRk8o tt43T+rnk9FiH4RL2TL8OJCqt5F+7G3NStcxbIgRHdsnXBFcEm/O+0g+Q/uD8/gWzFFJZk/xSkGCX FkHK/Ru5F44C74eHIHyVwSefLIeAszuBHtatBvVAEzhKS04hvwplvUxoGPa+R+heLTkirCR7TCFg/ X1HtPFFwY3AGYejLm182nMQosdXAnSBAvmOjtlrvhO+XlxOA335EmjN/bjy4ijQHH4TazMzENPsCo o33nA7AvJ58T/IxmX1Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mR3j9-00Cxy4-7k; Fri, 17 Sep 2021 02:35:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mR3iI-00CxUS-LR for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 02:34:56 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3759061248; Fri, 17 Sep 2021 02:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631846094; bh=/hb9GIZb9Fv8i8fpV9Vo6wFplZV9WG8Ic/1WvmTvOxA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rdk7Lqro1G0z/Bblx0B15S66YIC533xSQX0b0RFzly7mKGN6u9Ecxxwq9biNGzRHM 6sjecbpJ8Pit/rv1U3Gf5xSpfVCBbRtRRiGQCfWjMkJt9lZgE6Q/Rkpor8NmaISmq8 px8dK+7X6220H9Wym4KweFPZ/x3uR+Xcg6ktvGTHQvN16Bd//O5tah8m32X2YGeWHi uEA/oY9Ns5YKPBamRBf9FL1FwWvXsBHa5uvirk9Nf8aLaFveP5ThRHSbi3rOE+GXAh dWGRDnu//LsRaFTtjwrWMQxKVuIFf3HcaH1DhdWp2haJgspGar4i7HnXhiuK4XZdER ZatBmZt1SSnpA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Thierry Reding , Sasha Levin , fabrice.gasnier@foss.st.com, lee.jones@linaro.org, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 3/5] pwm: stm32-lp: Don't modify HW state in .remove() callback Date: Thu, 16 Sep 2021 22:34:47 -0400 Message-Id: <20210917023449.816713-3-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210917023449.816713-1-sashal@kernel.org> References: <20210917023449.816713-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_193454_812156_0374F27E X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4K ClsgVXBzdHJlYW0gY29tbWl0IGQ0NDA4NGM5MzQyN2JiMGE5MjYxNDMyZGIxYThjYTc2YTQyZDgw NWUgXQoKQSBjb25zdW1lciBpcyBleHBlY3RlZCB0byBkaXNhYmxlIGEgUFdNIGJlZm9yZSBjYWxs aW5nIHB3bV9wdXQoKS4gQW5kIGlmCnRoZXkgZGlkbid0IHRoZXJlIGlzIGhvcGVmdWxseSBhIGdv b2QgcmVhc29uIChvciB0aGUgY29uc3VtZXIgbmVlZHMKZml4aW5nKS4gQWxzbyBpZiBkaXNhYmxp bmcgYW4gZW5hYmxlZCBQV00gd2FzIHRoZSByaWdodCB0aGluZyB0byBkbywKdGhpcyBzaG91bGQg YmV0dGVyIGJlIGRvbmUgaW4gdGhlIGZyYW1ld29yayBpbnN0ZWFkIG9mIGluIGVhY2ggbG93IGxl dmVsCmRyaXZlci4KClNpZ25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1r b2VuaWdAcGVuZ3V0cm9uaXguZGU+ClNpZ25lZC1vZmYtYnk6IFRoaWVycnkgUmVkaW5nIDx0aGll cnJ5LnJlZGluZ0BnbWFpbC5jb20+ClNpZ25lZC1vZmYtYnk6IFNhc2hhIExldmluIDxzYXNoYWxA a2VybmVsLm9yZz4KLS0tCiBkcml2ZXJzL3B3bS9wd20tc3RtMzItbHAuYyB8IDIgLS0KIDEgZmls ZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcHdtL3B3bS1z dG0zMi1scC5jIGIvZHJpdmVycy9wd20vcHdtLXN0bTMyLWxwLmMKaW5kZXggNjdmY2E2MjUyNGRj Li4wNWJiMWY5NWE3NzMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcHdtL3B3bS1zdG0zMi1scC5jCisr KyBiL2RyaXZlcnMvcHdtL3B3bS1zdG0zMi1scC5jCkBAIC0yMjUsOCArMjI1LDYgQEAgc3RhdGlj IGludCBzdG0zMl9wd21fbHBfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiB7 CiAJc3RydWN0IHN0bTMyX3B3bV9scCAqcHJpdiA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBkZXYp OwogCi0JcHdtX2Rpc2FibGUoJnByaXYtPmNoaXAucHdtc1swXSk7Ci0KIAlyZXR1cm4gcHdtY2hp cF9yZW1vdmUoJnByaXYtPmNoaXApOwogfQogCi0tIAoyLjMwLjIKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==