Re: [PATCH 1/1] fs: avoid superfluous messages

[AKASHI Takahiro <takahiro.akashi@linaro.org>]

On Thu, Sep 16, 2021 at 10:10:20AM +0200, Heinrich Schuchardt wrote:
> Output like the following is quite irritating:
> 
>     => bootefi hello
>     Scanning disk mmc2.blk...
>     No valid Btrfs found
>     Bad magic number for SquashFS image.
>     ** Unrecognized filesystem type **
>     Scanning disk mmc1.blk...
>     No valid Btrfs found
>     Bad magic number for SquashFS image.
>     ** Unrecognized filesystem type **
>     Scanning disk mmc0.blk...
>     No valid Btrfs found
>     Bad magic number for SquashFS image.
>     ** Unrecognized filesystem type **
> 
> It is expected that a whole disk (partition number 0) doesn't contain a
> filesystem.

A whole disk *can* contain a filesystem in general.
Please correct the commit message.

-Takahiro Akashi

> Partitions may only contain a blob. This situation is only
> worth a debug message.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  fs/fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fs.c b/fs/fs.c
> index 7c682582c8..023f89cafe 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -37,7 +37,7 @@ static int fs_type = FS_TYPE_ANY;
>  static inline int fs_probe_unsupported(struct blk_desc *fs_dev_desc,
>  				      struct disk_partition *fs_partition)
>  {
> -	log_err("** Unrecognized filesystem type **\n");
> +	log_debug("Unrecognized filesystem type\n");
>  	return -1;
>  }
>  
> -- 
> 2.32.0
>