From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] extcon: extcon-axp288: use P-Unit semaphore lock for register accesses
Date: Fri, 17 Sep 2021 10:04:27 +0200 [thread overview]
Message-ID: <20210917080426.GA1410@agape.jhs> (raw)
In-Reply-To: <a755b46a-5561-0fae-b7b3-d0bc1906f79e@redhat.com>
Hello Hans,
On Thu, Sep 16, 2021 at 01:12:53PM +0200, Hans de Goede wrote:
> Hi,
<snip>
> >
> > Suggested-by: Hans de Goede <hdegoede@redhat.com>
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> > Tested-by: Hans de Goede <hdegoede@redhat.com>
> > Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
> > ---
> > Changes in v2:
> > - shortened patch title within 75 char
> > - added return value check in function
> > iosf_mbi_lock_punit_i2c_access() calls
>
>
> Actually your last version was v2, so this one should have
> been v3 (no need to resend it just for that).
oh sorry for mistake
>
> Other then that remark this looks good, thank you.
thank you for review
>
> Regards,
>
> Hans
@Chanwoo, do you need for me to resend a v3 or
you can take the patch as-is?
thank you,
fabio
next prev parent reply other threads:[~2021-09-17 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 7:12 [PATCH v2] extcon: extcon-axp288: use P-Unit semaphore lock for register accesses Fabio Aiuto
2021-09-16 11:12 ` Hans de Goede
2021-09-17 8:04 ` Fabio Aiuto [this message]
2021-09-19 9:33 ` Chanwoo Choi
2021-09-20 7:03 ` Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917080426.GA1410@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.