From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org
Cc: Glenn Washburn <development@efficientek.com>,
Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCH 06/10] tests: Change FAT volume label to be with in the valid character range
Date: Fri, 17 Sep 2021 23:04:00 +0000 [thread overview]
Message-ID: <20210917230404.1587915-7-development@efficientek.com> (raw)
In-Reply-To: <20210917230404.1587915-1-development@efficientek.com>
The ';', semi-colon, character is not a valid character for a FAT filesystem
label. This test used to succeed because prior to v4.2 of dosfstools
mkfs.vfat did not enforce the character restrictions for volume labels. So
change the volume label string to be valid but contain symbol characters to
test odd volume labels.
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
tests/util/grub-fs-tester.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
index 96b204590..537cdd48b 100644
--- a/tests/util/grub-fs-tester.in
+++ b/tests/util/grub-fs-tester.in
@@ -343,9 +343,10 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 1); do
# FS LIMITATION: XFS label is at most 12 UTF-8 characters
x"xfs"|x"xfs_crc")
FSLABEL="géт 😁к";;
- # FS LIMITATION: FAT labels limited to 11 characters, no international characters or lowercase
+ # FS LIMITATION: FAT labels limited to 11 characters, no international characters or lowercase
+ # and excluding the restricted characters in "*?.,;:/\|+=<>[]"
x"vfat"* | xmsdos*)
- FSLABEL="GRUBTEST ;_";;
+ FSLABEL="G~!@#\$%^&(_";;
# FS LIMITATION: AFFS is latin1. At most 29 characters
x"affs" | xaffs_intl)
FSLABEL="grub_tt? #*w;/e£@¡¤½¾{[]}<>.,";;
--
2.32.0
next prev parent reply other threads:[~2021-09-17 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 23:03 [PATCH 00/10] More test fixes/improvements Glenn Washburn
2021-09-17 23:03 ` [PATCH 01/10] tests: Rename variable filtime -> filetime as its meant to be Glenn Washburn
2021-09-17 23:03 ` [PATCH 02/10] tests: mkreiserfs only supports 4096 block size Glenn Washburn
2021-09-17 23:03 ` [PATCH 03/10] tests: Disable reiserfs tests for old format because newer kernels do not support them Glenn Washburn
2021-09-17 23:03 ` [PATCH 04/10] tests: mkfs.btrfs now supports only 4k sector sizes and above Glenn Washburn
2021-09-17 23:03 ` [PATCH 05/10] tests: Only test minix3 volumes of 1k block size Glenn Washburn
2021-09-17 23:04 ` Glenn Washburn [this message]
2021-09-17 23:04 ` [PATCH 07/10] tests: Skip hfs test only when mac_roman module is not loaded and not loadable Glenn Washburn
2021-09-17 23:04 ` [PATCH 08/10] grub-shell: Boot PowerPC using PMU instead of CUDA for power management Glenn Washburn
2021-09-21 16:21 ` Paul Menzel
2021-10-05 4:27 ` Glenn Washburn
2021-09-17 23:04 ` [PATCH 09/10] tests: Output list of devices when partmap fails Glenn Washburn
2021-09-17 23:04 ` [PATCH 10/10] tests: Do not delete filesystem images on error Glenn Washburn
2021-10-07 13:10 ` [PATCH 00/10] More test fixes/improvements Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917230404.1587915-7-development@efficientek.com \
--to=development@efficientek.com \
--cc=daniel.kiper@oracle.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.