From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - clang: add explicit test for VG
Date: Mon, 20 Sep 2021 13:29:46 +0000 (GMT) [thread overview]
Message-ID: <20210920132946.2F64C3858C60@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=0d9f3dbd954b04e08a27154376b60fe9aca23b0c
Commit: 0d9f3dbd954b04e08a27154376b60fe9aca23b0c
Parent: 48163e32f100a9567cb28ab89f70488d0a0abc7f
Author: Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate: Sat Sep 18 23:16:30 2021 +0200
Committer: Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Mon Sep 20 10:51:30 2021 +0200
clang: add explicit test for VG
Clang can't figure out connection to 'skip' variable.
---
tools/toollib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/toollib.c b/tools/toollib.c
index 562cad06a..fa3b2ffe3 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -4349,7 +4349,7 @@ static int _process_pvs_in_vgs(struct cmd_context *cmd, uint32_t read_flags,
if (ret > ret_max)
ret_max = ret;
- if (!skip)
+ if (!skip && vg)
unlock_vg(cmd, vg, vg->name);
endvg:
if (error_vg)
reply other threads:[~2021-09-20 13:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920132946.2F64C3858C60@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.