All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - gcc-fanalyzer: notices 'du' could be NULL
Date: Mon, 20 Sep 2021 13:29:48 +0000 (GMT)	[thread overview]
Message-ID: <20210920132948.6D55D3858C60@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e15d1e53c181b804b12f059788ed111d42353be9
Commit:        e15d1e53c181b804b12f059788ed111d42353be9
Parent:        834f17bb3388ffe7f51aeede15d957a63bcda715
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Fri Sep 17 23:51:12 2021 +0200
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Mon Sep 20 10:51:30 2021 +0200

gcc-fanalyzer: notices 'du' could be NULL

Ensure only nonNULL 'du' pointer is dereference altough the comment
to the last assign 'du' pointer already suggest 'NULL' case should not happen.
So just being explicit.

mer du
---
 lib/device/device_id.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/device/device_id.c b/lib/device/device_id.c
index 649c4bba9..742ce62bd 100644
--- a/lib/device/device_id.c
+++ b/lib/device/device_id.c
@@ -2144,7 +2144,8 @@ void device_ids_find_renamed_devs(struct cmd_context *cmd, struct dm_list *dev_l
 			/* I don't think this would happen */
 			log_warn("WARNING: new device %s for PVID %s does not pass filter %s.",
 				 dev_name(dev), dil->pvid, dev_filtered_reason(dev));
-			du->dev = NULL;
+			if (du) /* Should not happen 'du' is NULL */
+				du->dev = NULL;
 			dev->flags &= ~DEV_MATCHED_USE_ID;
 		}
 	}



                 reply	other threads:[~2021-09-20 13:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210920132948.6D55D3858C60@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.