From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - cov: pvck validates setup_device return value
Date: Mon, 20 Sep 2021 13:29:59 +0000 (GMT) [thread overview]
Message-ID: <20210920132959.ADA593858C60@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=6427803252354203dfa5d816c6a8dc0ae385051e
Commit: 6427803252354203dfa5d816c6a8dc0ae385051e
Parent: b6e9892bc6ae23406847a20236c7c954792468e5
Author: Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate: Mon Sep 20 10:33:33 2021 +0200
Committer: Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Mon Sep 20 14:18:13 2021 +0200
cov: pvck validates setup_device return value
---
tools/pvck.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/pvck.c b/tools/pvck.c
index 49bcb5fd3..629e1feee 100644
--- a/tools/pvck.c
+++ b/tools/pvck.c
@@ -3178,9 +3178,10 @@ int pvck(struct cmd_context *cmd, int argc, char **argv)
* but this is here to preserve the historical output.
*/
- if (argc == 1)
- setup_device(cmd, argv[0]);
- else if (!setup_devices(cmd))
+ if (argc == 1) {
+ if (!setup_device(cmd, argv[0]))
+ return_ECMD_FAILED;
+ } else if (!setup_devices(cmd))
return_ECMD_FAILED;
for (i = 0; i < argc; i++) {
reply other threads:[~2021-09-20 13:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920132959.ADA593858C60@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.