From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - cov: check fid instance is created
Date: Mon, 20 Sep 2021 13:30:01 +0000 (GMT) [thread overview]
Message-ID: <20210920133001.ECC7C3858C60@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=f410035181d8c524ffc5d0f3edf512e8506b47d9
Commit: f410035181d8c524ffc5d0f3edf512e8506b47d9
Parent: e1840dd9e0b3be55281466e60a9a07cce068db4f
Author: Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate: Mon Sep 20 02:09:16 2021 +0200
Committer: Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Mon Sep 20 14:26:09 2021 +0200
cov: check fid instance is created
---
tools/pvscan.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/pvscan.c b/tools/pvscan.c
index d24ee5724..ec33c9a9a 100644
--- a/tools/pvscan.c
+++ b/tools/pvscan.c
@@ -1234,7 +1234,12 @@ static int _online_devs(struct cmd_context *cmd, int do_all, struct dm_list *pvs
}
fmt = lvmcache_fmt(info);
- fid = fmt->ops->create_instance(fmt, &fic);
+ if (!(fid = fmt->ops->create_instance(fmt, &fic))) {
+ log_error("pvscan[%d] failed to create format instance.", getpid());
+ ret = 0;
+ continue;
+ }
+
vg = NULL;
mda1 = lvmcache_get_dev_mda(dev, 1);
reply other threads:[~2021-09-20 13:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920133001.ECC7C3858C60@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.