All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - cov: validate syscall result
Date: Mon, 20 Sep 2021 13:30:15 +0000 (GMT)	[thread overview]
Message-ID: <20210920133015.7F8513858C60@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=055406bb398ddf60f18c545baffcec4ee4d5646e
Commit:        055406bb398ddf60f18c545baffcec4ee4d5646e
Parent:        9721f3e0ff6fd841b62b6bcccceee2ebb914e96b
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Mon Sep 20 10:31:45 2021 +0200
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Mon Sep 20 14:26:09 2021 +0200

cov: validate syscall result

---
 test/lib/brick-shelltest.h | 3 ++-
 test/lib/not.c             | 6 +++++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/test/lib/brick-shelltest.h b/test/lib/brick-shelltest.h
index 0b1f9dfee..6bc02e0d2 100644
--- a/test/lib/brick-shelltest.h
+++ b/test/lib/brick-shelltest.h
@@ -424,7 +424,8 @@ struct FdSink : Sink {
     {
         TimedBuffer::Line line = stream.shift( force );
         std::string out = fmt.format( line );
-        write( fd, out.c_str(), out.length() );
+        if ( write( fd, out.c_str(), out.length() ) < (int)out.length() )
+            perror( "short write" );
     }
 
     virtual void sync( bool force ) {
diff --git a/test/lib/not.c b/test/lib/not.c
index a5c52a8e6..0cff13062 100644
--- a/test/lib/not.c
+++ b/test/lib/not.c
@@ -86,7 +86,11 @@ int main(int args, char **argv) {
 		/* should not be accessible */
 		return FAILURE;
 	} else {		/* parent */
-		waitpid(pid, &status, 0);
+		if (waitpid(pid, &status, 0) < 0) {
+			fprintf(stderr, "Process %d failed on waitpid.\n", pid);
+			return FAILURE;
+		}
+
 		if (!WIFEXITED(status)) {
 			if (WIFSIGNALED(status))
 				fprintf(stderr,



                 reply	other threads:[~2021-09-20 13:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210920133015.7F8513858C60@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.