From: Christoph Hellwig <hch@lst.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Christoph Hellwig <hch@lst.de>,
"David S. Miller" <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 1/2] sparc32: remove dma_make_coherent
Date: Tue, 21 Sep 2021 09:41:51 +0200 [thread overview]
Message-ID: <20210921074151.GA26525@lst.de> (raw)
In-Reply-To: <YUixtMGPMLWvv8S9@ravnborg.org>
On Mon, Sep 20, 2021 at 06:07:16PM +0200, Sam Ravnborg wrote:
> On Mon, Sep 20, 2021 at 01:31:07PM +0200, Christoph Hellwig wrote:
> > LEON only needs snooping when DMA accesses are not seen on the processor
> > bus. Given that coherent allocations are mapped uncached this can't
> > happen for those, so open code the d-cache flushing logic in the only
> > remaing place that needs it, arch_sync_dma_for_cpu.
> I do not see this change explicitly explained in the changelog.
> Is this not one of the "only remaining place that needs it"?
Yes. Two callers, one needs it, one doesn't.
> Would be nice to see it explicitly mentioned.
Ok. I'll respin with a more detailed commit log.
next prev parent reply other threads:[~2021-09-21 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 11:31 use the generic DMA remap allocator for sparc32 Christoph Hellwig
2021-09-20 11:31 ` [PATCH 1/2] sparc32: remove dma_make_coherent Christoph Hellwig
[not found] ` <YUixtMGPMLWvv8S9@ravnborg.org>
2021-09-21 7:41 ` Christoph Hellwig [this message]
2021-09-21 11:32 ` Andreas Larsson
2021-10-21 11:09 ` Christoph Hellwig
2021-09-20 11:31 ` [PATCH 2/2] sparc32: use DMA_DIRECT_REMAP Christoph Hellwig
2021-09-20 11:34 ` use the generic DMA remap allocator for sparc32 David Miller
2021-09-21 7:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210921074151.GA26525@lst.de \
--to=hch@lst.de \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.