From: Mel Gorman <mgorman@suse.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Gon Solo <gonsolo@gmail.com>,
linux-mm@kvack.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: Move fold_vm_numa_events() to fix NUMA without SMP
Date: Tue, 21 Sep 2021 13:33:19 +0100 [thread overview]
Message-ID: <20210921123319.GF3891@suse.de> (raw)
In-Reply-To: <9d16ccdd9ef32803d7100c84f737de6a749314fb.1631781495.git.geert+renesas@glider.be>
On Thu, Sep 16, 2021 at 10:42:43AM +0200, Geert Uytterhoeven wrote:
> If CONFIG_NUMA=y, but CONFIG_SMP=n (e.g. sh/migor_defconfig):
>
> sh4-linux-gnu-ld: mm/vmstat.o: in function `vmstat_start':
> vmstat.c:(.text+0x97c): undefined reference to `fold_vm_numa_events'
> sh4-linux-gnu-ld: drivers/base/node.o: in function `node_read_vmstat':
> node.c:(.text+0x140): undefined reference to `fold_vm_numa_events'
> sh4-linux-gnu-ld: drivers/base/node.o: in function `node_read_numastat':
> node.c:(.text+0x1d0): undefined reference to `fold_vm_numa_events'
>
> Fix this by moving fold_vm_numa_events() outside the SMP-only section.
>
> Fixes: f19298b9516c1a03 ("mm/vmstat: convert NUMA statistics to basic NUMA counters")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2021-09-21 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 8:42 [PATCH 0/2] Fix NUMA without SMP Geert Uytterhoeven
2021-09-16 8:42 ` [PATCH 1/2] mm: Move node_reclaim_distance to fix " Geert Uytterhoeven
2021-09-21 12:32 ` Mel Gorman
2021-09-16 8:42 ` [PATCH 2/2] mm: Move fold_vm_numa_events() " Geert Uytterhoeven
2021-09-21 12:33 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210921123319.GF3891@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=gonsolo@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vbabka@suse.cz \
--cc=vincent.guittot@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.