From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79840C433F5 for ; Thu, 23 Sep 2021 08:59:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3627961278 for ; Thu, 23 Sep 2021 08:59:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3627961278 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2ePgXy0HVHOHCmQ9rDs2dK2DBRvYX8WKNLD45tJeLjU=; b=5DAMJqG3B9n/8A t2wdbdPFcw3v6Uo+RcEotBxy3xk8+uoEbL2StK05NcudP9UEZlEhSTjd51lkBlIekB+5JXjwZi0dy xEPA5ygE87uwh+FCzLtkxHvqI2Ti6fuY3cL6O8ggwzsveEsPHGoDP18yhKMQ8WxsWlfoLz/vNfwv1 m7UXjRH29CtuJuO3h6QrhJvUXuAqS2vyVP1dpq7riLVnEWLnSrVnszBVmdVHOZik2xVlql1gey9Mv EX7V0I/N3R08hgGgy+AdyGkmrY8UtNxE1lkkkZAYU+WVuNL4Ka5hyLxU0ez9wfaiQH5EPgO3+YZlU CV1zRCUG+kqgHjUGWFRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTKZs-00AhaR-3R; Thu, 23 Sep 2021 08:59:36 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTKZp-00AhZi-Ky for ath11k@lists.infradead.org; Thu, 23 Sep 2021 08:59:35 +0000 Received: by mail-pf1-x434.google.com with SMTP id k17so5117240pff.8 for ; Thu, 23 Sep 2021 01:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=IwZWh7TVy1EsJ4/Xl5ph0XhiwHhsFLWIFyxY44IHD6c=; b=EtCi7o76f+Y3DWLNDkwwIIvlAA4cVI0p3JtUo3aGd6gHqYvwHf5nl75xwRDeWi9NyX 04vxuYbauytQ0qUNsZBilOckJOidDrCsNThS00KJPtvOjD63yUtWG+JBvtIp7OIPpQM6 ZD/LS9uAIA1YOmyHt0b2n9l5BnOXO9wtgQpGzk3G0IAnm+IjPClViLRS0nH3h0BAb97p Gp+3xBRf2C66aNcS/Uy2Yz2bryZLoDolIg1QCpXz0tlDZEMdBLcJ8pANb0qejWWBxYCP VFIo1hlxn3CV59KkHhVS8tvGcnCMsfdmQG8h9SwRiE0sMNb3mcVfXJWUM6+MpfQigzIU h5rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=IwZWh7TVy1EsJ4/Xl5ph0XhiwHhsFLWIFyxY44IHD6c=; b=c8O7q03oyc/AnyGu7yh8h3xfw26IJf/i5Oc9emZ5nGrogVqcc9N8DwBnDQcEzIgvFa YMepv01bXnhxI217RmjStEjil+zls0xUkz7BOp62tQPOd9sSU+Xmmf4yvkakMJDaooPh THl2O1OOGlx1qj7NgMvGaPTwXINzT0wMuQB37pMY/VhlSjtcqksjMdWhvoIDm60awMr/ lTw70U4JS1Lg6fhnCRG7G4GsNOrQEY9Uy4QEFQid7Zkh6uGaFl6F2OKIHEWjqsk5mRmT 0SONV1SR99IO/Dkx9D018ZYDnkP91pMUw4nuUJBSt/2G0skDCuROHKKgN2NbKmjL7nhc KGIg== X-Gm-Message-State: AOAM530TftCqeQz4kAkVDmLjeK0xd1qHCXFyJtKUEAjmLWjkVNIDdHVO WQ6yrKFtYdPXNCLcpneD/8fItilRuhxg X-Google-Smtp-Source: ABdhPJwwaXILnaoOCOksr0wpBKXGHCF7fnZfoGHzfcogdAEo2/ZL/8T1fOEFbOYoPvUfpQ98obaaKw== X-Received: by 2002:a63:770b:: with SMTP id s11mr3133224pgc.275.1632387572197; Thu, 23 Sep 2021 01:59:32 -0700 (PDT) Received: from thinkpad ([117.193.215.78]) by smtp.gmail.com with ESMTPSA id s2sm8830002pjs.56.2021.09.23.01.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 01:59:31 -0700 (PDT) Date: Thu, 23 Sep 2021 14:29:26 +0530 From: Manivannan Sadhasivam To: Carl Huang Cc: Kalle Valo , Loic Poulain , ath11k@lists.infradead.org, linux-arm-msm , linux-wireless@vger.kernel.org, regressions@lists.linux.dev Subject: Re: [regression] mhi: ath11k resume fails on some devices Message-ID: <20210923085926.GD6083@thinkpad> References: <871r5p0x2u.fsf@codeaurora.org> <20210916111218.GA12918@thinkpad> <20210916163529.GA9027@thinkpad> <87k0jgxyjp.fsf@codeaurora.org> <20210916171927.GB9027@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210923_015933_752665_82DE7DCB X-CRM114-Status: GOOD ( 32.04 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org T24gVGh1LCBTZXAgMjMsIDIwMjEgYXQgMDQ6MzQ6NDNQTSArMDgwMCwgQ2FybCBIdWFuZyB3cm90 ZToKPiBPbiAyMDIxLTA5LTE3IDAxOjE5LCBNYW5pdmFubmFuIFNhZGhhc2l2YW0gd3JvdGU6Cj4g PiBPbiBUaHUsIFNlcCAxNiwgMjAyMSBhdCAwNzo0MjowMlBNICswMzAwLCBLYWxsZSBWYWxvIHdy b3RlOgo+ID4gPiBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbml2YW5uYW4uc2FkaGFzaXZhbUBs aW5hcm8ub3JnPiB3cml0ZXM6Cj4gPiA+IAo+ID4gPiA+IE9uIFRodSwgU2VwIDE2LCAyMDIxIGF0 IDAxOjE4OjIyUE0gKzAyMDAsIExvaWMgUG91bGFpbiB3cm90ZToKPiA+ID4gPj4gTGUgamV1LiAx NiBzZXB0LiAyMDIxIMOgIDEzOjEyLCBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPAo+ID4gPiA+PiBt YW5pdmFubmFuLnNhZGhhc2l2YW1AbGluYXJvLm9yZz4gYSDDqWNyaXQgOgo+ID4gPiA+Pgo+ID4g PiA+Cj4gPiA+ID4gWy4uLl0KPiA+ID4gPgo+ID4gPiA+PiA+IElmIHRoaW5ncyBzZWVtcyB0byB3 b3JrIGZpbmUgd2l0aG91dCB0aGF0IHBhdGNoLCB0aGVuIGl0IGltcGxpZXMgdGhhdAo+ID4gPiA+ PiA+IHNldHRpbmcgTTAKPiA+ID4gPj4gPiBzdGF0ZSB3b3JrcyBkdXJpbmcgcmVzdW1lLiBJIHRo aW5rIHdlIHNob3VsZCBqdXN0IHJldmVydCB0aGF0IHBhdGNoLgo+ID4gPiA+PiA+Cj4gPiA+ID4+ ID4gTG9pYywgZGlkIHRoYXQgcGF0Y2ggZml4IGFueSBpc3N1ZSBmb3IgeW91IG9yIGl0IHdhcyBh IGNvc21ldGljIGZpeCBvbmx5Pwo+ID4gPiA+Pgo+ID4gPiA+Pgo+ID4gPiA+PiBJdCBmaXhlcyBz ZHggbW9kZW0gcmVzdW1pbmcgaXNzdWUsIHdpdGhvdXQgdGhhdCB3ZSBkb27igJl0IGtub3cgbW9k ZW0gbmVlZHMKPiA+ID4gPj4gdG8gYmUgcmVpbml0aWFsaXplZC4KPiA+ID4gPj4KPiA+ID4gPgo+ ID4gPiA+IE9rYXkuIFRoZW4gaW4gdGhhdCBjYXNlLCB0aGUgcmVjb3ZlcnkgbWVjaGFuaXNtIGhh cyB0byBiZSBhZGRlZCB0byB0aGUgYXRoMTFrCj4gPiA+ID4gTUhJIGNvbnRyb2xsZXIuCj4gPiA+ IAo+ID4gPiBXaGF0IGRvZXMgdGhhdCBtZWFuIGluIHByYWN0aXNlLCBkbyB5b3UgaGF2ZSBhbnkg cG9pbnRlcnMgb3IKPiA+ID4gZXhhbXBsZXM/IEkKPiA+ID4gaGF2ZSBubyBjbHVlIHdoYXQgeW91 IGFyZSBwcm9wb3NpbmcgOikKPiA+ID4gCj4gPiAKPiA+IFRha2UgYSBsb29rIGF0IHRoZSBtaGlf cGNpX3JlY292ZXJ5X3dvcmsoKSBmdW5jdGlvbiBiZWxvdzoKPiA+IGh0dHBzOi8vZ2l0Lmtlcm5l bC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL2Ry aXZlcnMvYnVzL21oaS9wY2lfZ2VuZXJpYy5jI242MTAKPiA+IAo+ID4gWW91IG5lZWQgdG8gaW1w bGVtZW50IHNvbWV0aGluZyBzaW1pbGFyIHRoYXQgYmFzaWNhbGx5IHBvd2VycyB1cCB0aGUgTUhJ Cj4gPiBlbmRwb2ludCAoUUNBNjM5MCkgaW4gY2FzZSBwbV9yZXN1bWUoKSBmYWlscy4gQXQgbWlu aW11bSwgeW91IG5lZWQgdG8KPiA+IGNhbGwKPiA+IGJlbG93IGZ1bmN0aW9uczoKPiA+IAo+ID4g IyBDaGVjayBpZiB0aGUgZGV2aWNlIGlzIHBvd2VyZWQgb24uIElmIHllcywgdGhlbiBwb3dlciBp dCBkb3duIHRvIGJyaW5nCj4gPiBpdCBiYWNrCj4gPiBtaGlfcG93ZXJfZG93bigpCj4gPiBtaGlf dW5wcmVwYXJlX2FmdGVyX3Bvd2VyX2Rvd24oKQo+ID4gCj4gPiAjIFBvd2VyIHVwIHRoZSBkZXZp Y2UKPiA+IG1oaV9wcmVwYXJlX2Zvcl9wb3dlcl91cCgpCj4gPiBtaGlfc3luY19wb3dlcl91cCgp Cj4gPiAKPiA+IFRoaXMgaW1wbGllcyB0aGF0IHRoZSBXTEFOIGRldmljZSBoYXMgYmVlbiBwb3dl cmVkIG9mZiBkdXJpbmcgc3VzcGVuZCwKPiA+IHNvIHRoZQo+ID4gcmVzdW1lIGZhaWxzIGFuZCB3 ZSBhcmUgYnJpbmdpbmcgdGhlIGRldmljZSBiYWNrIHRvIHdvcmtpbmcgc3RhdGUuCj4gPiAKPiBU aGlzIGlzIGZpbmUgZm9yIHBsYXRmb3JtIHdoaWNoIGRvZXNuJ3QgcHJvdmlkZSBwb3dlciBzdXBw bHkgZHVyaW5nIHN1c3BlbmQuCj4gQnV0IE5VQyBoYXMgcG93ZXIgc3VwcGx5IGluIHN1c3BlbmQg c3RhdGUuCgpJZiBOVUMgcmV0YWlucyBwb3dlciBzdXBwbHkgZHVyaW5nIHN1c3BlbmQgdGhlbiBp dCBzaG91bGQgd29yayB3aXRoIHRoYXQgY29tbWl0LgpEdXJpbmcgcmVzdW1lLCB0aGUgZGV2aWNl IGlzIGV4cGVjdGVkIHRvIGJlIGluIE0zIHN0YXRlIGFuZCB0aGF0J3Mgd2hhdCB0aGUKY29tbWl0 IHZlcmlmaWVzLgoKSWYgdGhlIGRldmljZSBpcyBpbiBhIGRpZmZlcmVudCBzdGF0ZSwgdGhlbiBt b3N0IGxpa2VseSB0aGUgZGV2aWNlIGhhdmUgcG93ZXIKY3ljbGVkLgoKPiBRQ0E2MzkwIG9uIE5V QyB3b3JrcyBhZnRlciBqdXN0IHJldmVydGluZyB0aGlzIGNvbW1pdCBhbHNvIHByb3ZlcyBOVUMg aGFzCj4gcG93ZXIgc3VwcGx5IGluCj4gc3VzcGVuZCBzdGF0ZS4KPiAKClRoYXQncyBiZWNhdXNl IHdlIGFsbG93ZWQgdGhlIGRldmljZSB0byBiZSBpbiBhbnkgc3RhdGUgZHVyaW5nIHJlc3VtZSBh bmQgaWYgaXQKcmVzcG9uZHMgdG8gdGhlIE0wIHRyYW5zaXRpb24gaXQgd29ya2VkLgoKPiBUaGUg cmVhc29uIGlzIE1ISS1TVEFUVVMgcmVnaXN0ZXIgY2FuJ3QgYmUgcmVhZCBzb21laG93IGluIE0z IHN0YXRlIG9uIE5VQy4KCk5vLCB0aGF0J3Mgbm90IGNvcnJlY3QuCgo+IERvZXMgdGhlIE1ISSBz cGVjIHN0YXRlIHRoYXQgTUhJLVNUQVRVUyByZWdpc3RlciBjYW4gYmUgcmVhZCBpbiBNMyBzdGF0 ZT8KPiAKClllcywgYWxsIHRoZSBNSEkgcmVnaXN0ZXJzIGFyZSBhY2Nlc3NpYmxlIGluIGFsbCBz dGF0ZXMuIER1cmluZyBNMywgYm90aCBNSEkKaG9zdCBhbmQgZGV2aWNlIChpZiBzdXBwb3J0ZWQp IHdpbGwgdHJhbnNpdGlvbiB0byBEMyBDb2xkLiBUaGVuIGR1cmluZyByZXN1bWUsCmhvc3Qgd2ls bCBzd2l0Y2ggdG8gRDAgbGluayBzdGF0ZSBhbmQgd2lsbCBhbHNvIG5vdGlmeSB0aGUgZGV2aWNl IHRvIGVudGVyIEQwLgoKRm9yIGFpZCBkZWJ1Z2dpbmcsIHBsZWFzZSBzZWUgdGhlIHN0YXRlIHRo ZSBkZXZpY2UgaXMgaW4gZHVyaW5nIG1oaV9wbV9yZXN1bWUoKS4KWW91IGNhbiB1c2UgYmVsb3cg ZGlmZjoKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2J1cy9taGkvY29yZS9wbS5jIGIvZHJpdmVycy9i dXMvbWhpL2NvcmUvcG0uYwppbmRleCBmYjk5ZTM3MjcxNTUuLjQ4MmQ1NWRkMjA5ZSAxMDA2NDQK LS0tIGEvZHJpdmVycy9idXMvbWhpL2NvcmUvcG0uYworKysgYi9kcml2ZXJzL2J1cy9taGkvY29y ZS9wbS5jCkBAIC04OTgsNiArODk4LDkgQEAgaW50IG1oaV9wbV9yZXN1bWUoc3RydWN0IG1oaV9j b250cm9sbGVyICptaGlfY250cmwpCiAgICAgICAgaWYgKE1ISV9QTV9JTl9FUlJPUl9TVEFURSht aGlfY250cmwtPnBtX3N0YXRlKSkKICAgICAgICAgICAgICAgIHJldHVybiAtRUlPOwogCisgICAg ICAgZGV2X2luZm8oZGV2LCAiRGV2aWNlIHN0YXRlOiAlc1xuIiwKKyAgICAgICAgICAgICAgICBU T19NSElfU1RBVEVfU1RSKG1oaV9nZXRfbWhpX3N0YXRlKG1oaV9jbnRybCkpKTsKKwogICAgICAg IGlmIChtaGlfZ2V0X21oaV9zdGF0ZShtaGlfY250cmwpICE9IE1ISV9TVEFURV9NMykKICAgICAg ICAgICAgICAgIHJldHVybiAtRUlOVkFMOwoKClRoYW5rcywKTWFuaQoKLS0gCmF0aDExayBtYWls aW5nIGxpc3QKYXRoMTFrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26C45C433F5 for ; Thu, 23 Sep 2021 08:59:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02BDD61279 for ; Thu, 23 Sep 2021 08:59:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240042AbhIWJBE (ORCPT ); Thu, 23 Sep 2021 05:01:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240020AbhIWJBD (ORCPT ); Thu, 23 Sep 2021 05:01:03 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0F87C061756 for ; Thu, 23 Sep 2021 01:59:32 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id 203so5073535pfy.13 for ; Thu, 23 Sep 2021 01:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=IwZWh7TVy1EsJ4/Xl5ph0XhiwHhsFLWIFyxY44IHD6c=; b=EtCi7o76f+Y3DWLNDkwwIIvlAA4cVI0p3JtUo3aGd6gHqYvwHf5nl75xwRDeWi9NyX 04vxuYbauytQ0qUNsZBilOckJOidDrCsNThS00KJPtvOjD63yUtWG+JBvtIp7OIPpQM6 ZD/LS9uAIA1YOmyHt0b2n9l5BnOXO9wtgQpGzk3G0IAnm+IjPClViLRS0nH3h0BAb97p Gp+3xBRf2C66aNcS/Uy2Yz2bryZLoDolIg1QCpXz0tlDZEMdBLcJ8pANb0qejWWBxYCP VFIo1hlxn3CV59KkHhVS8tvGcnCMsfdmQG8h9SwRiE0sMNb3mcVfXJWUM6+MpfQigzIU h5rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=IwZWh7TVy1EsJ4/Xl5ph0XhiwHhsFLWIFyxY44IHD6c=; b=QGjytHlfaugLRfvzmLLZWXrwzkv8Srxx6sAdce449vdH4OIusPNfpj+DoM1h5i6qjs iTv3OkHdr54/p4eEfbpXtiUx6FEdL3PVFcZvoABzWu0r3Yg4V6s+AbLu53qb+MWdA2F7 fUWVIlV8CVo7LR3zZt+WhxIfoXLsMIQRyAdj+9/YgZcOvbBrp4M5SZLDB5lacZUpALZR kC3mL5tr8okRhrF8Ybh55WHjDDFj4Ftb3iBwMzdwZGDZZzxiKtSpuphTVA/qpDoa2Val TDc9J2mjRiZhqjT9oXTs6COn24T/OJoT7awGnLkv9UeqOHNY/s8BaMNY+YNv2eZuMfha bG2w== X-Gm-Message-State: AOAM532Jq4RpeCDzfGVQWXnR2eJCTAwCroVKT7lFdp9bxZ3GtMJ4rE0o 2hbIklUwo3IzPq9FoXxsGpmx X-Google-Smtp-Source: ABdhPJwwaXILnaoOCOksr0wpBKXGHCF7fnZfoGHzfcogdAEo2/ZL/8T1fOEFbOYoPvUfpQ98obaaKw== X-Received: by 2002:a63:770b:: with SMTP id s11mr3133224pgc.275.1632387572197; Thu, 23 Sep 2021 01:59:32 -0700 (PDT) Received: from thinkpad ([117.193.215.78]) by smtp.gmail.com with ESMTPSA id s2sm8830002pjs.56.2021.09.23.01.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 01:59:31 -0700 (PDT) Date: Thu, 23 Sep 2021 14:29:26 +0530 From: Manivannan Sadhasivam To: Carl Huang Cc: Kalle Valo , Loic Poulain , ath11k@lists.infradead.org, linux-arm-msm , linux-wireless@vger.kernel.org, regressions@lists.linux.dev Subject: Re: [regression] mhi: ath11k resume fails on some devices Message-ID: <20210923085926.GD6083@thinkpad> References: <871r5p0x2u.fsf@codeaurora.org> <20210916111218.GA12918@thinkpad> <20210916163529.GA9027@thinkpad> <87k0jgxyjp.fsf@codeaurora.org> <20210916171927.GB9027@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Sep 23, 2021 at 04:34:43PM +0800, Carl Huang wrote: > On 2021-09-17 01:19, Manivannan Sadhasivam wrote: > > On Thu, Sep 16, 2021 at 07:42:02PM +0300, Kalle Valo wrote: > > > Manivannan Sadhasivam writes: > > > > > > > On Thu, Sep 16, 2021 at 01:18:22PM +0200, Loic Poulain wrote: > > > >> Le jeu. 16 sept. 2021 à 13:12, Manivannan Sadhasivam < > > > >> manivannan.sadhasivam@linaro.org> a écrit : > > > >> > > > > > > > > [...] > > > > > > > >> > If things seems to work fine without that patch, then it implies that > > > >> > setting M0 > > > >> > state works during resume. I think we should just revert that patch. > > > >> > > > > >> > Loic, did that patch fix any issue for you or it was a cosmetic fix only? > > > >> > > > >> > > > >> It fixes sdx modem resuming issue, without that we don’t know modem needs > > > >> to be reinitialized. > > > >> > > > > > > > > Okay. Then in that case, the recovery mechanism has to be added to the ath11k > > > > MHI controller. > > > > > > What does that mean in practise, do you have any pointers or > > > examples? I > > > have no clue what you are proposing :) > > > > > > > Take a look at the mhi_pci_recovery_work() function below: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/bus/mhi/pci_generic.c#n610 > > > > You need to implement something similar that basically powers up the MHI > > endpoint (QCA6390) in case pm_resume() fails. At minimum, you need to > > call > > below functions: > > > > # Check if the device is powered on. If yes, then power it down to bring > > it back > > mhi_power_down() > > mhi_unprepare_after_power_down() > > > > # Power up the device > > mhi_prepare_for_power_up() > > mhi_sync_power_up() > > > > This implies that the WLAN device has been powered off during suspend, > > so the > > resume fails and we are bringing the device back to working state. > > > This is fine for platform which doesn't provide power supply during suspend. > But NUC has power supply in suspend state. If NUC retains power supply during suspend then it should work with that commit. During resume, the device is expected to be in M3 state and that's what the commit verifies. If the device is in a different state, then most likely the device have power cycled. > QCA6390 on NUC works after just reverting this commit also proves NUC has > power supply in > suspend state. > That's because we allowed the device to be in any state during resume and if it responds to the M0 transition it worked. > The reason is MHI-STATUS register can't be read somehow in M3 state on NUC. No, that's not correct. > Does the MHI spec state that MHI-STATUS register can be read in M3 state? > Yes, all the MHI registers are accessible in all states. During M3, both MHI host and device (if supported) will transition to D3 Cold. Then during resume, host will switch to D0 link state and will also notify the device to enter D0. For aid debugging, please see the state the device is in during mhi_pm_resume(). You can use below diff: diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c index fb99e3727155..482d55dd209e 100644 --- a/drivers/bus/mhi/core/pm.c +++ b/drivers/bus/mhi/core/pm.c @@ -898,6 +898,9 @@ int mhi_pm_resume(struct mhi_controller *mhi_cntrl) if (MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state)) return -EIO; + dev_info(dev, "Device state: %s\n", + TO_MHI_STATE_STR(mhi_get_mhi_state(mhi_cntrl))); + if (mhi_get_mhi_state(mhi_cntrl) != MHI_STATE_M3) return -EINVAL; Thanks, Mani