From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jackie Liu <liu.yun@linux.dev>
Cc: chenhuacai@kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT
Date: Thu, 23 Sep 2021 11:35:22 +0200 [thread overview]
Message-ID: <20210923093522.GA7289@alpha.franken.de> (raw)
In-Reply-To: <20210913061908.550030-1-liu.yun@linux.dev>
On Mon, Sep 13, 2021 at 02:19:08PM +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> mach/loongson64 fails to build when the FPU support is disabled:
>
> arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration]
> arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’
> arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’
>
> Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage")
> Suggested-by: Huacai Chen <chenhuacai@kernel.org>
> Reviewed-by: Huacai Chen <chenhuacai@kernel.org>
> Reported-by: k2ci robot <kernel-bot@kylinos.cn>
> Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
> v1->v2:
> move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64
>
> v2->v3:
> add Huacai Chen <chenhc@lemote.com>'s suggest label.
>
> v3->v4:
> update Huacai Chen's email address.
>
> arch/mips/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-09-23 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 6:19 [PATCH v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT Jackie Liu
2021-09-22 2:29 ` Jackie Liu
2021-09-23 9:35 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923093522.GA7289@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=liu.yun@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.