From: Gokul Sivakumar <gokulkumar792@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH iw 1/4] iw: nl80211: add NLA_F_NESTED to nla_nest_start() with older libnl versions
Date: Thu, 23 Sep 2021 21:23:08 +0530 [thread overview]
Message-ID: <20210923155308.GA3760174@lattitude> (raw)
In-Reply-To: <10ea557f9dfdf92083b9816d7370926e4222f333.camel@sipsolutions.net>
On Thu, Sep 23, 2021 at 01:36:01PM +0200, Johannes Berg wrote:
> Applied 2-4, but
>
> >
> > +#ifndef NL_CAPABILITY_VERSION_3_5_0
>
> I can find no evidence of that symbol ever existing anywhere?
>
> johannes
>
The symbol NL_CAPABILITY_VERSION_3_5_0 is part of the libnl library and
this will be defined when using the libnl library version >= 3.5.0.
From libnl 3.5.0, the library itself handles setting NLA_F_NESTED flag
when using nla_nest_start() lib function. Please refer the
commit 7de65a0 ("attr: mark nested attributes as NLA_F_NESTED") in libnl
gitub tree (https://github.com/thom311/libnl/commit/7de65a0).
With this new code changes in iw.h, it will helpful if "iw" uses older
(< 3.5.0) libnl versions. In such cases NL_CAPABILITY_VERSION_3_5_0 will
not be defined in libnl and so iw itself will set the NLA_F_NESTED flag
when invoking the lib function nla_nest_start().
And hostapd/supplicant already started following the same approach.
Gokul
next prev parent reply other threads:[~2021-09-23 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 14:16 [PATCH iw 1/4] iw: nl80211: add NLA_F_NESTED to nla_nest_start() with older libnl versions Gokul Sivakumar
2021-09-10 14:16 ` [PATCH iw 2/4] iw: link: mention the need for MAC addr arg in link get_sta cmd usage menu Gokul Sivakumar
2021-09-10 14:16 ` [PATCH iw 3/4] iw: event: add the missing time display format in the "iw event" help menu Gokul Sivakumar
2021-09-10 14:16 ` [PATCH iw 4/4] iw: mesh: add comments in the mesh confguration parameter printing sections Gokul Sivakumar
2021-09-23 11:36 ` [PATCH iw 1/4] iw: nl80211: add NLA_F_NESTED to nla_nest_start() with older libnl versions Johannes Berg
2021-09-23 15:53 ` Gokul Sivakumar [this message]
2021-09-23 15:56 ` Johannes Berg
2021-09-23 16:23 ` Gokul Sivakumar
2021-09-23 16:25 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923155308.GA3760174@lattitude \
--to=gokulkumar792@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.