From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: tag_rtl4_a: Drop bit 9 from egress frames
Date: Fri, 24 Sep 2021 01:25:49 +0300 [thread overview]
Message-ID: <20210923222549.byri6ch2kcvowtv4@skbuf> (raw)
In-Reply-To: <CACRpkdZJzHqmdfvR5kRgw1mWPQ68=-ky1xJ+VWX8v6hD_6bx6A@mail.gmail.com>
On Fri, Sep 24, 2021 at 12:21:39AM +0200, Linus Walleij wrote:
> On Fri, Sep 24, 2021 at 12:12 AM Vladimir Oltean <olteanv@gmail.com> wrote:
>
> > > Hm I suspect it disable learning on RTL8366RB as well.
> >
> > Suspicion based on what?
>
> I have a not yet finished patch that dumps the FDB :)
>
> The contents change around a bit under the patch
> sets I have floating, but can certainly be determined
> when I have time to test things properly.
To be clear, if bit 9 is a "disable learning" bit, address learning is a
process that takes place on the ingress of a packet, and in this case
the ingress port is the CPU port. But the ndo_fdb_dump works with net
devices, of which CPU ports have none. So it seems unlikely that you
would see any difference in the output of "bridge fdb" that could be
attributed to that bit.
> > > Do we have some use for that feature in DSA taggers?
> >
> > Yes.
>
> OK I'll add it to my TODO, right now trying to fix up the base
> of the RTL8366RB patch set to handle VLANs the right way.
But you didn't ask what that use is...
next prev parent reply other threads:[~2021-09-23 22:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 14:31 [PATCH net-next] net: dsa: tag_rtl4_a: Drop bit 9 from egress frames Linus Walleij
2021-09-13 16:05 ` Andrew Lunn
2021-09-13 16:06 ` Florian Fainelli
2021-09-15 3:10 ` patchwork-bot+netdevbpf
2021-09-15 7:19 ` DENG Qingfang
2021-09-23 21:59 ` Linus Walleij
2021-09-23 22:12 ` Vladimir Oltean
2021-09-23 22:21 ` Linus Walleij
2021-09-23 22:25 ` Vladimir Oltean [this message]
2021-09-23 22:58 ` Linus Walleij
2021-09-23 23:11 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923222549.byri6ch2kcvowtv4@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.