All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] boot/syslinux: add missing python dependency
Date: Fri, 24 Sep 2021 22:04:27 +0200	[thread overview]
Message-ID: <20210924200427.GH3176@scaer> (raw)
In-Reply-To: <20210923212831.391084-1-romain.naour@gmail.com>

Romain, All,

On 2021-09-23 23:28 +0200, Romain Naour spake thusly:
> Syslinux use some python scripts during the build and they
> are using python interpreter by default. It fail to build
> when there is no python interpreter on the host.
> 
> [...]/syslinux-6.03/com32/cmenu/menugen.py
> make[6]: python: No such file or directory
> 
> Since Syslinux 5.00, we can override the python interpreter
> used during the build:
> 
> https://repo.or.cz/syslinux.git/commitdiff/4dec62ce9c2c0d170f21b3ae2d7c618eb7a30c05
> 
> Add the	missing	host-python3 dependency and override
> it in SYSLINUX_BUILD_CMDS.
> 
> Fixes:
> https://gitlab.com/kubu93/buildroot/-/jobs/1614446766
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  boot/syslinux/syslinux.mk | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/boot/syslinux/syslinux.mk b/boot/syslinux/syslinux.mk
> index 67bc69254e..77bacca9a3 100644
> --- a/boot/syslinux/syslinux.mk
> +++ b/boot/syslinux/syslinux.mk
> @@ -14,7 +14,12 @@ SYSLINUX_LICENSE_FILES = COPYING
>  SYSLINUX_INSTALL_IMAGES = YES
>  
>  # host-util-linux needed to provide libuuid when building host tools
> -SYSLINUX_DEPENDENCIES = host-nasm host-upx util-linux host-util-linux
> +SYSLINUX_DEPENDENCIES = \
> +	host-nasm \
> +	host-python3 \
> +	host-upx \
> +	host-util-linux \
> +	util-linux \

    $ make check-package
    boot/syslinux/syslinux.mk:22: remove trailing backslash

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

>  ifeq ($(BR2_TARGET_SYSLINUX_LEGACY_BIOS),y)
>  SYSLINUX_TARGET += bios
> @@ -59,6 +64,7 @@ define SYSLINUX_BUILD_CMDS
>  		CC_FOR_BUILD="$(HOSTCC)" \
>  		CFLAGS_FOR_BUILD="$(HOST_CFLAGS)" \
>  		LDFLAGS_FOR_BUILD="$(HOST_LDFLAGS)" \
> +		PYTHON=$(HOST_DIR)/bin/python3 \
>  		$(SYSLINUX_EFI_ARGS) -C $(@D) $(SYSLINUX_TARGET)
>  endef
>  
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-09-24 20:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 21:28 [Buildroot] [PATCH] boot/syslinux: add missing python dependency Romain Naour
2021-09-24 20:04 ` Yann E. MORIN [this message]
2021-10-05 14:47 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210924200427.GH3176@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.