From: Shawn Guo <shawn.guo@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Rob Clark <robdclark@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Caleb Connolly <caleb@connolly.tech>,
Amit Pundir <amit.pundir@linaro.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: Drop vdd-supply from qusb2-phy devices
Date: Mon, 27 Sep 2021 10:00:08 +0800 [thread overview]
Message-ID: <20210927020007.GF9901@dragon> (raw)
In-Reply-To: <20210927000715.GD9901@dragon>
On Mon, Sep 27, 2021 at 08:07:16AM +0800, Shawn Guo wrote:
> On Mon, Sep 27, 2021 at 12:58:19AM +0200, Konrad Dybcio wrote:
> >
> > On 26.09.2021 09:59, Shawn Guo wrote:
> > > Looking at qcom,qusb2-phy.yaml bindings and qusb2_phy_vreg_names[] in
> > > qusb2-phy driver, vdd-supply is not a supported/valid property. Drop it
> > > from qusb2-phy devices on various boards.
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> >
> > Why not add it to the regulators list instead? It's a valid regulator for this hw.
>
> I do not have enough information to be sure. Could you cook up a patch to
> update bindings and driver, if you think that's the case? I will be
> happy as long as that DTS, bindings and driver are on the same page.
Aha, I checked downstream kernel and vdd is indeed a valid supply for
qusb2_phy. Please disregard this patch, and I will update bindings and
driver instead. Thanks, Konrad!
Shawn
prev parent reply other threads:[~2021-09-27 2:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 7:59 [PATCH] arm64: dts: qcom: Drop vdd-supply from qusb2-phy devices Shawn Guo
2021-09-26 9:41 ` Amit Pundir
2021-09-26 22:58 ` Konrad Dybcio
2021-09-27 0:07 ` Shawn Guo
2021-09-27 2:00 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927020007.GF9901@dragon \
--to=shawn.guo@linaro.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.