From: Kees Cook <keescook@chromium.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Arnd Bergmann" <arnd@arndb.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency
Date: Mon, 27 Sep 2021 09:23:45 -0700 [thread overview]
Message-ID: <202109270923.97AFDE89DB@keescook> (raw)
In-Reply-To: <20210927142816.2069269-1-arnd@kernel.org>
On Mon, Sep 27, 2021 at 04:28:02PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With CONFIG_FB=m and CONFIG_DRM=y, we get a link error in the fb helper:
>
> aarch64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_alloc_fbi':
> (.text+0x10cc): undefined reference to `framebuffer_alloc'
>
> Tighten the dependency so it is only allowed in the case that DRM can
> link against FB.
>
> Fixes: f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB")
> Link: https://lore.kernel.org/all/20210721152211.2706171-1-arnd@kernel.org/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for fixing this!
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2021-09-27 16:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 14:28 [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency Arnd Bergmann
2021-09-27 16:23 ` Kees Cook [this message]
2021-09-30 14:26 ` Daniel Vetter
2021-10-27 11:47 ` Jani Nikula
2021-10-27 12:13 ` Jani Nikula
2021-10-27 12:18 ` Arnd Bergmann
2021-10-27 12:38 ` Javier Martinez Canillas
2021-10-27 12:52 ` Arnd Bergmann
2021-10-27 12:56 ` Javier Martinez Canillas
2021-10-27 13:06 ` Jani Nikula
2021-10-27 13:25 ` Arnd Bergmann
2021-10-27 13:36 ` Javier Martinez Canillas
2021-10-27 12:55 ` Jani Nikula
2021-10-27 13:18 ` Javier Martinez Canillas
2021-10-27 13:05 ` Jani Nikula
2021-10-27 13:19 ` Javier Martinez Canillas
2021-10-28 15:24 ` Daniel Vetter
2021-10-29 12:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109270923.97AFDE89DB@keescook \
--to=keescook@chromium.org \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.