From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mUzpt-0005Zo-DI for mharc-grub-devel@gnu.org; Mon, 27 Sep 2021 19:15:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUzpn-0005XF-Sp for grub-devel@gnu.org; Mon, 27 Sep 2021 19:14:56 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:33628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUzpl-0004pE-Cr for grub-devel@gnu.org; Mon, 27 Sep 2021 19:14:55 -0400 Received: by mail-qt1-x82c.google.com with SMTP id x9so18370662qtv.0 for ; Mon, 27 Sep 2021 16:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iS4PVz8xcJHoJDXF2f6xtY6G7Y11MqrJeMCMGNykLzQ=; b=FqZTzRT1DssMhn6UNGybiCdKN5B74JNPT+h0V5lQKfz77yKxk+ZOJi3bSY8jMoh1bE 5MTquNVmTn64nhnnU3XmP4AGeJgA+q+qXFHV4CcaLAQNbXwgWHN3YqioRjSK1W50wUTr 7Sygsic3q5KiyZJXKKDE0EmbcTAf/Z+vk/jb843c93hye7wghvYLW5xDJPnS8kYvl8g7 s6BwDJlj0Thsdi7WzRTMEeMgo6MOPqSWOSH85SMapy7PELtNa36MUeR1v3Z2/qZKBkyW fgME8ste0Fa3HV3icbm5eq7tqeTHmCzwZAXKQzX0kXqURUrxcN/hVw/lBOVYNWeUThfn oWWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iS4PVz8xcJHoJDXF2f6xtY6G7Y11MqrJeMCMGNykLzQ=; b=OKx3oFWvYfP4gQ5PEfT17LpqSskocr+NmtiLYKy/5Q+eNEGfR7znfHZk55+tMps+cQ H9Z0OsGBLrEgRivxyP/wQQWw0VqQQPb9qSyPU0ZnVt1FZIADZdwfvurqfYYHExtHfnXU sLrP0YgCJECWZHeBeeHbXV3HTUmK8iqyV5NwvAgoHK0B6OB578Zdi1mdu1Fv9t0yXALi 4wL9EMdThGistSzijpYuJb0y37UnbTbLJ29QG5ixmnegwPkh/ER8gLFBmX49JWolzZhH 2z71smnW2JoyQRe4i56v4LHQtwtsYT8cv7Gi3OSgBVfzb6UOqZ+GJwvLkpyo3wRBY9SY 5p3w== X-Gm-Message-State: AOAM531x65vgFY9HIDAr6M/yhpkmP6z6TB0MZidiBRUsfOObKze+oElu rsbiXlx1e967C2BJgzhC9SjTSB1UuByfMQ== X-Google-Smtp-Source: ABdhPJz8+RJRx096BjI2IVMhcT7L67Qm1pieKx+Cd8hxfnChnk1wMLGjJO2k0WnJ8ZTPZvp9zFvC7g== X-Received: by 2002:a05:622a:181d:: with SMTP id t29mr2545425qtc.337.1632784492284; Mon, 27 Sep 2021 16:14:52 -0700 (PDT) Received: from localhost.localdomain ([37.218.244.251]) by smtp.gmail.com with ESMTPSA id n16sm11671214qta.51.2021.09.27.16.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 16:14:51 -0700 (PDT) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Denis 'GNUtoo' Carikli , Patrick Steinhardt , James Bottomley , Glenn Washburn Subject: [PATCH v2 3/4] cryptodisk: Move global variables into grub_cryptomount_args struct Date: Mon, 27 Sep 2021 18:14:02 -0500 Message-Id: <20210927231403.642857-4-development@efficientek.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210927231403.642857-1-development@efficientek.com> References: <20210927231403.642857-1-development@efficientek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=development@efficientek.com; helo=mail-qt1-x82c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2021 23:14:56 -0000 Signed-off-by: Glenn Washburn --- grub-core/disk/cryptodisk.c | 26 +++++++++----------------- grub-core/disk/geli.c | 9 ++++----- grub-core/disk/luks.c | 11 +++++------ grub-core/disk/luks2.c | 6 +++--- include/grub/cryptodisk.h | 6 ++++-- 5 files changed, 25 insertions(+), 33 deletions(-) diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c index 86eaabe60..5e153ee0a 100644 --- a/grub-core/disk/cryptodisk.c +++ b/grub-core/disk/cryptodisk.c @@ -984,9 +984,6 @@ grub_util_cryptodisk_get_uuid (grub_disk_t disk) #endif -static int check_boot, have_it; -static char *search_uuid; - static void cryptodisk_close (grub_cryptodisk_t dev) { @@ -1014,7 +1011,7 @@ grub_cryptodisk_scan_device_real (const char *name, FOR_CRYPTODISK_DEVS (cr) { - dev = cr->scan (source, search_uuid, check_boot); + dev = cr->scan (source, cargs); if (grub_errno) return grub_errno; if (!dev) @@ -1049,7 +1046,7 @@ grub_cryptodisk_scan_device_real (const char *name, grub_cryptodisk_insert (dev, name, source); - have_it = 1; + cargs->found_uuid = 1; goto cleanup; } @@ -1091,7 +1088,7 @@ grub_cryptodisk_cheat_mount (const char *sourcedev, const char *cheat) FOR_CRYPTODISK_DEVS (cr) { - dev = cr->scan (source, search_uuid, check_boot); + dev = cr->scan (source, NULL); if (grub_errno) return grub_errno; if (!dev) @@ -1135,7 +1132,7 @@ grub_cryptodisk_scan_device (const char *name, if (err) grub_print_error (); - return have_it && search_uuid ? 1 : 0; + return (cargs->found_uuid && cargs->search_uuid) ? 1 : 0; } static grub_err_t @@ -1153,7 +1150,6 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) cargs.key_len = grub_strlen(state[3].arg); } - have_it = 0; if (state[0].set) /* uuid */ { grub_cryptodisk_t dev; @@ -1166,21 +1162,18 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) return GRUB_ERR_NONE; } - check_boot = state[2].set; - search_uuid = args[0]; + cargs.check_boot = state[2].set; + cargs.search_uuid = args[0]; grub_device_iterate (&grub_cryptodisk_scan_device, &cargs); - search_uuid = NULL; - if (!have_it) + if (!cargs.found_uuid) return grub_error (GRUB_ERR_BAD_ARGUMENT, "no such cryptodisk found"); return GRUB_ERR_NONE; } else if (state[1].set || (argc == 0 && state[2].set)) /* -a|-b */ { - search_uuid = NULL; - check_boot = state[2].set; + cargs.check_boot = state[2].set; grub_device_iterate (&grub_cryptodisk_scan_device, &cargs); - search_uuid = NULL; return GRUB_ERR_NONE; } else @@ -1192,8 +1185,7 @@ grub_cmd_cryptomount (grub_extcmd_context_t ctxt, int argc, char **args) char *disklast = NULL; grub_size_t len; - search_uuid = NULL; - check_boot = state[2].set; + cargs.check_boot = state[2].set; diskname = args[0]; len = grub_strlen (diskname); if (len && diskname[0] == '(' && diskname[len - 1] == ')') diff --git a/grub-core/disk/geli.c b/grub-core/disk/geli.c index 32f34d5c3..32d35521b 100644 --- a/grub-core/disk/geli.c +++ b/grub-core/disk/geli.c @@ -240,8 +240,7 @@ grub_util_get_geli_uuid (const char *dev) #endif static grub_cryptodisk_t -configure_ciphers (grub_disk_t disk, const char *check_uuid, - int boot_only) +configure_ciphers (grub_disk_t disk, grub_cryptomount_args_t cargs) { grub_cryptodisk_t newdev; struct grub_geli_phdr header; @@ -289,7 +288,7 @@ configure_ciphers (grub_disk_t disk, const char *check_uuid, return NULL; } - if (boot_only && !(grub_le_to_cpu32 (header.flags) & GRUB_GELI_FLAGS_BOOT)) + if (cargs->check_boot && !(grub_le_to_cpu32 (header.flags) & GRUB_GELI_FLAGS_BOOT)) { grub_dprintf ("geli", "not a boot volume\n"); return NULL; @@ -302,9 +301,9 @@ configure_ciphers (grub_disk_t disk, const char *check_uuid, return NULL; } - if (check_uuid && grub_strcasecmp (check_uuid, uuid) != 0) + if (cargs->search_uuid && grub_strcasecmp (cargs->search_uuid, uuid) != 0) { - grub_dprintf ("geli", "%s != %s\n", uuid, check_uuid); + grub_dprintf ("geli", "%s != %s\n", uuid, cargs->search_uuid); return NULL; } diff --git a/grub-core/disk/luks.c b/grub-core/disk/luks.c index 51646cefe..6ced312c7 100644 --- a/grub-core/disk/luks.c +++ b/grub-core/disk/luks.c @@ -63,8 +63,7 @@ gcry_err_code_t AF_merge (const gcry_md_spec_t * hash, grub_uint8_t * src, grub_size_t blocknumbers); static grub_cryptodisk_t -configure_ciphers (grub_disk_t disk, const char *check_uuid, - int check_boot) +configure_ciphers (grub_disk_t disk, grub_cryptomount_args_t cargs) { grub_cryptodisk_t newdev; const char *iptr; @@ -76,7 +75,7 @@ configure_ciphers (grub_disk_t disk, const char *check_uuid, char hashspec[sizeof (header.hashSpec) + 1]; grub_err_t err; - if (check_boot) + if (cargs->check_boot) return NULL; /* Read the LUKS header. */ @@ -103,9 +102,9 @@ configure_ciphers (grub_disk_t disk, const char *check_uuid, } *optr = 0; - if (check_uuid && grub_strcasecmp (check_uuid, uuid) != 0) + if (cargs->search_uuid && grub_strcasecmp (cargs->search_uuid, uuid) != 0) { - grub_dprintf ("luks", "%s != %s\n", uuid, check_uuid); + grub_dprintf ("luks", "%s != %s\n", uuid, cargs->search_uuid); return NULL; } @@ -162,7 +161,7 @@ luks_recover_key (grub_disk_t source, grub_err_t err; grub_size_t max_stripes = 1; - if (cargs->key_data == NULL || cargs->key_len == 0) + if (cargs->key_data == NULL || cargs->key_len == 0) return grub_error (GRUB_ERR_BAD_ARGUMENT, "No key data"); err = grub_disk_read (source, 0, 0, sizeof (header), &header); diff --git a/grub-core/disk/luks2.c b/grub-core/disk/luks2.c index c77380cbb..28fad54aa 100644 --- a/grub-core/disk/luks2.c +++ b/grub-core/disk/luks2.c @@ -346,14 +346,14 @@ luks2_read_header (grub_disk_t disk, grub_luks2_header_t *outhdr) } static grub_cryptodisk_t -luks2_scan (grub_disk_t disk, const char *check_uuid, int check_boot) +luks2_scan (grub_disk_t disk, grub_cryptomount_args_t cargs) { grub_cryptodisk_t cryptodisk; grub_luks2_header_t header; char uuid[sizeof (header.uuid) + 1]; grub_size_t i, j; - if (check_boot) + if (cargs->check_boot) return NULL; if (luks2_read_header (disk, &header)) @@ -367,7 +367,7 @@ luks2_scan (grub_disk_t disk, const char *check_uuid, int check_boot) uuid[j++] = header.uuid[i]; uuid[j] = '\0'; - if (check_uuid && grub_strcasecmp (check_uuid, uuid) != 0) + if (cargs->search_uuid && grub_strcasecmp (cargs->search_uuid, uuid) != 0) return NULL; cryptodisk = grub_zalloc (sizeof (*cryptodisk)); diff --git a/include/grub/cryptodisk.h b/include/grub/cryptodisk.h index 5bd970692..230167ab0 100644 --- a/include/grub/cryptodisk.h +++ b/include/grub/cryptodisk.h @@ -69,6 +69,9 @@ typedef gcry_err_code_t struct grub_cryptomount_args { + grub_uint32_t check_boot : 1; + grub_uint32_t found_uuid : 1; + char *search_uuid; grub_uint8_t *key_data; grub_size_t key_len; }; @@ -125,8 +128,7 @@ struct grub_cryptodisk_dev struct grub_cryptodisk_dev *next; struct grub_cryptodisk_dev **prev; - grub_cryptodisk_t (*scan) (grub_disk_t disk, const char *check_uuid, - int boot_only); + grub_cryptodisk_t (*scan) (grub_disk_t disk, grub_cryptomount_args_t cargs); grub_err_t (*recover_key) (grub_disk_t disk, grub_cryptodisk_t dev, grub_cryptomount_args_t cargs); }; typedef struct grub_cryptodisk_dev *grub_cryptodisk_dev_t; -- 2.32.0