All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/dtbocfg: new package
Date: Tue, 28 Sep 2021 10:51:35 +0200	[thread overview]
Message-ID: <20210928105135.651ca5a2@windsurf> (raw)
In-Reply-To: <20210928082328.1466348-1-herve.codina@bootlin.com>

Hello Hervé,

Thanks for this patch. Two small comments below.

On Tue, 28 Sep 2021 10:23:28 +0200
Herve Codina <herve.codina@bootlin.com> wrote:

> diff --git a/package/dtbocfg/Config.in b/package/dtbocfg/Config.in
> new file mode 100644
> index 0000000000..1e6ce3952d
> --- /dev/null
> +++ b/package/dtbocfg/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_DTBOCFG
> +	bool "dtbocfg"
> +	help
> +	  dtbocfg, which stands for Device Tree Blob Overlay Configuration
> +          File System, was developed to serve as a userspace API of Device
> +          Tree Overlay.

There is an indentation issue here. The continuation lines should also
have a one tab + 2 spaces indentation. I guess this is probably
reported by "make check-package".

> +DTBOCFG_VERSION = v0.0.9
> +DTBOCFG_SITE = $(call github,ikwzm,dtbocfg,$(DTBOCFG_VERSION))

This should be:

DTBOCFG_VERSION = 0.0.9
DTBOCFG_SITE = $(call github,ikwzm,dtbocfg,v$(DTBOCFG_VERSION))

Indeed, we don't want the "v" prefix to appear in the version, so that
the version can match with what release-monitoring.org reports.

> diff --git a/support/testing/tests/package/test_dtbocfg.py b/support/testing/tests/package/test_dtbocfg.py
> new file mode 100644
> index 0000000000..d25b1692b4
> --- /dev/null
> +++ b/support/testing/tests/package/test_dtbocfg.py

Great, a test case!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-09-28  8:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  8:23 [Buildroot] [PATCH 1/1] package/dtbocfg: new package Herve Codina
2021-09-28  8:51 ` Thomas Petazzoni [this message]
2021-09-28 15:40   ` Herve Codina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210928105135.651ca5a2@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=herve.codina@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.