From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D85C433F5 for ; Tue, 28 Sep 2021 12:47:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59ED6610E5 for ; Tue, 28 Sep 2021 12:47:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 59ED6610E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dcUJk92AlSc6rBKqq0VoK5sBwBCMBkXyT5sp0pG8A1s=; b=CGSqo/jUrc02// opE7WCdVjK/XzTWfziGHZzbDhKAAGVOqvIdJuQMyH6mIBM/qwFhBFU/tWR9XbLu/rMINTKsbOfryb uxVTFdWwCS02/0byy/NvEhRyfIeyzaLHtMLBVvvL7O2SvL17q2Shto+00rhJRQAcRPpoo7maseRJm 6v6JlDkiiu0NZ0889rFMPsgNxwgatFqc+GDo4oAj7lFrlimQyw0CI8e9Me/QbEiQC05EHHmVf90jD e6Lj7QA+5TlXc79VenK9A/FRbqt/asxlWLypexjlIOPD1xocDhMlucyZS8QR7/BNfounPSvWOGtqk Zf/NN3P3BoaMF+9Nk7lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVCVa-007Cy6-Ai; Tue, 28 Sep 2021 12:46:54 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVCVW-007Cwb-2x for linux-mtd@lists.infradead.org; Tue, 28 Sep 2021 12:46:52 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 6F135FF806; Tue, 28 Sep 2021 12:46:46 +0000 (UTC) Date: Tue, 28 Sep 2021 14:46:45 +0200 From: Miquel Raynal To: mdalam@codeaurora.org Cc: mani@kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH 1/3] mtd: rawnand: qcom: Add support for status pipe Message-ID: <20210928144645.40209af0@xps13> In-Reply-To: <97df48e5505c4e6ae3bc6b7e953c156c@codeaurora.org> References: <1631699851-12172-1-git-send-email-mdalam@codeaurora.org> <1631699851-12172-2-git-send-email-mdalam@codeaurora.org> <97df48e5505c4e6ae3bc6b7e953c156c@codeaurora.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_054650_310333_AEBBB94D X-CRM114-Status: GOOD ( 22.22 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgptZGFsYW1AY29kZWF1cm9yYS5vcmcgd3JvdGUgb24gVHVlLCAyOCBTZXAgMjAyMSAx Nzo0NzoyNyArMDUzMDoKCj4gT24gMjAyMS0wOS0xNSAxNToyNywgTWQgU2FkcmUgQWxhbSB3cm90 ZToKPiA+IEZyb20gUVBJQyBWMi4wIG9ud2FyZHMgdGhlcmUgaXMgYSBzZXBhcmF0ZSBwaXBlCj4g PiB0byByZWFkIHN0YXR1cyBvZiBlYWNoIGNvZGUgd29yZCwgY2FsbGVkICJzdGF0dXMiIHBpcGUu Cj4gPiAKPiA+ICJzdGF0dXMiIHBpcGUgd2lsbCB1c2UgdG8gcmVhZCBDVyBzdGF0dXMgaW4gY2Fz ZSBvZgoKV2hhdCBpcyBhIENXIHN0YXR1cz8KCj4gPiBlbmhhbmNlZCByZWFkIG1vZGUgbGlrZSBw YWdlIHNjb3BlIHJlYWQsIG11bHRpIHBhZ2UgcmVhZC4KCldoYXQgaXMgYSBwYWdlIHNjb3BlIHJl YWQ/Cgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNZCBTYWRyZSBBbGFtIDxtZGFsYW1AY29kZWF1 cm9yYS5vcmc+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9xY29tX25hbmRjLmMg fCAxNCArKysrKysrKysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCsp Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9xY29tX25hbmRjLmMK PiA+IGIvZHJpdmVycy9tdGQvbmFuZC9yYXcvcWNvbV9uYW5kYy5jCj4gPiBpbmRleCAwNGU2Zjdi Li40MmM2MjkxIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvcWNvbV9uYW5k Yy5jCj4gPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9xY29tX25hbmRjLmMKPiA+IEBAIC0z ODksNiArMzg5LDcgQEAgc3RydWN0IHFjb21fbmFuZF9jb250cm9sbGVyIHsKPiA+ICAJCQlzdHJ1 Y3QgZG1hX2NoYW4gKnR4X2NoYW47Cj4gPiAgCQkJc3RydWN0IGRtYV9jaGFuICpyeF9jaGFuOwo+ ID4gIAkJCXN0cnVjdCBkbWFfY2hhbiAqY21kX2NoYW47Cj4gPiArCQkJc3RydWN0IGRtYV9jaGFu ICpzdHNfY2hhbjsKPiA+ICAJCX07Cj4gPiAKPiA+ICAJCS8qIHdpbGwgYmUgdXNlZCBvbmx5IGJ5 IEVCSTIgZm9yIEFETSBETUEgKi8KPiA+IEBAIC0yNzM3LDYgKzI3MzgsMTEgQEAgc3RhdGljIHZv aWQgcWNvbV9uYW5kY191bmFsbG9jKHN0cnVjdAo+ID4gcWNvbV9uYW5kX2NvbnRyb2xsZXIgKm5h bmRjKQo+ID4gCj4gPiAgCQlpZiAobmFuZGMtPmNtZF9jaGFuKQo+ID4gIAkJCWRtYV9yZWxlYXNl X2NoYW5uZWwobmFuZGMtPmNtZF9jaGFuKTsKPiA+ICsKPiA+ICsJCWlmIChuYW5kYy0+cHJvcHMt PnFwaWNfdjIpIHsKPiA+ICsJCQlpZiAobmFuZGMtPnN0c19jaGFuKQo+ID4gKwkJCQlkbWFfcmVs ZWFzZV9jaGFubmVsKG5hbmRjLT5zdHNfY2hhbik7Cj4gPiArCQl9Cj4gPiAgCX0gZWxzZSB7Cj4g PiAgCQlpZiAobmFuZGMtPmNoYW4pCj4gPiAgCQkJZG1hX3JlbGVhc2VfY2hhbm5lbChuYW5kYy0+ Y2hhbik7Cj4gPiBAQCAtMjgxNSw2ICsyODIxLDE0IEBAIHN0YXRpYyBpbnQgcWNvbV9uYW5kY19h bGxvYyhzdHJ1Y3QKPiA+IHFjb21fbmFuZF9jb250cm9sbGVyICpuYW5kYykKPiA+ICAJCQlnb3Rv IHVuYWxsb2M7Cj4gPiAgCQl9Cj4gPiAKPiA+ICsJCWlmIChuYW5kYy0+cHJvcHMtPnFwaWNfdjIp IHsKPiA+ICsJCQluYW5kYy0+c3RzX2NoYW4gPSBkbWFfcmVxdWVzdF9zbGF2ZV9jaGFubmVsKG5h bmRjLT5kZXYsICJzdHMiKTsKPiA+ICsJCQlpZiAoIW5hbmRjLT5zdHNfY2hhbikgewo+ID4gKwkJ CQlkZXZfZXJyKG5hbmRjLT5kZXYsICJmYWlsZWQgdG8gcmVxdWVzdCBzdHMgY2hhbm5lbFxuIik7 Cj4gPiArCQkJCXJldHVybiAtRU5PREVWOwo+ID4gKwkJCX0KPiA+ICsJCX0KPiA+ICsKPiA+ICAJ CS8qCj4gPiAgCQkgKiBJbml0aWFsbHkgYWxsb2NhdGUgQkFNIHRyYW5zYWN0aW9uIHRvIHJlYWQg T05GSSBwYXJhbSBwYWdlLgo+ID4gIAkJICogQWZ0ZXIgZGV0ZWN0aW5nIGFsbCB0aGUgZGV2aWNl cywgdGhpcyBCQU0gdHJhbnNhY3Rpb24gd2lsbCAgCj4gCj4gUGluZyEgUGxlYXNlIHByb3ZpZGUg bWUgc29tZSB1cGRhdGVzIG9uIHRoaXMgcGF0Y2guCgpJIGRvbid0IHRoaW5rIHlvdSBuZWVkIHRv IHBpbmcgbWUgb24gYWxsIHlvdXIgcGF0Y2hlcy4gVGhpcyBpcwppcnJpdGF0aW5nIGdpdmVuIHRo ZSB0aW1lIHRoYXQgSSBhbGxvY2F0ZWQgdG8gYWxsIHlvdXIgY29udHJpYnV0aW9ucyBzbwpmYXIu CgpUaGlzIGJlaW5nIHNhaWQsIEkgaGFkIG5vIHBhcnRpY3VsYXIgY29tbWVudCByZWdhcmRpbmcg dGhlCmltcGxlbWVudGF0aW9uIG9mIHRoZSBzZXJpZXMgYnV0IGdpdmluZyBpdCBhIHNlY29uZCBs b29rIEkgc3RpbGwgZG9uJ3QKZnVsbHkgdW5kZXJzdGFuZCB0aGUgZ29hbCBvZiB0aGlzICJhZGRp dGlvbmFsIHBpcGUiIHNvLCBhcyBteSBjb21tZW50cwphYm92ZSBzYXksIHBsZWFzZSBlbGFib3Jh dGUgYSBsaXR0bGUgYml0LgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFp bGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6333CC433EF for ; Tue, 28 Sep 2021 12:46:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43B64611F0 for ; Tue, 28 Sep 2021 12:46:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240733AbhI1Ms2 convert rfc822-to-8bit (ORCPT ); Tue, 28 Sep 2021 08:48:28 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:53397 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240578AbhI1Ms1 (ORCPT ); Tue, 28 Sep 2021 08:48:27 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 6F135FF806; Tue, 28 Sep 2021 12:46:46 +0000 (UTC) Date: Tue, 28 Sep 2021 14:46:45 +0200 From: Miquel Raynal To: mdalam@codeaurora.org Cc: mani@kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH 1/3] mtd: rawnand: qcom: Add support for status pipe Message-ID: <20210928144645.40209af0@xps13> In-Reply-To: <97df48e5505c4e6ae3bc6b7e953c156c@codeaurora.org> References: <1631699851-12172-1-git-send-email-mdalam@codeaurora.org> <1631699851-12172-2-git-send-email-mdalam@codeaurora.org> <97df48e5505c4e6ae3bc6b7e953c156c@codeaurora.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, mdalam@codeaurora.org wrote on Tue, 28 Sep 2021 17:47:27 +0530: > On 2021-09-15 15:27, Md Sadre Alam wrote: > > From QPIC V2.0 onwards there is a separate pipe > > to read status of each code word, called "status" pipe. > > > > "status" pipe will use to read CW status in case of What is a CW status? > > enhanced read mode like page scope read, multi page read. What is a page scope read? > > > > Signed-off-by: Md Sadre Alam > > --- > > drivers/mtd/nand/raw/qcom_nandc.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/mtd/nand/raw/qcom_nandc.c > > b/drivers/mtd/nand/raw/qcom_nandc.c > > index 04e6f7b..42c6291 100644 > > --- a/drivers/mtd/nand/raw/qcom_nandc.c > > +++ b/drivers/mtd/nand/raw/qcom_nandc.c > > @@ -389,6 +389,7 @@ struct qcom_nand_controller { > > struct dma_chan *tx_chan; > > struct dma_chan *rx_chan; > > struct dma_chan *cmd_chan; > > + struct dma_chan *sts_chan; > > }; > > > > /* will be used only by EBI2 for ADM DMA */ > > @@ -2737,6 +2738,11 @@ static void qcom_nandc_unalloc(struct > > qcom_nand_controller *nandc) > > > > if (nandc->cmd_chan) > > dma_release_channel(nandc->cmd_chan); > > + > > + if (nandc->props->qpic_v2) { > > + if (nandc->sts_chan) > > + dma_release_channel(nandc->sts_chan); > > + } > > } else { > > if (nandc->chan) > > dma_release_channel(nandc->chan); > > @@ -2815,6 +2821,14 @@ static int qcom_nandc_alloc(struct > > qcom_nand_controller *nandc) > > goto unalloc; > > } > > > > + if (nandc->props->qpic_v2) { > > + nandc->sts_chan = dma_request_slave_channel(nandc->dev, "sts"); > > + if (!nandc->sts_chan) { > > + dev_err(nandc->dev, "failed to request sts channel\n"); > > + return -ENODEV; > > + } > > + } > > + > > /* > > * Initially allocate BAM transaction to read ONFI param page. > > * After detecting all the devices, this BAM transaction will > > Ping! Please provide me some updates on this patch. I don't think you need to ping me on all your patches. This is irritating given the time that I allocated to all your contributions so far. This being said, I had no particular comment regarding the implementation of the series but giving it a second look I still don't fully understand the goal of this "additional pipe" so, as my comments above say, please elaborate a little bit. Thanks, Miquèl