From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E55C433F5 for ; Wed, 29 Sep 2021 15:21:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1F3561462 for ; Wed, 29 Sep 2021 15:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345017AbhI2PWr (ORCPT ); Wed, 29 Sep 2021 11:22:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:33326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344945AbhI2PWr (ORCPT ); Wed, 29 Sep 2021 11:22:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8354F60E90; Wed, 29 Sep 2021 15:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632928866; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WeosoLhjSZ2ADw8VKBMi1lZE0t2uDGiTjJUw0ycueB3gr1dBqo99pL1I9WHG6HKV7 qXi1FN/IAwGkVX0dzVMJK4nMPf0vZUbHDkLYk1jqw+Yn7fJMd1OqD14zzB5Q/X+fO5 UDEtNxcU8fO0KcNERM4AKqMdJkm/l/acQ1UmRcXRw3h6Oz36iclxctw6USk5l5rNng MIbBr7v1U04/aFj4lXNrApHbdZZnBgYlO6X9nqlln4s4msU3Yyjk+4mO00CVlzVt52 LI5RMXXMgRovqp/0q1GU7FX+zmcAzyYMoBUa2ixzRySnJoofG0pzUryhPQ2ofqrQhR z06k+GlVhuK5w== From: Mark Brown To: Catalin Marinas , Will Deacon , Shuah Khan , Shuah Khan Cc: linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com, Mark Brown Subject: [PATCH v3 2/4] selftests: arm64: Remove bogus error check on writing to files Date: Wed, 29 Sep 2021 16:19:23 +0100 Message-Id: <20210929151925.9601-3-broonie@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210929151925.9601-1-broonie@kernel.org> References: <20210929151925.9601-1-broonie@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1028; h=from:subject; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBhVIP6GHlxtnIY4Eu/5/J5cdKSDM5mRmL00dmRJpB8 pcoNJEyJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCYVSD+gAKCRAk1otyXVSH0E18B/ 9Hs4jDmaOPQGNF84tDPugrITikWZnf2rOqvbePNTeuXKU+pjBgEI7bKkAak6UbYEioytcV++EUxOSx RjT2IXqKrIvCq1WrkBV2/3V8fF94Uu6lIS5jIAnzTEbTMWcNLIoDRaPpTf3EtmTgvltykTH9UhhDWm amvOLpAxUhsIx2aoICp/a3mtNPm6clUfSK/f/tNtZwk5hm3vQeSgJGi2P63LjyOIRiezNnNS5fv6sp hOusJLjutWPtE30sep9teggPkJS5vZN1Ma0ni2uQe7y9Qx4w9fOYhDyAWIUr1IuMcp+HguYeiSX95v pHIW1nZUtJneeKWQ+T0FXECKQbXC2+ X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Due to some refactoring with the error handling we ended up mangling things so we never actually set ret and therefore shouldn't be checking it. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/vec-syscfg.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/arm64/fp/vec-syscfg.c b/tools/testing/selftests/arm64/fp/vec-syscfg.c index b2de002ee325..d48d3ee1bc36 100644 --- a/tools/testing/selftests/arm64/fp/vec-syscfg.c +++ b/tools/testing/selftests/arm64/fp/vec-syscfg.c @@ -180,7 +180,6 @@ static int file_read_integer(const char *name, int *val) static int file_write_integer(const char *name, int val) { FILE *f; - int ret; f = fopen(name, "w"); if (!f) { @@ -192,11 +191,6 @@ static int file_write_integer(const char *name, int val) fprintf(f, "%d", val); fclose(f); - if (ret < 0) { - ksft_test_result_fail("Error writing %d to %s\n", - val, name); - return -1; - } return 0; } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C3BCC433EF for ; Wed, 29 Sep 2021 15:23:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1698261440 for ; Wed, 29 Sep 2021 15:23:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1698261440 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5fnrnokOt5826wOfBJUgN5c0VyWwx189IN7FufqYZEs=; b=m2H0N3Iy5XjQic 8hcVkDp23nNZW5+jCwJNWXPAzPewedCOfVGb4eE15PBP0PB7fPoWVE2oIPhKIe9dJevjZE9WbeiyM b7l3ERYX9G7m0pANN/QnG5cPZyqg2aVj3fAEADTjrvZrjuDvbyZwSMGX3gGGR2IA4iNRMJ6BbJG3a Y5OSSyx1pkUYpvu7ANKo0pQ5NZIBSQdb0lNB/vq6trWO2um2wHcQDFdI0ba55nN6eWsBph9aXKhg7 HD2qFZD0wgADtMSXZr/XXKExGq0whO4JGXgULbr6L/kGiepL74zU7WP7+09wA14jQG6nR3cLc4kM2 aTUacowcu++jW+MLxBiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVbOo-00BWsN-Cl; Wed, 29 Sep 2021 15:21:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVbOM-00BWme-B8 for linux-arm-kernel@lists.infradead.org; Wed, 29 Sep 2021 15:21:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8354F60E90; Wed, 29 Sep 2021 15:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632928866; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WeosoLhjSZ2ADw8VKBMi1lZE0t2uDGiTjJUw0ycueB3gr1dBqo99pL1I9WHG6HKV7 qXi1FN/IAwGkVX0dzVMJK4nMPf0vZUbHDkLYk1jqw+Yn7fJMd1OqD14zzB5Q/X+fO5 UDEtNxcU8fO0KcNERM4AKqMdJkm/l/acQ1UmRcXRw3h6Oz36iclxctw6USk5l5rNng MIbBr7v1U04/aFj4lXNrApHbdZZnBgYlO6X9nqlln4s4msU3Yyjk+4mO00CVlzVt52 LI5RMXXMgRovqp/0q1GU7FX+zmcAzyYMoBUa2ixzRySnJoofG0pzUryhPQ2ofqrQhR z06k+GlVhuK5w== From: Mark Brown To: Catalin Marinas , Will Deacon , Shuah Khan , Shuah Khan Cc: linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com, Mark Brown Subject: [PATCH v3 2/4] selftests: arm64: Remove bogus error check on writing to files Date: Wed, 29 Sep 2021 16:19:23 +0100 Message-Id: <20210929151925.9601-3-broonie@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210929151925.9601-1-broonie@kernel.org> References: <20210929151925.9601-1-broonie@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1028; h=from:subject; bh=yJ4ueh+BO+Eim5GlQAHvD/jC8/yyMw/A2pszTTlipf8=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBhVIP6GHlxtnIY4Eu/5/J5cdKSDM5mRmL00dmRJpB8 pcoNJEyJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCYVSD+gAKCRAk1otyXVSH0E18B/ 9Hs4jDmaOPQGNF84tDPugrITikWZnf2rOqvbePNTeuXKU+pjBgEI7bKkAak6UbYEioytcV++EUxOSx RjT2IXqKrIvCq1WrkBV2/3V8fF94Uu6lIS5jIAnzTEbTMWcNLIoDRaPpTf3EtmTgvltykTH9UhhDWm amvOLpAxUhsIx2aoICp/a3mtNPm6clUfSK/f/tNtZwk5hm3vQeSgJGi2P63LjyOIRiezNnNS5fv6sp hOusJLjutWPtE30sep9teggPkJS5vZN1Ma0ni2uQe7y9Qx4w9fOYhDyAWIUr1IuMcp+HguYeiSX95v pHIW1nZUtJneeKWQ+T0FXECKQbXC2+ X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_082106_474501_EC422D08 X-CRM114-Status: UNSURE ( 9.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Due to some refactoring with the error handling we ended up mangling things so we never actually set ret and therefore shouldn't be checking it. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/vec-syscfg.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/arm64/fp/vec-syscfg.c b/tools/testing/selftests/arm64/fp/vec-syscfg.c index b2de002ee325..d48d3ee1bc36 100644 --- a/tools/testing/selftests/arm64/fp/vec-syscfg.c +++ b/tools/testing/selftests/arm64/fp/vec-syscfg.c @@ -180,7 +180,6 @@ static int file_read_integer(const char *name, int *val) static int file_write_integer(const char *name, int val) { FILE *f; - int ret; f = fopen(name, "w"); if (!f) { @@ -192,11 +191,6 @@ static int file_write_integer(const char *name, int val) fprintf(f, "%d", val); fclose(f); - if (ret < 0) { - ksft_test_result_fail("Error writing %d to %s\n", - val, name); - return -1; - } return 0; } -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel