From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C487C433F5 for ; Thu, 30 Sep 2021 05:46:47 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AC0A617E5 for ; Thu, 30 Sep 2021 05:46:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0AC0A617E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D1BDB8405D; Thu, 30 Sep 2021 05:46:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M8gJREN6JAhy; Thu, 30 Sep 2021 05:46:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id C2D788405B; Thu, 30 Sep 2021 05:46:45 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9A634C000F; Thu, 30 Sep 2021 05:46:45 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id B1B73C000D for ; Thu, 30 Sep 2021 05:46:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8CAD6607A9 for ; Thu, 30 Sep 2021 05:46:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3o3GMvtdTj34 for ; Thu, 30 Sep 2021 05:46:43 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp3.osuosl.org (Postfix) with ESMTPS id CA4116073D for ; Thu, 30 Sep 2021 05:46:42 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 3107468AFE; Thu, 30 Sep 2021 07:46:38 +0200 (CEST) Date: Thu, 30 Sep 2021 07:46:37 +0200 From: Christoph Hellwig To: Mike Rapoport Subject: Re: [PATCH 1/2] dma-mapping: remove bogus test for pfn_valid from dma_map_resource Message-ID: <20210930054637.GA22287@lst.de> References: <20210930013039.11260-1-rppt@kernel.org> <20210930013039.11260-2-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210930013039.11260-2-rppt@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Will Deacon , Anshuman Khandual , Catalin Marinas , David Hildenbrand , Alex Bee , Linux Kernel Mailing List , iommu@lists.linux-foundation.org, Andrew Morton , Mike Rapoport , Robin Murphy , Christoph Hellwig , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Sep 30, 2021 at 04:30:38AM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > dma_map_resource() uses pfn_valid() to ensure the range is not RAM. > However, pfn_valid() only checks for availability of the memory map for a > PFN but it does not ensure that the PFN is actually backed by RAM. > > As dma_map_resource() is the only method in DMA mapping APIs that has this > check, simply drop the pfn_valid() test from dma_map_resource(). > > Link: https://lore.kernel.org/all/20210824173741.GC623@arm.com/ > Signed-off-by: Mike Rapoport We'll lose a bit of a sanity check with this, but given the problems it caused: Reviewed-by: Christoph Hellwig _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CE0CC433EF for ; Thu, 30 Sep 2021 05:49:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3738061265 for ; Thu, 30 Sep 2021 05:49:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3738061265 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ULolzHrpYNejWkxNm6yV/FyTAKzeSnT7XvaSjO5VMnE=; b=BgMa/1QTe5iuyA TtIWWkH9F5HvBA8oJBkAEh6VHK3+FOuMP7iXsKJYX8btegc/2mGA6WilaKP4a0BwP0FmFmbVuZges 28MQ8s1msIV0CSl6S/7mE4AhYZQQQ5KpDPArh+QtJiUgP2qDfcHmYZoqHgjkGXO8ANe2nrItk8DVe 1QEVgZ1oZSbVdwAKquGc5nd9TwWWPPSQmLfOCMvq74wSSb+R+uT1yz07FWPQBtWu1sH1WpzW6UISS 7OL+PuThxw/35aXY06nGi6ijTE1LPspVqjlWxWj1lm72zQwrA9nzEL8kmI6tzT2zEi6Af8v6oBhTA X3Q2Vm2i8z4WLAEFj/8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVou5-00D2NZ-8G; Thu, 30 Sep 2021 05:46:45 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVou1-00D2N4-KK for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 05:46:43 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3107468AFE; Thu, 30 Sep 2021 07:46:38 +0200 (CEST) Date: Thu, 30 Sep 2021 07:46:37 +0200 From: Christoph Hellwig To: Mike Rapoport Cc: linux-arm-kernel@lists.infradead.org, Alex Bee , Andrew Morton , Anshuman Khandual , Catalin Marinas , Christoph Hellwig , David Hildenbrand , Linux Kernel Mailing List , Marek Szyprowski , Mike Rapoport , Robin Murphy , Will Deacon , iommu@lists.linux-foundation.org Subject: Re: [PATCH 1/2] dma-mapping: remove bogus test for pfn_valid from dma_map_resource Message-ID: <20210930054637.GA22287@lst.de> References: <20210930013039.11260-1-rppt@kernel.org> <20210930013039.11260-2-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210930013039.11260-2-rppt@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_224641_862548_A252CC7F X-CRM114-Status: GOOD ( 17.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 30, 2021 at 04:30:38AM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > dma_map_resource() uses pfn_valid() to ensure the range is not RAM. > However, pfn_valid() only checks for availability of the memory map for a > PFN but it does not ensure that the PFN is actually backed by RAM. > > As dma_map_resource() is the only method in DMA mapping APIs that has this > check, simply drop the pfn_valid() test from dma_map_resource(). > > Link: https://lore.kernel.org/all/20210824173741.GC623@arm.com/ > Signed-off-by: Mike Rapoport We'll lose a bit of a sanity check with this, but given the problems it caused: Reviewed-by: Christoph Hellwig _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55609C433F5 for ; Thu, 30 Sep 2021 05:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AF2261263 for ; Thu, 30 Sep 2021 05:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348150AbhI3FsY (ORCPT ); Thu, 30 Sep 2021 01:48:24 -0400 Received: from verein.lst.de ([213.95.11.211]:58224 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348126AbhI3FsX (ORCPT ); Thu, 30 Sep 2021 01:48:23 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 3107468AFE; Thu, 30 Sep 2021 07:46:38 +0200 (CEST) Date: Thu, 30 Sep 2021 07:46:37 +0200 From: Christoph Hellwig To: Mike Rapoport Cc: linux-arm-kernel@lists.infradead.org, Alex Bee , Andrew Morton , Anshuman Khandual , Catalin Marinas , Christoph Hellwig , David Hildenbrand , Linux Kernel Mailing List , Marek Szyprowski , Mike Rapoport , Robin Murphy , Will Deacon , iommu@lists.linux-foundation.org Subject: Re: [PATCH 1/2] dma-mapping: remove bogus test for pfn_valid from dma_map_resource Message-ID: <20210930054637.GA22287@lst.de> References: <20210930013039.11260-1-rppt@kernel.org> <20210930013039.11260-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210930013039.11260-2-rppt@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 30, 2021 at 04:30:38AM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > dma_map_resource() uses pfn_valid() to ensure the range is not RAM. > However, pfn_valid() only checks for availability of the memory map for a > PFN but it does not ensure that the PFN is actually backed by RAM. > > As dma_map_resource() is the only method in DMA mapping APIs that has this > check, simply drop the pfn_valid() test from dma_map_resource(). > > Link: https://lore.kernel.org/all/20210824173741.GC623@arm.com/ > Signed-off-by: Mike Rapoport We'll lose a bit of a sanity check with this, but given the problems it caused: Reviewed-by: Christoph Hellwig