All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Alexander Popov <alex.popov@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Paul McKenney <paulmck@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Joerg Roedel <jroedel@suse.de>,
	Maciej Rozycki <macro@orcam.me.uk>,
	Muchun Song <songmuchun@bytedance.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Petr Mladek <pmladek@suse.com>,
	Luis Chamberlain <mcgrof@kernel.org>, Wei Liu <wl@xen.org>,
	John Ogness <john.ogness@linutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Jann Horn <jannh@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andy Lutomirski <luto@kernel.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Will Deacon <will.deacon@arm.com>,
	David S Miller <davem@davemloft.net>,
	Borislav Petkov <bp@alien8.de>,
	kernel-hardening@lists.openwall.com,
	linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, notify@kernel.org
Subject: Re: [PATCH] Introduce the pkill_on_warn boot parameter
Date: Thu, 30 Sep 2021 11:36:26 -0700	[thread overview]
Message-ID: <202109301132.E29DB764E8@keescook> (raw)
In-Reply-To: <de96ffec-bbd8-2724-9285-0867cd9a08a0@linux.com>

On Thu, Sep 30, 2021 at 09:27:43PM +0300, Alexander Popov wrote:
> On 30.09.2021 02:31, Andrew Morton wrote:
> > On Wed, 29 Sep 2021 22:01:33 +0300 Alexander Popov <alex.popov@linux.com> wrote:
> > 
> >> On 29.09.2021 21:58, Alexander Popov wrote:
> >> [...]
> >> If you are fine with this approach, I will prepare a patch adding the
> >> pkill_on_warn sysctl.
> > 
> > Why do we need a boot parameter?  Isn't a sysctl all we need for this
> > feature? 
> 
> I would say we need both sysctl and boot parameter for pkill_on_warn.
> That would be consistent with panic_on_warn, ftrace_dump_on_oops and
> oops/panic_on_oops.

If you want to change it at runtime, just make a sysctl: it will
be available as a bootparam since v5.8. See commit 3db978d480e2
("kernel/sysctl: support setting sysctl parameters from kernel command
line")

-- 
Kees Cook

  reply	other threads:[~2021-09-30 18:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 18:58 [PATCH] Introduce the pkill_on_warn boot parameter Alexander Popov
2021-09-29 19:01 ` Alexander Popov
2021-09-29 19:49   ` Paul E. McKenney
2021-09-30  9:15     ` Petr Mladek
2021-09-30 15:05       ` Alexander Popov
2021-10-01 12:23         ` Petr Mladek
2021-09-30 16:59       ` Steven Rostedt
2021-10-01 12:09         ` Petr Mladek
2021-09-30 18:28       ` Kees Cook
2021-10-01 19:59       ` Linus Torvalds
2021-10-02 11:41         ` Alexander Popov
2021-10-02 12:13           ` Steven Rostedt
2021-10-02 16:33             ` Alexander Popov
2021-10-02 16:52           ` Linus Torvalds
2021-10-02 21:05             ` Alexander Popov
2021-10-05 19:48               ` Eric W. Biederman
2021-10-06 14:56                 ` Alexander Popov
2021-10-22 17:30                 ` Alexander Popov
2022-07-27 16:17         ` Alexey Khoroshilov
2022-07-27 16:30           ` Jann Horn
2022-07-27 16:43             ` Alexey Khoroshilov
2022-07-27 16:42           ` Linus Torvalds
2022-07-27 17:47             ` Alexey Khoroshilov
2021-09-29 23:31   ` Andrew Morton
2021-09-30 18:27     ` Alexander Popov
2021-09-30 18:36       ` Kees Cook [this message]
2021-09-29 19:03 ` Dave Hansen
2021-09-29 19:47   ` Peter Zijlstra
2021-09-29 20:06   ` Kees Cook
2021-09-30 13:55     ` Alexander Popov
2021-09-30 18:20       ` Kees Cook
2021-10-02 18:04 ` Al Viro
2021-10-02 18:31   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202109301132.E29DB764E8@keescook \
    --to=keescook@chromium.org \
    --cc=aik@ozlabs.ru \
    --cc=akpm@linux-foundation.org \
    --cc=alex.popov@linux.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jannh@google.com \
    --cc=john.ogness@linutronix.de \
    --cc=jroedel@suse.de \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=mark.rutland@arm.com \
    --cc=mcgrof@kernel.org \
    --cc=notify@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rdunlap@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=rostedt@goodmis.org \
    --cc=songmuchun@bytedance.com \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    --cc=will.deacon@arm.com \
    --cc=wl@xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.