From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Thomas Perrot <thomas.perrot@bootlin.com>
Cc: Aleksander Morgado <aleksander@aleksander.es>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
hemantk@codeaurora.org, Loic Poulain <loic.poulain@linaro.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] bus: mhi: pci_generic: increase timeout value for operations to 24000ms
Date: Fri, 1 Oct 2021 13:06:59 +0530 [thread overview]
Message-ID: <20211001073659.GC5821@thinkpad> (raw)
In-Reply-To: <54c063613fe63282a1c26b312c772e89b662eae6.camel@bootlin.com>
On Thu, Sep 30, 2021 at 10:07:57AM +0200, Thomas Perrot wrote:
> Hello,
>
[...]
> I made experimentation on a Sierra EM9190 (SDX55) engineering sample,
> using a old development firmware.
>
> So, I agree that setting the same timeout of 24000ms for all modems, is
> not necessarily relevant.
> However, the current default value seems too low, in view of timeouts
> used on vendor-branded, then using a higher value seems relevant.
>
> Moreover, Sierra EM919x modems use a custom controller configuration,
> we are currently working on it. As our tests not being sufficiently
> conclusive, so we have not yet submitted.
>
Okay. Then please add a separate config for this device when you have it. It
makes more sense to have the longer timeout only for devices that need it.
Thanks,
Mani
> Best regards,
> Thomas
>
> > >
> > > It was derived from testing I believe.
> >
> > Following your reasoning above, shouldn't this 24000ms timeout be
> > applied only to the Sierra Wireless EM91xx devices (which may have
> > custom firmware bits delaying the initialization a bit longer), and
> > not to the generic SDX24, SDX55 and SDX65?
> >
> > If I'm not mistaken, Thomas is testing with a custom mhi_pci_generic
> > entry for the EM91xx; as in
> > https://forum.sierrawireless.com/t/sierra-wireless-airprime-em919x-pcie-support/24927
> > .
> > I'm also playing with that same entry on my own setup, but have other
> > problems of my own :)
> >
> >
> > --
> > Aleksander
> > https://aleksander.es
>
> --
> Thomas Perrot, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
>
next prev parent reply other threads:[~2021-10-01 7:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 14:02 [PATCH] bus: mhi: pci_generic: increase timeout value for operations to 24000ms Thomas Perrot
2021-08-05 14:30 ` Loic Poulain
2021-08-16 4:22 ` Manivannan Sadhasivam
2021-09-28 20:11 ` Thomas Perrot
2021-09-29 11:58 ` Manivannan Sadhasivam
2021-09-29 9:37 ` Aleksander Morgado
2021-09-29 12:04 ` Manivannan Sadhasivam
2021-09-29 13:17 ` Aleksander Morgado
2021-09-30 8:07 ` Thomas Perrot
2021-09-30 10:19 ` Loic Poulain
2021-10-01 7:38 ` Manivannan Sadhasivam
2021-10-01 7:36 ` Manivannan Sadhasivam [this message]
2021-10-01 7:35 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211001073659.GC5821@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=aleksander@aleksander.es \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=stable@vger.kernel.org \
--cc=thomas.perrot@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.