From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DD5C433F5 for ; Fri, 1 Oct 2021 12:59:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBEC261ABD for ; Fri, 1 Oct 2021 12:59:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EBEC261ABD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CDE4C8128D; Fri, 1 Oct 2021 14:59:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="SMldD+vX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 79D83815A8; Fri, 1 Oct 2021 14:59:39 +0200 (CEST) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B53ED80C83 for ; Fri, 1 Oct 2021 14:59:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id jo30so5475578qvb.3 for ; Fri, 01 Oct 2021 05:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ymx51Z/bK/Z2o+PCGaR1Mv7cWgSc8eyM+usA9Z0E/Dw=; b=SMldD+vXW2ahYxoL21Eo+v3aF3g94RZGjkux8mxzN3wZQEUFmxkIblirqFH3T+Oi7I ytwgOp6a+HC588VoiHTdJoPrvsFVnVR0M/bVshDAe52U/qu3aBlfhyzviSYlHF6KCgKS yXepzuf6a753mgqJ5hZ6sOQtXmdc+h6DgT0mE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ymx51Z/bK/Z2o+PCGaR1Mv7cWgSc8eyM+usA9Z0E/Dw=; b=DsPeLrUDIYpRbf0AdqCHxtVwgwOx01Hfa9pHbiEQkkCPBJ9091nrQJvUJ/2ywbiYve 7352t0vZnARx/YSC4YmzAapmX3uIGpaIm5/iwi8vpf2vqU5/a8I/Tti6SZ/WT2nMYjIj Qq5IJXJ4Bmc6nPxrE6MllfgFF16LZTiiGB6sT8DyTarnQopsVvlUElXmg2Y77rf3QB4Z lI30e6XUsr7LaewSrPHLtySgbQr96SFzTlmdVzATgGARBEWS8LIlJaRpCsEi5ZXRuxq4 wipZ+dxq3KQHyM2OlcyayV6fczqUVBlXLjHAQsJmCIzSlF8gRK2yu9EPOGjHw6QYznqe LTHg== X-Gm-Message-State: AOAM530IB0jRkmBg4jR6gg8vhnty4nK8Jw4Sh/S06QvhhHUeegVxlLNb ym0N9QjQXHdbutKPUYpGgGlOiw== X-Google-Smtp-Source: ABdhPJyIXNRSru4C4h0jpNvqDde7sUlqf3YxyegES3y0k5ATn9/mwAvDpnX7Byz26CH5nLHidfFN+A== X-Received: by 2002:ad4:4307:: with SMTP id c7mr8761121qvs.37.1633093174333; Fri, 01 Oct 2021 05:59:34 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-545f-08ff-1a69-4a55.res6.spectrum.com. [2603:6081:7b01:cbda:545f:8ff:1a69:4a55]) by smtp.gmail.com with ESMTPSA id o21sm3265834qtq.43.2021.10.01.05.59.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Oct 2021 05:59:33 -0700 (PDT) Date: Fri, 1 Oct 2021 08:59:31 -0400 From: Tom Rini To: Stefan Roese Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de, Chris Packham , Baruch Siach , Dennis Gilmore , Mario Six , Jon Nettleton , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH u-boot-marvell v3 00/39] kwboot higher baudrate Message-ID: <20211001125931.GE31748@bill-the-cat> References: <20210924210716.29752-1-kabel@kernel.org> <20210930181419.ylymgidnzzifpz2x@pali> <4dc716e5-3d86-1b81-d761-08713a824f6d@denx.de> <20211001092856.gpagytudmfu45oht@pali> <20211001100904.n6njnf7bdfrqym2h@pali> <39d82d32-0cdb-7a27-a328-d5aa312a746a@denx.de> <20211001103919.2nk5rauti7ckh6fm@pali> <220b95d3-fdb1-f196-fa38-498e2bebfed6@denx.de> <1a8001a3-2336-9278-8b8f-e0b8152d4a9b@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dPBkOKX5O0RACqf+" Content-Disposition: inline In-Reply-To: <1a8001a3-2336-9278-8b8f-e0b8152d4a9b@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --dPBkOKX5O0RACqf+ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 01, 2021 at 01:01:37PM +0200, Stefan Roese wrote: > Added to Tom to Cc >=20 > On 01.10.21 12:43, Stefan Roese wrote: > > On 01.10.21 12:39, Pali Roh=E1r wrote: > > > Hello! > > >=20 > > > On Friday 01 October 2021 12:28:34 Stefan Roese wrote: > > > > First the test on "next" without the 39 patches: > > > >=20 > > > > [stefan@ryzen u-boot (next)]$ ./tools/kwboot -p -b u-boot-spl.kwb -t > > > ... > > > > DDR3 Training Sequence - Ended Successfully > > > > Trying to boot from BOOTROM > > > > Returning to BootROM (return address 0xffff0aa0)... > > > > +xmodem: Protocol error > > > >=20 > > > >=20 > > > > Not working! > > > >=20 > > > > And now test on "master" without the 39 patches: > > > >=20 > > > > [stefan@ryzen u-boot (master)]$ ./tools/kwboot -p -b u-boot-spl.kwb= -t > > > ... > > > >=20 > > > > Seems to okay. > > > >=20 > > > > Thanks, > > > > Stefan > > >=20 > > > So something is broken in next branch. I have looked at kwboot and > > > kwbimage code and there is no change in next branch which is not in > > > master branch. > > >=20 > > > So it looks like that something not related to kwboot broke it in next > > > branch. And seems that git bisect on AXP hw would be required. But I = do > > > not own AXP board, so I cannot do it. > >=20 > > I can try to do this here later, if I find the time. >=20 > git bisect leads to this problematic commit: >=20 > [stefan@ryzen u-boot ((ab92b38a0161...)|BISECTING)]$ git bisect good > a2ac2b964bfbb20d6791ee94b9034a50cfadb5b0 is the first bad commit > commit a2ac2b964bfbb20d6791ee94b9034a50cfadb5b0 > Author: Tom Rini > Date: Fri Aug 27 21:18:30 2021 -0400 >=20 > Convert CONFIG_SKIP_LOWLEVEL_INIT et al to Kconfig >=20 > This converts the following to Kconfig: > CONFIG_SKIP_LOWLEVEL_INIT > CONFIG_SKIP_LOWLEVEL_INIT_ONLY >=20 > In order to do this, we need to introduce SPL and TPL variants of the= se > options so that we can clearly disable these options only in SPL in s= ome > cases, and both instances in other cases. >=20 > Signed-off-by: Tom Rini >=20 >=20 > Frankly, I did not analyse this change fully. But it seems to > responsible for this breakage on Armada XP in "next". OK, I guess the conversion from arch/arm/mach-mvebu/include/mach/config.h didn't work right. These boards should have set CONFIG_SPL_SKIP_LOWLEVEL_INIT but don't. Why it was missed, well, I can't spot the magic to include if it exists, but I just missed that, so I'll need to make sure to take more care on the tricky conversions that also use mach/config.h. Let me know if you need me to re-convert platforms here, or now that you know what's missing you can fix it, thanks! --=20 Tom --dPBkOKX5O0RACqf+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFXBjAACgkQFHw5/5Y0 tyw9nQwAnW07BFZyp0GB2KIuCcYYv2FnjrwWJXtuyxOK1ux8R17O9OESx/gsJSlT RZC9MIceWrncgngvTrFuHmnAvOMzOcz831XzSt+m9liLEz3b35t2ig4OC9267WEM WSN3fOej3/Y+xRkpQ9ndTfTQX1fSNhqzmS9ysOLMIpAvauIp95c+eDFHlmMoG1lO mcX2pGFfBOwUnKu3vNXeAZGmLFZpduRDqys7suBykxHEgi554Z/W7Ki9mVKYAhv6 acRDF4QQPaqciBTMgwGHixadd517h6X9u3HB4hF9hLi3JNoOzkVgAypV+nxsGzhk QV4b6YVxbi03vKORNWQruTmIO1PfX3jmvYazfSSaMiEHC8e2TOckDZ/w08pfZ0qw jT3EH+jrIoxdwE+8l3Umn36/Fq5TtsgZgeRF0llPk8Rd+WPpS0rEhm4zKbYMl8w3 DXVVXP1BdbsPwulm0FFmNPpucatD61XBZwhGYSXUZxrvC/s8wyxiR+C4tpm9bsxZ 1CU869SO =AWyh -----END PGP SIGNATURE----- --dPBkOKX5O0RACqf+--