All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Kamel Bouhara <kamel.bouhara@bootlin.com>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 5/7] package/sunxi-mali-mainline: provides libgbm
Date: Fri, 1 Oct 2021 16:16:36 +0200	[thread overview]
Message-ID: <20211001161636.4b0e6c65@windsurf> (raw)
In-Reply-To: <20210928223754.3398867-5-kamel.bouhara@bootlin.com>

On Wed, 29 Sep 2021 00:37:52 +0200
Kamel Bouhara <kamel.bouhara@bootlin.com> wrote:

> Registers the package as a libgbm provider.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> ---
> Changes v1 -> v2:
>  - Fixed gbm features are provided only when wayland is set
> 
>  package/sunxi-mali-mainline/Config.in              |  6 ++++++
>  package/sunxi-mali-mainline/gbm.pc                 | 12 ++++++++++++
>  package/sunxi-mali-mainline/sunxi-mali-mainline.mk |  1 +
>  3 files changed, 19 insertions(+)
>  create mode 100644 package/sunxi-mali-mainline/gbm.pc
> 
> diff --git a/package/sunxi-mali-mainline/Config.in b/package/sunxi-mali-mainline/Config.in
> index 31a9152407..0a32cb456c 100644
> --- a/package/sunxi-mali-mainline/Config.in
> +++ b/package/sunxi-mali-mainline/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_SUNXI_MALI_MAINLINE
>  	depends on BR2_aarch64 || (BR2_ARM_EABIHF && BR2_arm)
>  	depends on BR2_TOOLCHAIN_USES_GLIBC
>  	select BR2_PACKAGE_HAS_LIBEGL
> +	select BR2_PACKAGE_HAS_LIBGBM
>  	select BR2_PACKAGE_HAS_LIBGLES
>  	help
>  	  Install userspace Allwinner OpenGL libraries.
> @@ -14,6 +15,9 @@ if BR2_PACKAGE_SUNXI_MALI_MAINLINE
>  config BR2_PACKAGE_PROVIDES_LIBEGL
>  	default "sunxi-mali-mainline"
>  
> +config BR2_PACKAGE_PROVIDES_LIBGBM
> +	default "sunxi-mali-mainline" if BR2_PACKAGE_SUNXI_MALI_MAINLINE_OUTPUT_WAYLAND
> +
>  config BR2_PACKAGE_PROVIDES_LIBGLES
>  	default "sunxi-mali-mainline"
>  
> @@ -26,6 +30,8 @@ config BR2_PACKAGE_SUNXI_MALI_MAINLINE_OUTPUT_FBDEV
>  config BR2_PACKAGE_SUNXI_MALI_MAINLINE_OUTPUT_WAYLAND
>  	bool "wayland"
>  	depends on BR2_PACKAGE_WAYLAND
> +	select BR2_PACKAGE_LIBGBM_HAS_FEATURE_DMA_BUF
> +	select BR2_PACKAGE_HAS_LIBGBM

It still doesn't make sense: you're selecting BR2_PACKAGE_HAS_LIBGBM
both in the main package option and here.

So either libgbm is only provided by the wayland-variant of the
sunxi-mali-mainline OpenGL implementation, or it's provided by all. But
having the "select BR2_PACKAGE_HAS_LIBGBM" in two places doesn't make
sense.

>  ifeq ($(BR2_PACKAGE_SUNXI_MALI_MAINLINE_OUTPUT_WAYLAND),y)
>  SUNXI_MALI_MAINLINE_DEPENDENCIES += wayland
> +SUNXI_MALI_MAINLINE_PROVIDES += libgbm
>  endif

According to this, it's only the wayland-variant that supports libgbm.
So the "select BR2_PACKAGE_HAS_LIBGBM" in
BR2_PACKAGE_SUNXI_MALI_MAINLINE is wrong. I think this was already
pointed out in the review of v1.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-10-01 14:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 22:37 [Buildroot] [PATCH v2 1/7] package/opengl/libgbm: new virtual package Kamel Bouhara
2021-09-28 22:37 ` [Buildroot] [PATCH v2 2/7] package/mesa3d: add gbm api features Kamel Bouhara
2021-09-28 22:37 ` [Buildroot] [PATCH v2 3/7] package/sunxi-mali-mainline: bump version Kamel Bouhara
2021-09-28 22:37 ` [Buildroot] [PATCH v2 4/7] package/sunxi-mali-mainline: add support for different outputs Kamel Bouhara
2021-10-01 14:14   ` Thomas Petazzoni
2021-09-28 22:37 ` [Buildroot] [PATCH v2 5/7] package/sunxi-mali-mainline: provides libgbm Kamel Bouhara
2021-10-01 14:16   ` Thomas Petazzoni [this message]
2021-09-28 22:37 ` [Buildroot] [PATCH v2 6/7] package/kmscube: use libgbm virtual package Kamel Bouhara
2021-10-01 14:18   ` Thomas Petazzoni
2021-09-28 22:37 ` [Buildroot] [PATCH v2 7/7] package/gcnano-binaries: provides libgbm Kamel Bouhara
2021-10-01 14:13 ` [Buildroot] [PATCH v2 1/7] package/opengl/libgbm: new virtual package Thomas Petazzoni
2021-10-07  9:35   ` Kamel Bouhara
2021-10-08 12:40     ` Thomas Petazzoni
     [not found]       ` <YWA98UOCDjOFh51v@aptenodytes>
2021-10-08 13:10         ` Thomas Petazzoni
2021-10-03 21:05 ` Yann E. MORIN
2021-10-07 10:00   ` Kamel Bouhara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001161636.4b0e6c65@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=kamel.bouhara@bootlin.com \
    --cc=paul.kocialkowski@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.