Re: [PATCH 2/5] vfio: Do not open code the group list search in vfio_create_group()

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5423 bytes --]

Hi Jason,

I love your patch! Perhaps something to improve:

[auto build test WARNING on d9a0cd510c3383b61db6f70a84e0c3487f836a63]

url:    https://github.com/0day-ci/linux/commits/Jason-Gunthorpe/Update-vfio_group-to-use-the-modern-cdev-lifecycle/20211002-072315
base:   d9a0cd510c3383b61db6f70a84e0c3487f836a63
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/863433fdbdd6ce5de9dcd683278f3bbfa34b1d0c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jason-Gunthorpe/Update-vfio_group-to-use-the-modern-cdev-lifecycle/20211002-072315
        git checkout 863433fdbdd6ce5de9dcd683278f3bbfa34b1d0c
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/vfio/vfio.c:236: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * IOMMU driver registration
   drivers/vfio/vfio.c:288: warning: Function parameter or member 'group' not described in 'vfio_alloc_group_minor'
   drivers/vfio/vfio.c:288: warning: expecting prototype for Group minor allocation/free(). Prototype was for vfio_alloc_group_minor() instead
   drivers/vfio/vfio.c:308: warning: Function parameter or member 'container' not described in 'vfio_container_get'
   drivers/vfio/vfio.c:308: warning: expecting prototype for Container objects(). Prototype was for vfio_container_get() instead
   drivers/vfio/vfio.c:349: warning: Function parameter or member 'iommu_group' not described in '__vfio_group_get_from_iommu'
>> drivers/vfio/vfio.c:349: warning: expecting prototype for Group objects(). Prototype was for __vfio_group_get_from_iommu() instead
   drivers/vfio/vfio.c:502: warning: Function parameter or member 'device' not described in 'vfio_device_put'
   drivers/vfio/vfio.c:502: warning: expecting prototype for Device objects(). Prototype was for vfio_device_put() instead
   drivers/vfio/vfio.c:605: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Async device support
   drivers/vfio/vfio.c:699: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * VFIO driver API
   drivers/vfio/vfio.c:848: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Get a reference to the vfio_device for a device.  Even if the
   drivers/vfio/vfio.c:982: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * VFIO base fd, /dev/vfio/vfio
   drivers/vfio/vfio.c:1200: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * VFIO Group fd, /dev/vfio/$GROUP
   drivers/vfio/vfio.c:1552: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * VFIO Device fd
   drivers/vfio/vfio.c:1627: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * External user API, exported by symbols to be linked dynamically.
   drivers/vfio/vfio.c:1672: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * External user API, exported by symbols to be linked dynamically.
   drivers/vfio/vfio.c:1751: warning: Function parameter or member 'caps' not described in 'vfio_info_cap_add'
   drivers/vfio/vfio.c:1751: warning: Function parameter or member 'size' not described in 'vfio_info_cap_add'
   drivers/vfio/vfio.c:1751: warning: Function parameter or member 'id' not described in 'vfio_info_cap_add'
   drivers/vfio/vfio.c:1751: warning: Function parameter or member 'version' not described in 'vfio_info_cap_add'
   drivers/vfio/vfio.c:1751: warning: expecting prototype for Sub(). Prototype was for vfio_info_cap_add() instead
   drivers/vfio/vfio.c:2285: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Module/class support


vim +349 drivers/vfio/vfio.c

   343	
   344	/**
   345	 * Group objects - create, release, get, put, search
   346	 */
   347	static struct vfio_group *
   348	__vfio_group_get_from_iommu(struct iommu_group *iommu_group)
 > 349	{
   350		struct vfio_group *group;
   351	
   352		list_for_each_entry(group, &vfio.group_list, vfio_next) {
   353			if (group->iommu_group == iommu_group) {
   354				vfio_group_get(group);
   355				return group;
   356			}
   357		}
   358		return NULL;
   359	}
   360	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74076 bytes --]