All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/lua-augeas: new package
Date: Mon, 4 Oct 2021 10:14:02 +0200	[thread overview]
Message-ID: <20211004101402.485b8670@bootlin.com> (raw)
In-Reply-To: <6dcfa41a-d847-1774-53af-111faaf561ee@mind.be>

Hi,

On Sun, 3 Oct 2021 12:30:08 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:

[...]
> > I can change to "select" here if you prefer.  
> 
>   Yes, select is preferred. I don't know why it was not done like that for 
> python-augeas.

Will be changed to 'select' in v2

> 
> [snip]
> > If this makes sense, I can add the following comment in v2:
> >    LDFLAGS=$(LDFLAGS) is present to pass LDFLAGS from environment
> >    to command line.
> >    With LDFLAGS in command line, related ordinary asignment present
> >    in the makefile are ignored and so lua-augeas makefile cannot not
> >    add '-L/lib' to this value.  
> 
>   Yes please add that comment. It can be in the commit message or in the .mk 
> file, up to you.

Comment will be added in .mk in v2

Thanks for the review.

Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2021-10-04  8:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 12:53 [Buildroot] [PATCH 1/1] package/lua-augeas: new package Herve Codina
2021-10-01 13:26 ` Thomas Petazzoni
2021-10-01 16:35   ` Herve Codina
2021-10-03 10:30     ` Arnout Vandecappelle
2021-10-04  8:14       ` Herve Codina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211004101402.485b8670@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.