From: Wayne Lin <Wayne.Lin@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <alexander.deucher@amd.com>, <Harry.Wentland@amd.com>,
<nicholas.kazlauskas@amd.com>, <Rodrigo.Siqueira@amd.com>,
<wayne.lin@amd.com>, <stylon.wang@amd.com>, <jude.shih@amd.com>,
<jimmy.kizito@amd.com>, <meenakshikumar.somasundaram@amd.com>,
Jimmy Kizito <Jimmy.Kizito@amd.com>, Jun Lei <Jun.Lei@amd.com>,
Wayne Lin <Wayne.Lin@amd.com>
Subject: [PATCH 07/23] drm/amd/display: Update training parameters for DPIA links
Date: Mon, 4 Oct 2021 22:40:34 +0800 [thread overview]
Message-ID: <20211004144050.3425351-8-Wayne.Lin@amd.com> (raw)
In-Reply-To: <20211004144050.3425351-1-Wayne.Lin@amd.com>
From: Jimmy Kizito <Jimmy.Kizito@amd.com>
[why & how]
Add codes for commit "ede4f6dac99e drm/amd/display: Update
setting of DP training parameters." to support USB4 DP tunneling
feature
Reviewed-by: Jun Lei <Jun.Lei@amd.com>
Acked-by: Wayne Lin <Wayne.Lin@amd.com>
Acked-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Jimmy Kizito <Jimmy.Kizito@amd.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 9bc5f49ea2ec..dd1d0262ba40 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -1777,6 +1777,13 @@ static enum dc_status configure_lttpr_mode_non_transparent(
if (encoding == DP_8b_10b_ENCODING) {
repeater_cnt = dp_convert_to_count(link->dpcd_caps.lttpr_caps.phy_repeater_cnt);
+
+ /* Driver does not need to train the first hop. Skip DPCD read and clear
+ * AUX_RD_INTERVAL for DPTX-to-DPIA hop.
+ */
+ if (link->ep_type == DISPLAY_ENDPOINT_USB4_DPIA)
+ link->dpcd_caps.lttpr_caps.aux_rd_interval[--repeater_cnt] = 0;
+
for (repeater_id = repeater_cnt; repeater_id > 0; repeater_id--) {
aux_interval_address = DP_TRAINING_AUX_RD_INTERVAL_PHY_REPEATER1 +
((DP_REPEATER_CONFIGURATION_AND_STATUS_SIZE) * (repeater_id - 1));
--
2.25.1
next prev parent reply other threads:[~2021-10-04 14:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 14:40 [PATCH 00/23] USB4 DP tunneling Wayne Lin
2021-10-04 14:40 ` [PATCH 01/23] drm/amd/display: Update link encoder object creation Wayne Lin
2021-10-04 14:40 ` [PATCH 02/23] drm/amd/display: USB4 DPIA enumeration and AUX Tunneling Wayne Lin
2021-10-04 14:40 ` [PATCH 03/23] drm/amd/display: Support for DMUB HPD and HPD RX interrupt handling Wayne Lin
2021-10-04 14:40 ` [PATCH 04/23] drm/amd/display: Support USB4 dynamic link encoder selection Wayne Lin
2021-10-04 14:40 ` [PATCH 05/23] drm/amd/display: Support USB4 for display endpoint control path Wayne Lin
2021-10-04 14:40 ` [PATCH 06/23] drm/amd/display: Support DP tunneling when DPRX detection Wayne Lin
2021-10-04 14:40 ` Wayne Lin [this message]
2021-10-04 14:40 ` [PATCH 08/23] drm/amd/display: Support USB4 when DP link training Wayne Lin
2021-10-04 14:40 ` [PATCH 09/23] drm/amd/display: Implement DPIA training loop Wayne Lin
2021-10-04 14:40 ` [PATCH 10/23] drm/amd/display: Implement DPIA link configuration Wayne Lin
2021-10-04 14:40 ` [PATCH 11/23] drm/amd/display: Implement DPIA clock recovery phase Wayne Lin
2021-10-04 14:40 ` [PATCH 12/23] drm/amd/display: Implement DPIA equalisation phase Wayne Lin
2021-10-04 14:40 ` [PATCH 13/23] drm/amd/display: Implement end of training for hop in DPIA display path Wayne Lin
2021-10-04 14:40 ` [PATCH 14/23] drm/amd/display: Support for SET_CONFIG processing with DMUB Wayne Lin
2021-10-04 14:40 ` [PATCH 15/23] drm/amd/display: Read USB4 DP tunneling data from DPCD Wayne Lin
2021-10-04 14:40 ` [PATCH 16/23] drm/amd/display: Add dpia debug options Wayne Lin
2021-10-04 14:40 ` [PATCH 17/23] drm/amd/display: Support for SET_CONFIG processing with DMUB Wayne Lin
2021-10-04 14:40 ` [PATCH 18/23] drm/amd/display: Fix DIG_HPD_SELECT for USB4 display endpoints Wayne Lin
2021-10-04 14:40 ` [PATCH 19/23] drm/amd/display: Add debug flags for USB4 DP link training Wayne Lin
2021-10-04 14:40 ` [PATCH 20/23] drm/amd/display: Fix for access for ddc pin and aux engine Wayne Lin
2021-10-04 14:40 ` [PATCH 21/23] drm/amd/display: Deadlock/HPD Status/Crash Bug Fix Wayne Lin
2021-10-04 14:40 ` [PATCH 22/23] drm/amd/display: Fix USB4 Aux via DMUB terminate unexpectedly Wayne Lin
2021-10-04 14:40 ` [PATCH 23/23] drm/amd/display: USB4 bring up set correct address Wayne Lin
2021-10-04 14:48 ` [PATCH 00/23] USB4 DP tunneling Harry Wentland
2021-10-05 6:30 ` Lin, Wayne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004144050.3425351-8-Wayne.Lin@amd.com \
--to=wayne.lin@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=jimmy.kizito@amd.com \
--cc=jude.shih@amd.com \
--cc=meenakshikumar.somasundaram@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=stylon.wang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.