From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jinpu Wang <jinpu.wang@ionos.com>
Cc: Leon Romanovsky <leon@kernel.org>, Jack Wang <xjtuwjp@gmail.com>,
Md Haris Iqbal <haris.iqbal@ionos.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Doug Ledford <dledford@redhat.com>,
Gioh Kim <gi-oh.kim@ionos.com>,
Aleksei Marov <aleksei.marov@ionos.com>
Subject: Re: [PATCH for-next 6/7] RDMA/rtrs: Do not allow sessname to contain special symbols / and .
Date: Mon, 4 Oct 2021 15:47:18 -0300 [thread overview]
Message-ID: <20211004184718.GD3544071@ziepe.ca> (raw)
In-Reply-To: <CAMGffEk4PJGkL3fufgKGUCmKDUqYOTFgKPisda0OeMN1hTk-iA@mail.gmail.com>
On Mon, Oct 04, 2021 at 07:41:08AM +0200, Jinpu Wang wrote:
> Sorry, I'm really not convinced, why should we only do allowing, not
> disabling in this case?
>
> Jason, what's your suggestion?
At least from a correctness perspective only the characters / and \0
are forbidden, as well as any existing filenames like . and ..
Generally it is not a great idea to restrict things too much because
it can block the full use of UTF-8 for non-English languages.
However, I also think the sysfs in this driver is far too elaborate,
the time to complain was before this was all merged
unfortunately. Given that it is a simple enough bug fix it may as well
go ahead as-is.
Jason
next prev parent reply other threads:[~2021-10-04 18:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 12:53 [PATCH for-next 0/7] Misc update for RTRS Md Haris Iqbal
2021-09-22 12:53 ` [PATCH for-next 1/7] RDMA/rtrs: Use sysfs_emit instead of s*printf function for sysfs show Md Haris Iqbal
2021-09-22 12:53 ` [PATCH for-next 2/7] RDMA/rtrs: Remove len parameter from helper print functions of sysfs Md Haris Iqbal
2021-09-22 12:53 ` [PATCH for-next 3/7] RDMA/rtrs: Fix warning when use poll mode on client side Md Haris Iqbal
2021-09-22 12:53 ` [PATCH for-next 4/7] RDMA/rtrs: Replace duplicate check with is_pollqueue helper Md Haris Iqbal
2021-09-22 12:53 ` [PATCH for-next 5/7] RDMA/rtrs: Introduce destroy_cq helper Md Haris Iqbal
2021-09-22 12:53 ` [PATCH for-next 6/7] RDMA/rtrs: Do not allow sessname to contain special symbols / and Md Haris Iqbal
2021-09-27 12:22 ` Leon Romanovsky
2021-09-28 7:08 ` Jack Wang
2021-09-28 7:28 ` Leon Romanovsky
2021-09-29 7:00 ` Jack Wang
2021-09-29 12:04 ` Leon Romanovsky
2021-09-30 6:03 ` Jinpu Wang
2021-09-30 7:01 ` Leon Romanovsky
2021-09-30 7:10 ` Jinpu Wang
2021-09-30 7:53 ` Leon Romanovsky
2021-10-01 12:40 ` Jinpu Wang
2021-10-01 14:56 ` Leon Romanovsky
2021-10-04 5:41 ` Jinpu Wang
2021-10-04 18:47 ` Jason Gunthorpe [this message]
2021-10-04 21:05 ` Jinpu Wang
2021-09-22 12:53 ` [PATCH for-next 7/7] RDMA/rtrs-clt: Follow "one entry one value" rule for IO migration stats Md Haris Iqbal
2021-10-04 19:49 ` [PATCH for-next 0/7] Misc update for RTRS Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004184718.GD3544071@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aleksei.marov@ionos.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=gi-oh.kim@ionos.com \
--cc=haris.iqbal@ionos.com \
--cc=jinpu.wang@ionos.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.