From: Stephen Hemminger <stephen@networkplumber.org>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, Ali Alnubani <alialnu@nvidia.com>,
Gregory Etelson <getelson@nvidia.com>,
David Marchand <david.marchand@redhat.com>,
Olivier Matz <olivier.matz@6wind.com>,
Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] cmdline: make struct rdline opaque
Date: Tue, 5 Oct 2021 13:42:13 -0700 [thread overview]
Message-ID: <20211005134213.3ed96d4f@hermes.local> (raw)
In-Reply-To: <20211005201545.179902-3-dmitry.kozliuk@gmail.com>
On Tue, 5 Oct 2021 23:15:45 +0300
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> +++ b/app/test/test_cmdline_lib.c
> @@ -83,18 +83,19 @@ test_cmdline_parse_fns(void)
> static int
> test_cmdline_rdline_fns(void)
> {
> - struct rdline rdl;
> + struct rdline *rdl = NULL;
Very minor nit. The variable does not need to be initialized
since first statement assigns the value.
next prev parent reply other threads:[~2021-10-05 20:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 23:16 [dpdk-dev] [PATCH] cmdline: make cmdline structure opaque Dmitry Kozlyuk
2021-09-10 23:16 ` [dpdk-dev] [PATCH] cmdline: reduce ABI Dmitry Kozlyuk
2021-09-20 11:11 ` David Marchand
2021-09-20 11:21 ` Olivier Matz
2021-09-28 19:47 ` [dpdk-dev] [PATCH v2 0/2] " Dmitry Kozlyuk
2021-09-28 19:47 ` [dpdk-dev] [PATCH v2 1/2] cmdline: make struct cmdline opaque Dmitry Kozlyuk
2021-09-28 19:47 ` [dpdk-dev] [PATCH v2 2/2] cmdline: make struct rdline opaque Dmitry Kozlyuk
2021-10-05 0:55 ` [dpdk-dev] [PATCH v3 0/2] cmdline: reduce ABI Dmitry Kozlyuk
2021-10-05 0:55 ` [dpdk-dev] [PATCH v3 1/2] cmdline: make struct cmdline opaque Dmitry Kozlyuk
2021-10-05 0:55 ` [dpdk-dev] [PATCH v3 2/2] cmdline: make struct rdline opaque Dmitry Kozlyuk
2021-10-05 8:27 ` Olivier Matz
2021-10-05 9:03 ` Dmitry Kozlyuk
2021-10-05 9:11 ` Olivier Matz
2021-10-05 20:15 ` [dpdk-dev] [PATCH v4 0/2] cmdline: reduce ABI Dmitry Kozlyuk
2021-10-05 20:15 ` [dpdk-dev] [PATCH v4 1/2] cmdline: make struct cmdline opaque Dmitry Kozlyuk
2021-10-05 20:15 ` [dpdk-dev] [PATCH v4 2/2] cmdline: make struct rdline opaque Dmitry Kozlyuk
2021-10-05 20:42 ` Stephen Hemminger [this message]
2021-10-06 8:11 ` Olivier Matz
2021-10-07 22:10 ` [dpdk-dev] [PATCH v5 0/2] cmdline: reduce ABI Dmitry Kozlyuk
2021-10-07 22:10 ` [dpdk-dev] [PATCH v5 1/2] cmdline: make struct cmdline opaque Dmitry Kozlyuk
2021-10-08 22:56 ` Narcisa Ana Maria Vasile
2021-10-07 22:10 ` [dpdk-dev] [PATCH v5 2/2] cmdline: make struct rdline opaque Dmitry Kozlyuk
2021-10-08 22:57 ` Narcisa Ana Maria Vasile
2021-10-22 21:24 ` [dpdk-dev] [PATCH v5 0/2] cmdline: reduce ABI Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005134213.3ed96d4f@hermes.local \
--to=stephen@networkplumber.org \
--cc=alialnu@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=getelson@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.