From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C12FC433EF for ; Tue, 5 Oct 2021 22:02:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB52D61211 for ; Tue, 5 Oct 2021 22:02:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EB52D61211 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B9F6A8310F; Wed, 6 Oct 2021 00:02:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HmFtXYn3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7B8EC8310F; Wed, 6 Oct 2021 00:02:13 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B8D128310F for ; Wed, 6 Oct 2021 00:02:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id 73so530851qki.4 for ; Tue, 05 Oct 2021 15:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tqWadza9tUmARr+NijO1YABOsRQMSx6D/M2qhZ5Tzho=; b=HmFtXYn3QbxNmQ0kNSbhlrun4OfOByui3l3iUaT2ktk3eggsKgCOndydu8GJMj7Y/S U7NtgxtneZyo8a6JTgzRRUi5tgUNNOzpHLcSW/sBetoNIVAQnGpMJFFFauAhVQikrS+G M22/6flopa7UjgjmHxhVF7zThLMDYuI2HkMy0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tqWadza9tUmARr+NijO1YABOsRQMSx6D/M2qhZ5Tzho=; b=UNA+uBS25DS9gVpUgLp/t+OpZgX/M3wnmcfkl3SHMfnlYsZRN0kIvbXMD2TuTXx7Gq 0qm4LXCCjFuMjsfW3sBugIkqliZBam9Ce3hTswfIy9AAj+SI6CavwZDTfVSVXZ9YfFBu 0uX5xCBgZv02xP3mDrWFvhtjBKWfuHafzEGbHt22mPiUwUSOW5rCLudhagQVc51IY/X3 Rpr9tHT/Tg/lwdskosp2F7hjjXcl2dw66Ef4Bt+5BfOIeeXJd979odv6aIbQqfF18fdt D9QEw4LDgqj9iIjPbVWnzGCSUYc1vcUhlh9sPq6hHOEnR/VAXvXrwfk5u8B2ql+q/1X7 vVLw== X-Gm-Message-State: AOAM533joPbs3uK59s43jvyigfIvPoPSaGaWeWwHfNWR2fMwOsLa58nO 0Al8UEFluxSz6nWTFB9E1+UyVg== X-Google-Smtp-Source: ABdhPJyHZ9mgRxBqYgKa46XR7QFNLoFR0D/zG4irVKgLLJVhqHOfmiDPMrRhEQyOq/yxmRjU/9lPdQ== X-Received: by 2002:a37:301:: with SMTP id 1mr17194318qkd.510.1633471322257; Tue, 05 Oct 2021 15:02:02 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-acff-2c31-c6db-812f.res6.spectrum.com. [2603:6081:7b01:cbda:acff:2c31:c6db:812f]) by smtp.gmail.com with ESMTPSA id t24sm2238158qkj.38.2021.10.05.15.02.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Oct 2021 15:02:01 -0700 (PDT) Date: Tue, 5 Oct 2021 18:01:59 -0400 From: Tom Rini To: Alexandru Gagniuc Cc: u-boot@lists.denx.de, patrick.delaunay@foss.st.com, etienne.carriere@linaro.org, sbabic@denx.de, festevam@gmail.com Subject: Re: [PATCH 3/4] lib: optee: Remove CONFIG_OPTEE_LOAD_ADDR Message-ID: <20211005220159.GE31748@bill-the-cat> References: <20210907170709.2684890-1-mr.nuke.me@gmail.com> <20210907170709.2684890-4-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wuuVUd7pnaKXXwQq" Content-Disposition: inline In-Reply-To: <20210907170709.2684890-4-mr.nuke.me@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --wuuVUd7pnaKXXwQq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 07, 2021 at 12:07:08PM -0500, Alexandru Gagniuc wrote: > This value is not used by u-boot, and it should not. The load address > of an OPTEE image is defined by said image. Either a uImage or a FIT > will have a defined load address and entry point. Those values are the > correct ones, not CONFIG_OPTEE_LOAD_ADDR. >=20 > Commit f25006b96e9f ("optee: Add CONFIG_OPTEE_LOAD_ADDR") justifies > this config by requiring its presence in u-boot's .config for other > images as part of a larger build, claiming it is "the best way". >=20 > This argument is not persuasive. U-boot's configuration is driven by > platform requirements, not the other way around. It seems more likely > that the argument is conflating tooling issues with Kconfig. Yocto and > buildroot have excellent mechanisms for defining values across the > board (pun intended). u-boot's Kconfig is the wrong place to do it. >=20 > Furthermore, it is not "best" for u-boot because it hardcodes a value > which is then not used. In fact the load address that u-boot uses is > the one derived from the OPTEE image. >=20 > Confused yet? I sure was. To prevent future confusion, remove > CONFIG_OPTEE_LOAD_ADDR. >=20 > Signed-off-by: Alexandru Gagniuc Applied to u-boot/master, thanks! --=20 Tom --wuuVUd7pnaKXXwQq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFcy1cACgkQFHw5/5Y0 tyxB1Av+Kf4nAuWlgrwRCBdKPH1d1JP1hJGXvJBfVdwNrIYW7XSs8CaJ2PqKklx6 IZeW+nkaKo306bZLOYS1v9oY9IdRS+3dG8o6xDNUWLb/fnbCbv7ugKDpfmU4WTgF AZB1ByDC8hvlu88+XlUO0w2b1Om8FLED/0/4g2xIjG1GN7alN1ZYLiLUbH2+T1S7 G/gAuclwzMXNESEbZE2mwGJXEWrIPqHpngf0Mn5+nrShZx4YP9AjE097YMzw9+Bb UW6AGwyVy3T+tR+sRqqiZlclp51Um0Ja27W0LUZjARgTG6HpgBBRxyVmAUQbnzdq gIp4owl9zHTEWu5gXJ3a5jOVisPjRPgKjar02f1ttIPePiYXUl1OScPAQ+MBvpEI U7wusMROFThkxd/0Grby77Rhrmx19h3vEz6Dy8rI/DDnaeUc/Uor00XYmPwB87wr JufRa3kUQbiCZFYllEI5t6t9+1coiNt2keE9w5pcC41R5/CMEsuhyonODO2BDe5p juG9vbu5 =+6MJ -----END PGP SIGNATURE----- --wuuVUd7pnaKXXwQq--