All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Dan Williams <dan.j.williams@intel.com>, Vinod Koul <vkoul@kernel.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH
Date: Wed,  6 Oct 2021 11:34:16 +0200	[thread overview]
Message-ID: <20211006093416.4750-1-lukas.bulwahn@gmail.com> (raw)

Commit b802c8410ca9 ("async_tx: deprecate broken support for channel
switching") in 2017 intended to "prevent async_tx from using an offload
engine if the channel switching capability is enabled" by adding a
suitable ifdef on the corresponding config.

The config for determining if  the channel switching capability is
enabled is called CONFIG_ASYNC_TX_ENABLE_CHANNEL_SWITCH, however
the ifdef falsely refers to CONFIG_ASYNC_TX_CHANNEL_SWITCH (note the
missing "ENABLE").

Correct the name of the config to the intended one.

Fixes: b802c8410ca9 ("async_tx: deprecate broken support for channel switching")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 include/linux/async_tx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/async_tx.h b/include/linux/async_tx.h
index 5cc73d7e5b52..8c7b940d9912 100644
--- a/include/linux/async_tx.h
+++ b/include/linux/async_tx.h
@@ -74,7 +74,7 @@ struct async_submit_ctl {
 	void *scribble;
 };
 
-#if defined(CONFIG_DMA_ENGINE) && !defined(CONFIG_ASYNC_TX_CHANNEL_SWITCH)
+#if defined(CONFIG_DMA_ENGINE) && !defined(CONFIG_ASYNC_TX_ENABLE_CHANNEL_SWITCH)
 #define async_tx_issue_pending_all dma_issue_pending_all
 
 /**
-- 
2.26.2


             reply	other threads:[~2021-10-06  9:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06  9:34 Lukas Bulwahn [this message]
2021-10-06 13:29 ` [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH kernel test robot
2021-10-06 13:29   ` kernel test robot
2021-10-06 20:44 ` kernel test robot
2021-10-06 20:44   ` kernel test robot
2021-10-06 20:51 ` kernel test robot
2021-10-06 20:51   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211006093416.4750-1-lukas.bulwahn@gmail.com \
    --to=lukas.bulwahn@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.