From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - debug: fix stack tracing
Date: Wed, 6 Oct 2021 13:47:48 +0000 (GMT) [thread overview]
Message-ID: <20211006134748.ADDBC385C409@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=b7e9ec0cbf55e4a4e1f027be49bf45b11beb5a76
Commit: b7e9ec0cbf55e4a4e1f027be49bf45b11beb5a76
Parent: e30f3c84109b7e131da2497965aee83d73c604e3
Author: Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate: Fri Oct 1 13:44:17 2021 +0200
Committer: Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Wed Oct 6 15:39:58 2021 +0200
debug: fix stack tracing
Emit stack trace only on log_error path, and avoid on 'expected'
not-found path.
---
lib/metadata/metadata.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c
index b3c8c6ece..f29e73c7c 100644
--- a/lib/metadata/metadata.c
+++ b/lib/metadata/metadata.c
@@ -5015,7 +5015,7 @@ struct volume_group *vg_read(struct cmd_context *cmd, const char *vg_name, const
unlock_vg(cmd, NULL, vg_name);
log_error("VG name not found for vgid %s", vgid);
failure |= FAILED_NOTFOUND;
- goto_bad;
+ goto bad;
}
/*
@@ -5037,7 +5037,7 @@ struct volume_group *vg_read(struct cmd_context *cmd, const char *vg_name, const
if (!(vg_read_flags & READ_OK_NOTFOUND))
log_error("Volume group \"%s\" not found", vg_name);
failure |= FAILED_NOTFOUND;
- goto_bad;
+ goto bad;
}
/*
@@ -5053,7 +5053,7 @@ struct volume_group *vg_read(struct cmd_context *cmd, const char *vg_name, const
if (!(vg_read_flags & READ_OK_NOTFOUND))
log_error("Volume group \"%s\" not found.", vg_name);
failure |= FAILED_NOTFOUND;
- goto_bad;
+ goto bad;
}
/*
@@ -5264,7 +5264,7 @@ bad:
/* caller must unlock_vg and release_vg */
*error_vg = vg;
- return_NULL;
+ return NULL;
}
if (vg) {
reply other threads:[~2021-10-06 13:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006134748.ADDBC385C409@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.