From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A22C433EF for ; Wed, 6 Oct 2021 14:06:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A2116109F for ; Wed, 6 Oct 2021 14:06:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231540AbhJFOIl (ORCPT ); Wed, 6 Oct 2021 10:08:41 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3938 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbhJFOIk (ORCPT ); Wed, 6 Oct 2021 10:08:40 -0400 Received: from fraeml744-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HPbl84kNTz67vYw; Wed, 6 Oct 2021 22:03:16 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml744-chm.china.huawei.com (10.206.15.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 6 Oct 2021 16:06:46 +0200 Received: from localhost (10.52.120.239) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 6 Oct 2021 15:06:46 +0100 Date: Wed, 6 Oct 2021 15:06:28 +0100 From: Jonathan Cameron To: Qi Liu CC: , , , , , , , Subject: Re: [PATCH v10 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Message-ID: <20211006150628.00007cbf@Huawei.com> In-Reply-To: <20210915074524.18040-3-liuqi115@huawei.com> References: <20210915074524.18040-1-liuqi115@huawei.com> <20210915074524.18040-3-liuqi115@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.120.239] X-ClientProxiedBy: lhreml722-chm.china.huawei.com (10.201.108.73) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, 15 Sep 2021 15:45:24 +0800 Qi Liu wrote: > PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported > to sample bandwidth, latency, buffer occupation etc. > > Each PMU RCiEP device monitors multiple Root Ports, and each RCiEP is > registered as a PMU in /sys/bus/event_source/devices, so users can > select target PMU, and use filter to do further sets. > > Filtering options contains: > event - select the event. > port - select target Root Ports. Information of Root Ports are > shown under sysfs. > bdf - select requester_id of target EP device. > trig_len - set trigger condition for starting event statistics. > trig_mode - set trigger mode. 0 means starting to statistic when bigger > than trigger condition, and 1 means smaller. > thr_len - set threshold for statistics. > thr_mode - set threshold mode. 0 means count when bigger than threshold, > and 1 means smaller. > > Reviewed-by: John Garry > Signed-off-by: Qi Liu > --- Hi Qi, One trivial thing I just noticed below that can be easily fixed up by a follow up patch if that makes sense. Thanks, Jonathan > +/* > + * Events with the "dl" suffix in their names count performance in DL layer, > + * otherswise, events count performance in TL layer. This comment looks to be out of date.. > + */ > +static struct attribute *hisi_pcie_pmu_events_attr[] = { > + HISI_PCIE_PMU_EVENT_ATTR(rx_mwr_latency, 0x0010), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mwr_cnt, 0x10010), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_latency, 0x0210), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_cnt, 0x10210), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_latency, 0x0011), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_cnt, 0x10011), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_flux, 0x1005), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_time, 0x11005), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_flux, 0x2004), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_time, 0x12004), > + NULL > +}; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E6FC433F5 for ; Wed, 6 Oct 2021 14:08:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6892C6105A for ; Wed, 6 Oct 2021 14:08:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6892C6105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4wQH2hLe/sUNneEKk3H1Pi87kiMRnJ8kwxgaOJx5eFs=; b=ZnbK9tHDJgZK9J KcFRTtdol7Ffn0M2kv4+EPTD/IQOjZY6KsmiR8JA/6M/sTNX8bYJfJKXskKRK7xQMFVSO8hMbd+fb SRHOyAXbJl4GM+N8zi5CccpGZ93/ohzISf0QGOzgybCb7RF+4qyyRs4N1vczO4AkOfshb34Hxe91b 7dVPHrwQxFmOoaXTgZZ7PX2uPxhuxAz9RYX2IAsgK/ogOkp0LoA9izqN7LNqOvTx9AeuLDCBahoPi orw+Vu5YJTEuKTVQsWN2acfskpDxSZJK/qIgPW16aVgMcKTGwMrA0KUZLtOlu1m02GQBHjtvjWb9L UR20beK1Xe1nNmKOg6mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY7ZY-00Ea8H-MD; Wed, 06 Oct 2021 14:07:04 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY7ZU-00Ea7L-GI for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 14:07:02 +0000 Received: from fraeml744-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HPbl84kNTz67vYw; Wed, 6 Oct 2021 22:03:16 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml744-chm.china.huawei.com (10.206.15.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 6 Oct 2021 16:06:46 +0200 Received: from localhost (10.52.120.239) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 6 Oct 2021 15:06:46 +0100 Date: Wed, 6 Oct 2021 15:06:28 +0100 From: Jonathan Cameron To: Qi Liu CC: , , , , , , , Subject: Re: [PATCH v10 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Message-ID: <20211006150628.00007cbf@Huawei.com> In-Reply-To: <20210915074524.18040-3-liuqi115@huawei.com> References: <20210915074524.18040-1-liuqi115@huawei.com> <20210915074524.18040-3-liuqi115@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.120.239] X-ClientProxiedBy: lhreml722-chm.china.huawei.com (10.201.108.73) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_070700_748008_A2A56420 X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 15 Sep 2021 15:45:24 +0800 Qi Liu wrote: > PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported > to sample bandwidth, latency, buffer occupation etc. > > Each PMU RCiEP device monitors multiple Root Ports, and each RCiEP is > registered as a PMU in /sys/bus/event_source/devices, so users can > select target PMU, and use filter to do further sets. > > Filtering options contains: > event - select the event. > port - select target Root Ports. Information of Root Ports are > shown under sysfs. > bdf - select requester_id of target EP device. > trig_len - set trigger condition for starting event statistics. > trig_mode - set trigger mode. 0 means starting to statistic when bigger > than trigger condition, and 1 means smaller. > thr_len - set threshold for statistics. > thr_mode - set threshold mode. 0 means count when bigger than threshold, > and 1 means smaller. > > Reviewed-by: John Garry > Signed-off-by: Qi Liu > --- Hi Qi, One trivial thing I just noticed below that can be easily fixed up by a follow up patch if that makes sense. Thanks, Jonathan > +/* > + * Events with the "dl" suffix in their names count performance in DL layer, > + * otherswise, events count performance in TL layer. This comment looks to be out of date.. > + */ > +static struct attribute *hisi_pcie_pmu_events_attr[] = { > + HISI_PCIE_PMU_EVENT_ATTR(rx_mwr_latency, 0x0010), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mwr_cnt, 0x10010), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_latency, 0x0210), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_cnt, 0x10210), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_latency, 0x0011), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_cnt, 0x10011), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_flux, 0x1005), > + HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_time, 0x11005), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_flux, 0x2004), > + HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_time, 0x12004), > + NULL > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel