From: Denys Dmytriyenko <denis@denix.org>
To: Vivien Didelot <vivien.didelot@gmail.com>
Cc: meta-arago@arago-project.org, Denys Dmytriyenko <denys@konsulko.com>
Subject: Re: [PATCH] qtwebengine: replace patch with chromium flags
Date: Wed, 6 Oct 2021 19:35:56 -0400 [thread overview]
Message-ID: <20211006233556.GP1528@denix.org> (raw)
In-Reply-To: <20211006193120.GB4085741@t480s.localdomain>
On Wed, Oct 06, 2021 at 07:31:20PM -0400, Vivien Didelot wrote:
> Hi Denys,
>
> On Wed, 06 Oct 2021 19:19:56 -0400 Denys Dmytriyenko <denis@denix.org> wrote:
> > On Wed, Oct 06, 2021 at 04:54:54PM -0400, Vivien Didelot wrote:
> > > Instead of maintaining an inappropriate hack on qtwebengine to disable
> > > seccomp filter sandbox, export the corresponding chromium flag in
> > > the QTWEBENGINE_CHROMIUM_FLAGS environment variable.
> > >
> > > Signed-off-by: Vivien Didelot <vdidelot@pbsc.com>
> > > ---
> > > .../qt5/qtbase-conf/ti33x/qt_env.sh | 5 +++
> > > ...-disable-SECCOMP-BPF-Sandbox-at-star.patch | 32 -------------------
> > > .../recipes-qt/qt5/qtwebengine_git.bbappend | 4 ---
> > > 3 files changed, 5 insertions(+), 36 deletions(-)
> > > delete mode 100644 meta-arago-distro/recipes-qt/qt5/qtwebengine/0003-qtwebengine-HACK-disable-SECCOMP-BPF-Sandbox-at-star.patch
> > >
> > > diff --git a/meta-arago-distro/recipes-qt/qt5/qtbase-conf/ti33x/qt_env.sh b/meta-arago-distro/recipes-qt/qt5/qtbase-conf/ti33x/qt_env.sh
> > > index 29fa2969..96526393 100644
> > > --- a/meta-arago-distro/recipes-qt/qt5/qtbase-conf/ti33x/qt_env.sh
> > > +++ b/meta-arago-distro/recipes-qt/qt5/qtbase-conf/ti33x/qt_env.sh
> > > @@ -7,3 +7,8 @@ export QT_QPA_EGLFS_KMS_CONFIG=/etc/qt5/eglfs_kms_cfg.json
> > > export QT_QPA_EGLFS_INTEGRATION=eglfs_kms
> > > export QT_QPA_EGLFS_ALWAYS_SET_MODE=1
> > > export QT_WAYLAND_SHELL_INTEGRATION=wl-shell
> > > +
> > > +# SECCOMP-BPF Sandbox does not work due to unexpected FUTEX_UNLOCK_PI call
> > > +# from the pthread implementation. Disable this feature temporarily until
> > > +# those issues are resolved.
> > > +export QTWEBENGINE_CHROMIUM_FLAGS="--disable-seccomp-filter-sandbox"
> >
> > Why is this only done for ti33x platform? What about other platforms?
>
> Good catch! Should I bbappend the qtwebengine recipe instead to deploy
> a new qtwebengine_env.sh file containing QTWEBENGINE_CHROMIUM_FLAGS?
Can you add to both qt_env.sh files - generic and ti33x specific?
--
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186 6D76 4209 0272 9A92 C964
prev parent reply other threads:[~2021-10-06 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 20:54 [PATCH] qtwebengine: replace patch with chromium flags Vivien Didelot
2021-10-06 23:19 ` Denys Dmytriyenko
2021-10-06 23:31 ` Vivien Didelot
2021-10-06 23:35 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006233556.GP1528@denix.org \
--to=denis@denix.org \
--cc=denys@konsulko.com \
--cc=meta-arago@arago-project.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.