From: Peter Zijlstra <peterz@infradead.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] x86/apic: reduce cache line misses in __x2apic_send_IPI_mask()
Date: Thu, 7 Oct 2021 09:29:17 +0200 [thread overview]
Message-ID: <20211007072917.GN174703@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20211007031756.345269-1-eric.dumazet@gmail.com>
On Wed, Oct 06, 2021 at 08:17:56PM -0700, Eric Dumazet wrote:
> +/* __x2apic_send_IPI_mask() possibly needs to read
> + * x86_cpu_to_logical_apicid for all online cpus in a sequential way.
> + * Using per cpu variable would cost one cache line per cpu.
> + */
Broken comment style..
> +static u32 x86_cpu_to_logical_apicid[NR_CPUS] __read_mostly;
NR_CPUS is really sad, could this at all be dynamically allocated? Say
in x2apic_cluster_probe() ?
Otherwise this looks very nice!
next prev parent reply other threads:[~2021-10-07 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 3:17 [PATCH] x86/apic: reduce cache line misses in __x2apic_send_IPI_mask() Eric Dumazet
2021-10-07 7:29 ` Peter Zijlstra [this message]
2021-10-07 14:04 ` Eric Dumazet
2021-10-07 14:06 ` Peter Zijlstra
2021-10-07 14:13 ` Eric Dumazet
2021-10-07 22:13 ` Eric Dumazet
2021-10-12 12:45 ` Peter Zijlstra
2021-10-13 18:02 ` Eric Dumazet
2021-10-15 13:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007072917.GN174703@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.