From: "Darrick J. Wong" <djwong@kernel.org>
To: Catherine Hoang <catherine.hoang@oracle.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org,
allison.henderson@oracle.com
Subject: Re: [PATCH v2 2/4] xfstests: Rename _test_inject_logprint to _test_remount_dump_log
Date: Thu, 7 Oct 2021 09:19:53 -0700 [thread overview]
Message-ID: <20211007161953.GC24282@magnolia> (raw)
In-Reply-To: <20211007002641.714906-3-catherine.hoang@oracle.com>
On Thu, Oct 07, 2021 at 12:26:39AM +0000, Catherine Hoang wrote:
> Rename _test_inject_logprint to _test_remount_dump_log to better
> describe what this function does. _test_remount_dump_log unmounts
> and remounts the test device, dumping the log.
>
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
> Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> common/inject | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/inject b/common/inject
> index 3b731df7..b5334d4a 100644
> --- a/common/inject
> +++ b/common/inject
> @@ -126,7 +126,7 @@ _scratch_remount_dump_log()
> }
>
> # Unmount and remount the test device, dumping the log
> -_test_inject_logprint()
> +_test_remount_dump_log()
> {
> local opts="$1"
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-10-07 16:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 0:26 [PATCH v2 0/4] Dump log cleanups Catherine Hoang
2021-10-07 0:26 ` [PATCH v2 1/4] xfstests: Rename _scratch_inject_logprint to _scratch_remount_dump_log Catherine Hoang
2021-10-07 16:20 ` Darrick J. Wong
2021-10-07 0:26 ` [PATCH v2 2/4] xfstests: Rename _test_inject_logprint to _test_remount_dump_log Catherine Hoang
2021-10-07 16:19 ` Darrick J. Wong [this message]
2021-10-07 0:26 ` [PATCH v2 3/4] common/log: Move *_dump_log routines to common/log Catherine Hoang
2021-10-07 16:19 ` Darrick J. Wong
2021-10-07 0:26 ` [PATCH v2 4/4] common/log: Fix *_dump_log routines for ext4 Catherine Hoang
2021-10-07 16:15 ` Darrick J. Wong
2021-10-07 18:24 ` [External] : " Catherine Hoang
2021-10-08 17:49 ` Allison Henderson
2021-10-08 19:06 ` Catherine Hoang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007161953.GC24282@magnolia \
--to=djwong@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=catherine.hoang@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.