All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: julien@xen.org, sstabellini@kernel.org,
	oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com,
	Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com,
	andrew.cooper3@citrix.com, george.dunlap@citrix.com,
	paul@xen.org, bertrand.marquis@arm.com, rahul.singh@arm.com,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH v5 04/10] xen/arm: Mark device as PCI while creating one
Date: Fri,  8 Oct 2021 08:55:29 +0300	[thread overview]
Message-ID: <20211008055535.337436-5-andr2000@gmail.com> (raw)
In-Reply-To: <20211008055535.337436-1-andr2000@gmail.com>

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

While adding a PCI device mark it as such, so other frameworks
can distinguish it from DT devices.
For that introduce an architecture defined helper which may perform
additional initialization of the newly created PCI device.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
[applicable parts]
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Rahul Singh <rahul.singh@arm.com>
Tested-by: Rahul Singh <rahul.singh@arm.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Paul Durrant <paul@xen.org>

Since v3:
- fixed Arm build without CONFIG_HAS_PCI
Since v2:
 - !! dropped Stefano's r-b because of the changes
 - introduced arch_pci_init_pdev (Jan)
Since v1:
 - moved the assignment from iommu_add_device to alloc_pdev
---
 xen/arch/arm/pci/pci.c        | 5 +++++
 xen/drivers/passthrough/pci.c | 2 ++
 xen/include/asm-arm/pci.h     | 7 +++++++
 xen/include/asm-x86/pci.h     | 2 ++
 4 files changed, 16 insertions(+)

diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c
index 138da19284ab..082c14e127a8 100644
--- a/xen/arch/arm/pci/pci.c
+++ b/xen/arch/arm/pci/pci.c
@@ -34,6 +34,11 @@ struct pci_dev *dev_to_pci(struct device *dev)
     return container_of(dev, struct pci_dev, arch.dev);
 }
 
+void arch_pci_init_pdev(struct pci_dev *pdev)
+{
+    pci_to_dev(pdev)->type = DEV_PCI;
+}
+
 static int __init dt_pci_init(void)
 {
     struct dt_device_node *np;
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index b36d5a481162..9e6246afeef5 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -329,6 +329,8 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn)
     *((u8*) &pdev->devfn) = devfn;
     pdev->domain = NULL;
 
+    arch_pci_init_pdev(pdev);
+
     rc = pdev_msi_init(pdev);
     if ( rc )
     {
diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h
index 9aa8eca53175..98cb22d39ef1 100644
--- a/xen/include/asm-arm/pci.h
+++ b/xen/include/asm-arm/pci.h
@@ -105,6 +105,9 @@ static always_inline bool is_pci_passthrough_enabled(void)
 {
     return pci_passthrough_enabled;
 }
+
+void arch_pci_init_pdev(struct pci_dev *pdev);
+
 #else   /*!CONFIG_HAS_PCI*/
 
 struct arch_pci_dev { };
@@ -121,5 +124,9 @@ static inline int pci_get_host_bridge_segment(const struct dt_device_node *node,
     return -EINVAL;
 }
 
+struct pci_dev;
+
+static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
+
 #endif  /*!CONFIG_HAS_PCI*/
 #endif /* __ARM_PCI_H__ */
diff --git a/xen/include/asm-x86/pci.h b/xen/include/asm-x86/pci.h
index c4a4fdcbc239..443f25347d08 100644
--- a/xen/include/asm-x86/pci.h
+++ b/xen/include/asm-x86/pci.h
@@ -36,4 +36,6 @@ static always_inline bool is_pci_passthrough_enabled(void)
     return true;
 }
 
+static inline void arch_pci_init_pdev(struct pci_dev *pdev) {}
+
 #endif /* __X86_PCI_H__ */
-- 
2.25.1



  parent reply	other threads:[~2021-10-08  5:56 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08  5:55 [PATCH v5 00/10] PCI devices passthrough on Arm, part 2 Oleksandr Andrushchenko
2021-10-08  5:55 ` [PATCH v5 01/10] xen/arm: Add new device type for PCI Oleksandr Andrushchenko
2021-10-08  5:55 ` [PATCH v5 02/10] xen/arm: Introduce pci_find_host_bridge_node helper Oleksandr Andrushchenko
2021-10-08  5:55 ` [PATCH v5 03/10] xen/device-tree: Make dt_find_node_by_phandle global Oleksandr Andrushchenko
2021-10-08  5:55 ` Oleksandr Andrushchenko [this message]
2021-10-08  5:55 ` [PATCH v5 05/10] xen/domain: Call pci_release_devices() when releasing domain resources Oleksandr Andrushchenko
2021-10-08  5:55 ` [PATCH v5 06/10] libxl: Allow removing PCI devices for all types of domains Oleksandr Andrushchenko
2021-10-11 16:11   ` Anthony PERARD
2021-10-11 16:16     ` Oleksandr Andrushchenko
2021-10-25 13:14   ` Roger Pau Monné
2021-10-25 13:17     ` Oleksandr Andrushchenko
2021-10-08  5:55 ` [PATCH v5 07/10] libxl: Only map legacy PCI IRQs if they are supported Oleksandr Andrushchenko
2021-10-11 16:37   ` Anthony PERARD
2021-10-12  1:32     ` Stefano Stabellini
2021-10-25 13:22   ` Roger Pau Monné
2021-10-25 13:38     ` Oleksandr Andrushchenko
2021-10-25 13:46       ` Roger Pau Monné
2021-11-02 11:32       ` Jan Beulich
2021-11-02 11:37         ` Oleksandr Andrushchenko
2021-10-08  5:55 ` [PATCH v5 08/10] xen/arm: Setup MMIO range trap handlers for hardware domain Oleksandr Andrushchenko
2021-10-13 10:11   ` Roger Pau Monné
2021-10-25  9:38     ` Oleksandr Andrushchenko
2021-10-25 13:40       ` Roger Pau Monné
2021-10-25 13:47         ` Oleksandr Andrushchenko
2021-10-08  5:55 ` [PATCH v5 09/10] xen/arm: Do not map PCI ECAM and MMIO space to Domain-0's p2m Oleksandr Andrushchenko
2021-10-08 23:00   ` Stefano Stabellini
2021-10-13 16:17   ` Julien Grall
2021-10-25 11:37     ` Oleksandr Andrushchenko
2021-10-28 11:13       ` Julien Grall
2021-10-28 11:20         ` Oleksandr Andrushchenko
2021-10-08  5:55 ` [PATCH v5 10/10] xen/arm: Process pending vPCI map/unmap operations Oleksandr Andrushchenko
2021-10-13 15:30   ` Julien Grall
2021-10-25 11:24     ` Oleksandr Andrushchenko
2021-10-08 22:54 ` [PATCH v5 00/10] PCI devices passthrough on Arm, part 2 Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211008055535.337436-5-andr2000@gmail.com \
    --to=andr2000@gmail.com \
    --cc=Artem_Mygaiev@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bertrand.marquis@arm.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=paul@xen.org \
    --cc=rahul.singh@arm.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=volodymyr_babchuk@epam.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.