All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Whitchurch <vincent.whitchurch@axis.com>
To: Rob Herring <robh@kernel.org>
Cc: kernel <kernel@axis.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"peda@axentia.se" <peda@axentia.se>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: iio: io-channel-mux: Add property for settle time
Date: Fri, 8 Oct 2021 15:56:10 +0200	[thread overview]
Message-ID: <20211008135610.GA16402@axis.com> (raw)
In-Reply-To: <1633661172.633248.1409599.nullmailer@robh.at.kernel.org>

On Fri, Oct 08, 2021 at 04:46:12AM +0200, Rob Herring wrote:
> On Thu, 07 Oct 2021 15:46:40 +0200, Vincent Whitchurch wrote:
> > Hardware may require some time for the muxed analog signals to settle
> > after the muxing is changed.  Allow this time to be specified in the
> > devicetree.
> > 
> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> > ---
> >  .../devicetree/bindings/iio/multiplexer/io-channel-mux.yaml  | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.

Yes, these are not new warnings.

> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/1537724
> 
> 
> adc0mux: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dt.yaml
> 
> adc10mux: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	arch/arm/boot/dts/aspeed-bmc-ampere-mtjade.dt.yaml
[...]

I think the fix for these is to add a "#io-channel-cells": const 1 to
the schema.

> envelope-detector-mux: channels: ['', '', 'sync-1', 'in', 'out', 'sync-2', 'sys-reg', 'ana-reg'] has non-unique elements
> 	arch/arm/boot/dts/at91-tse850-3.dt.yaml

This one looks like an error in that particular devicetree.

  reply	other threads:[~2021-10-08 13:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 13:46 [PATCH v2 0/3] Add settle time support to iio-mux Vincent Whitchurch
2021-10-07 13:46 ` [PATCH v2 1/3] mux: add support for delay after muxing Vincent Whitchurch
2021-10-07 13:46 ` [PATCH v2 2/3] dt-bindings: iio: io-channel-mux: Add property for settle time Vincent Whitchurch
2021-10-08  2:46   ` Rob Herring
2021-10-08 13:56     ` Vincent Whitchurch [this message]
2021-10-08 15:27       ` Peter Rosin
2021-10-08 19:13         ` Rob Herring
2021-10-08 22:11     ` [PATCH 4/3] dt-bindings: iio: io-channel-mux: add optional #io-channel-cells Peter Rosin
2021-10-19 21:25       ` Rob Herring
2021-10-08 22:11   ` [PATCH 5/3] dt-bindings: iio: io-channel-mux: allow duplicate channel, labels Peter Rosin
2021-10-19 21:25     ` Rob Herring
2021-10-20 16:49       ` Jonathan Cameron
2021-10-18 19:52   ` [PATCH v2 2/3] dt-bindings: iio: io-channel-mux: Add property for settle time Rob Herring
2021-10-07 13:46 ` [PATCH v2 3/3] iio: multiplexer: iio-mux: Support settle-time-us property Vincent Whitchurch
2021-10-08 19:19 ` [PATCH v2 0/3] Add settle time support to iio-mux Lars-Peter Clausen
2021-10-19  7:03   ` Lars-Peter Clausen
2021-10-21 19:39     ` Jonathan Cameron
2021-10-08 23:09 ` Peter Rosin
2021-10-17 17:31   ` Jonathan Cameron
2021-10-17 21:08     ` Peter Rosin
2021-10-18 20:13       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211008135610.GA16402@axis.com \
    --to=vincent.whitchurch@axis.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kernel@axis.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.